Skip to content

chore: fix coding style with default value #3009

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

chore: fix coding style with default value #3009

wants to merge 1 commit into from

Conversation

pyaillet
Copy link

@pyaillet pyaillet commented Oct 7, 2020

Fix coding style for problem 8 solutions

Fixes: #2786

  • Fix a bug or typo in an existing algorithm?

I hope you don't mind, these fixes are so tiny I chose to gather them in the same PR.
Don't hesitate to tell me if you'd rather have them in separated PRs.

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@pyaillet pyaillet closed this Oct 7, 2020
@pyaillet
Copy link
Author

pyaillet commented Oct 7, 2020

Didn't see someone else did this before

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Project Euler] Algorithms do not follow coding styles
1 participant