From 4fae9f1bcb85d8b5c0aa4633b373489486419ef0 Mon Sep 17 00:00:00 2001 From: Himadri Ganguly Date: Wed, 15 Jul 2020 20:44:23 +0530 Subject: [PATCH 01/11] Removed unused variable m. --- dynamic_programming/coin_change.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dynamic_programming/coin_change.py b/dynamic_programming/coin_change.py index 2d7106f0cc6f..7395d2d982b4 100644 --- a/dynamic_programming/coin_change.py +++ b/dynamic_programming/coin_change.py @@ -7,7 +7,7 @@ """ -def dp_count(S, m, n): +def dp_count(S, n): """ >>> dp_count([1, 2, 3], 3, 4) 4 From ba5f999d17e361ab523d77f56ab01cefd921e973 Mon Sep 17 00:00:00 2001 From: Himadri Ganguly Date: Thu, 16 Jul 2020 01:55:03 +0530 Subject: [PATCH 02/11] Doctests are modified to match functions. --- dynamic_programming/coin_change.py | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/dynamic_programming/coin_change.py b/dynamic_programming/coin_change.py index 7395d2d982b4..f4f358ff3b34 100644 --- a/dynamic_programming/coin_change.py +++ b/dynamic_programming/coin_change.py @@ -9,15 +9,15 @@ def dp_count(S, n): """ - >>> dp_count([1, 2, 3], 3, 4) + >>> dp_count([1, 2, 3], 4) 4 - >>> dp_count([1, 2, 3], 3, 7) + >>> dp_count([1, 2, 3], 7) 8 - >>> dp_count([2, 5, 3, 6], 4, 10) + >>> dp_count([2, 5, 3, 6], 10) 5 - >>> dp_count([10], 1, 99) + >>> dp_count([10], 99) 0 - >>> dp_count([4, 5, 6], 3, 0) + >>> dp_count([4, 5, 6], 0) 1 """ From 06696c25571dff28ec80187124656b40c9643172 Mon Sep 17 00:00:00 2001 From: Himadri Ganguly Date: Thu, 16 Jul 2020 02:06:29 +0530 Subject: [PATCH 03/11] Added condition for negative values. --- dynamic_programming/coin_change.py | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/dynamic_programming/coin_change.py b/dynamic_programming/coin_change.py index f4f358ff3b34..ae4f4dc891bd 100644 --- a/dynamic_programming/coin_change.py +++ b/dynamic_programming/coin_change.py @@ -19,7 +19,12 @@ def dp_count(S, n): 0 >>> dp_count([4, 5, 6], 0) 1 + >>> dp_count([1, 2, 3], -5) + 0 """ + + if(n<1): + return(0) # table[i] represents the number of ways to get to amount i table = [0] * (n + 1) From e76d46abc7c6500af7889887fd6d1e03b18591ab Mon Sep 17 00:00:00 2001 From: Himadri Ganguly Date: Thu, 16 Jul 2020 02:12:34 +0530 Subject: [PATCH 04/11] Fixed white-space around operator. --- dynamic_programming/coin_change.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dynamic_programming/coin_change.py b/dynamic_programming/coin_change.py index ae4f4dc891bd..21b5cae20725 100644 --- a/dynamic_programming/coin_change.py +++ b/dynamic_programming/coin_change.py @@ -23,7 +23,7 @@ def dp_count(S, n): 0 """ - if(n<1): + if(n < 1): return(0) # table[i] represents the number of ways to get to amount i From cf667f87abed89ad9f412996ae5a5bd66498481c Mon Sep 17 00:00:00 2001 From: Himadri Ganguly Date: Thu, 16 Jul 2020 02:21:18 +0530 Subject: [PATCH 05/11] Fixed W293 blank line contains white-space error. --- dynamic_programming/coin_change.py | 2 -- 1 file changed, 2 deletions(-) diff --git a/dynamic_programming/coin_change.py b/dynamic_programming/coin_change.py index 21b5cae20725..e138aacee1f1 100644 --- a/dynamic_programming/coin_change.py +++ b/dynamic_programming/coin_change.py @@ -22,10 +22,8 @@ def dp_count(S, n): >>> dp_count([1, 2, 3], -5) 0 """ - if(n < 1): return(0) - # table[i] represents the number of ways to get to amount i table = [0] * (n + 1) From 90efe179ef235494a02aeed4b802ebcd4c456935 Mon Sep 17 00:00:00 2001 From: Himadri Ganguly Date: Mon, 20 Jul 2020 21:05:46 +0530 Subject: [PATCH 06/11] Update dynamic_programming/coin_change.py Co-authored-by: Tapajyoti Bose <44058757+ruppysuppy@users.noreply.github.com> --- dynamic_programming/coin_change.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dynamic_programming/coin_change.py b/dynamic_programming/coin_change.py index e138aacee1f1..e573a8ca31ef 100644 --- a/dynamic_programming/coin_change.py +++ b/dynamic_programming/coin_change.py @@ -22,7 +22,7 @@ def dp_count(S, n): >>> dp_count([1, 2, 3], -5) 0 """ - if(n < 1): + if n < 1: return(0) # table[i] represents the number of ways to get to amount i table = [0] * (n + 1) From 1a832d403f848c29d6f3b4fff05f4d53933f6370 Mon Sep 17 00:00:00 2001 From: Himadri Ganguly Date: Thu, 17 Sep 2020 13:22:30 +0530 Subject: [PATCH 07/11] Fixed error in code. --- dynamic_programming/coin_change.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/dynamic_programming/coin_change.py b/dynamic_programming/coin_change.py index e573a8ca31ef..002b7c48a346 100644 --- a/dynamic_programming/coin_change.py +++ b/dynamic_programming/coin_change.py @@ -22,8 +22,8 @@ def dp_count(S, n): >>> dp_count([1, 2, 3], -5) 0 """ - if n < 1: - return(0) + if n < 0: + return(0) # table[i] represents the number of ways to get to amount i table = [0] * (n + 1) From b37db2ef7236410a45d839ad350709ddbef6840b Mon Sep 17 00:00:00 2001 From: Himadri Ganguly Date: Thu, 17 Sep 2020 13:32:04 +0530 Subject: [PATCH 08/11] Fixed whited spacing. --- dynamic_programming/coin_change.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dynamic_programming/coin_change.py b/dynamic_programming/coin_change.py index 002b7c48a346..1a9d92110063 100644 --- a/dynamic_programming/coin_change.py +++ b/dynamic_programming/coin_change.py @@ -23,7 +23,7 @@ def dp_count(S, n): 0 """ if n < 0: - return(0) + return(0) # table[i] represents the number of ways to get to amount i table = [0] * (n + 1) From cc829a96e8eb7452004e6b1f98d79352e7985e59 Mon Sep 17 00:00:00 2001 From: Himadri Ganguly Date: Thu, 1 Oct 2020 18:00:55 +0530 Subject: [PATCH 09/11] Fixed PEP8 error. --- dynamic_programming/coin_change.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dynamic_programming/coin_change.py b/dynamic_programming/coin_change.py index 1a9d92110063..2869b5857be1 100644 --- a/dynamic_programming/coin_change.py +++ b/dynamic_programming/coin_change.py @@ -23,7 +23,7 @@ def dp_count(S, n): 0 """ if n < 0: - return(0) + return 0 # table[i] represents the number of ways to get to amount i table = [0] * (n + 1) From 19c2002eb7426c1f12ae8421dc9463d2c6505abd Mon Sep 17 00:00:00 2001 From: Himadri Ganguly Date: Thu, 1 Oct 2020 19:06:37 +0530 Subject: [PATCH 10/11] Added more test cases for coin change problem. --- dynamic_programming/coin_change.py | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/dynamic_programming/coin_change.py b/dynamic_programming/coin_change.py index 2869b5857be1..48622ea69077 100644 --- a/dynamic_programming/coin_change.py +++ b/dynamic_programming/coin_change.py @@ -21,6 +21,12 @@ def dp_count(S, n): 1 >>> dp_count([1, 2, 3], -5) 0 + >>> dp_count([4, 5, 6], -4) + 0 + >>> dp_count([2, 5, 3, 6], -10) + 0 + >>> dp_count([4], -4) + 0 """ if n < 0: return 0 From 7ca77cc0aa47e33b60838f97c36606391495c4f8 Mon Sep 17 00:00:00 2001 From: Himadri Ganguly Date: Mon, 5 Oct 2020 19:04:28 +0530 Subject: [PATCH 11/11] Removed extra test for negetive value. --- dynamic_programming/coin_change.py | 6 ------ 1 file changed, 6 deletions(-) diff --git a/dynamic_programming/coin_change.py b/dynamic_programming/coin_change.py index 48622ea69077..2869b5857be1 100644 --- a/dynamic_programming/coin_change.py +++ b/dynamic_programming/coin_change.py @@ -21,12 +21,6 @@ def dp_count(S, n): 1 >>> dp_count([1, 2, 3], -5) 0 - >>> dp_count([4, 5, 6], -4) - 0 - >>> dp_count([2, 5, 3, 6], -10) - 0 - >>> dp_count([4], -4) - 0 """ if n < 0: return 0