From f83bc52be953775b44429942ff04eb11bfad1088 Mon Sep 17 00:00:00 2001 From: lance-pyles Date: Thu, 23 Jul 2020 15:38:55 -0700 Subject: [PATCH 1/2] remove function overhead add type hints --- maths/area.py | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/maths/area.py b/maths/area.py index f317118ade06..c154fc233baa 100644 --- a/maths/area.py +++ b/maths/area.py @@ -5,7 +5,7 @@ from typing import Union -def surface_area_cube(side_length: Union[int, float]) -> float: +def surface_area_cube(side_length: float) -> float: """ Calculate the Surface Area of a Cube. @@ -14,7 +14,7 @@ def surface_area_cube(side_length: Union[int, float]) -> float: >>> surface_area_cube(3) 54 """ - return 6 * pow(side_length, 2) + return 6 * side_length ** 2 def surface_area_sphere(radius: float) -> float: @@ -28,10 +28,10 @@ def surface_area_sphere(radius: float) -> float: >>> surface_area_sphere(1) 12.566370614359172 """ - return 4 * pi * pow(radius, 2) + return 4 * pi * radius ** 2 -def area_rectangle(length, width): +def area_rectangle(length: float, width: float) -> float: """ Calculate the area of a rectangle @@ -41,17 +41,17 @@ def area_rectangle(length, width): return length * width -def area_square(side_length): +def area_square(side_length: float) -> float: """ Calculate the area of a square >>> area_square(10) 100 """ - return pow(side_length, 2) + return side_length ** 2 -def area_triangle(base, height): +def area_triangle(base: float, height: float) -> float: """ Calculate the area of a triangle @@ -61,7 +61,7 @@ def area_triangle(base, height): return (base * height) / 2 -def area_parallelogram(base, height): +def area_parallelogram(base: float, height: float) -> float: """ Calculate the area of a parallelogram @@ -71,7 +71,7 @@ def area_parallelogram(base, height): return base * height -def area_trapezium(base1, base2, height): +def area_trapezium(base1: float, base2: float, height: float) -> float: """ Calculate the area of a trapezium @@ -81,14 +81,14 @@ def area_trapezium(base1, base2, height): return 1 / 2 * (base1 + base2) * height -def area_circle(radius): +def area_circle(radius: float) -> float: """ Calculate the area of a circle >>> area_circle(20) 1256.6370614359173 """ - return pi * pow(radius, 2) + return pi * radius ** 2 def main(): From 1adda537fdc6b24caba36692ffd69b616572db77 Mon Sep 17 00:00:00 2001 From: lance-pyles Date: Fri, 24 Jul 2020 12:29:18 -0700 Subject: [PATCH 2/2] remove unused import --- maths/area.py | 1 - 1 file changed, 1 deletion(-) diff --git a/maths/area.py b/maths/area.py index c154fc233baa..3a0fd97396e4 100644 --- a/maths/area.py +++ b/maths/area.py @@ -2,7 +2,6 @@ Find the area of various geometric shapes """ from math import pi -from typing import Union def surface_area_cube(side_length: float) -> float: