Fix n-queens problem #12583
Merged
Fix n-queens problem #12583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
algorithms-keeper
bot
added
tests are failing
anandfresh
approved these changes
Feb 20, 2025
rahmani3101
approved these changes
Feb 20, 2025
algorithms-keeper
bot
added
awaiting reviews
MaximSmolskiy
approved these changes
Feb 20, 2025
algorithms-keeper
bot
removed
the
awaiting reviews
|
@cclauss Can we do something about this? |
algorithms-keeper
bot
removed
the
tests are failing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your change:
Fix wrong solution for n-queens problem which in backtrace folder.
Details
There is an issue about n_queens.py. If I run this script, it will print the wrong result which is different with n_queens_math.py. I think it's enough to check left upper diagonal, right upper diagonal and the same column here. Here are the last few lines of the correct output with my changes: