Add Fibonacci Heap implementation #11863
Conversation
- Implemented `FibonacciHeap` with core operations: `insert`, `extract_min`, `decrease_key`, and `delete`. - Added `Node` class for heap node structure. - Optimized for amortized time complexity with O(1) inserts and O(log n) extract min. - Included example usage and basic documentation.
algorithms-keeper
bot
added
require tests
![algorithms-keeper[bot]](https://avatars.githubusercontent.com/in/235834?s=60&v=4){kind=small}
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
| @@ -0,0 +1,173 @@ | |||
| class Node: | |||
| def __init__(self, key): | |||
There was a problem hiding this comment.
Please provide return type hint for the function: __init__. If the function does not return a value, please provide the type hint as: def function() -> None:
Please provide type hint for the parameter: key
| self.prev = self # Pointer to the previous node in the circular list | ||
|
|
||
| class FibonacciHeap: | ||
| def __init__(self): |
There was a problem hiding this comment.
Please provide return type hint for the function: __init__. If the function does not return a value, please provide the type hint as: def function() -> None:
| self.min_node = None # Pointer to the minimum node | ||
| self.num_nodes = 0 # Number of nodes in the heap | ||
|
|
||
| def insert(self, key): |
There was a problem hiding this comment.
Please provide return type hint for the function: insert. If the function does not return a value, please provide the type hint as: def function() -> None:
As there is no test file in this pull request nor any test function or class in the file data_structures/heap/fibonacci_heap.py, please provide doctest for the function insert
Please provide type hint for the parameter: key
| self.min_node = new_node | ||
| self.num_nodes += 1 | ||
|
|
||
| def _insert_to_root_list(self, node): |
There was a problem hiding this comment.
Please provide return type hint for the function: _insert_to_root_list. If the function does not return a value, please provide the type hint as: def function() -> None:
As there is no test file in this pull request nor any test function or class in the file data_structures/heap/fibonacci_heap.py, please provide doctest for the function _insert_to_root_list
Please provide type hint for the parameter: node
| self.min_node.prev.next = node | ||
| self.min_node.prev = node | ||
|
|
||
| def extract_min(self): |
There was a problem hiding this comment.
Please provide return type hint for the function: extract_min. If the function does not return a value, please provide the type hint as: def function() -> None:
As there is no test file in this pull request nor any test function or class in the file data_structures/heap/fibonacci_heap.py, please provide doctest for the function extract_min
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
| return min_node.key | ||
| return None | ||
|
|
||
| def _consolidate(self) -> None: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file data_structures/heap/fibonacci_heap.py, please provide doctest for the function _consolidate
| if self.min_node is None or node.key < self.min_node.key: | ||
| self.min_node = node | ||
|
|
||
| def _link(self, node1: Node, node2: Node) -> None: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file data_structures/heap/fibonacci_heap.py, please provide doctest for the function _link
| if node.key < self.min_node.key: | ||
| self.min_node = node | ||
|
|
||
| def _cut(self, node: Node, parent: Node) -> None: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file data_structures/heap/fibonacci_heap.py, please provide doctest for the function _cut
| node.parent = None | ||
| node.is_marked = False | ||
|
|
||
| def delete(self, node): |
There was a problem hiding this comment.
Please provide return type hint for the function: delete. If the function does not return a value, please provide the type hint as: def function() -> None:
As there is no test file in this pull request nor any test function or class in the file data_structures/heap/fibonacci_heap.py, please provide doctest for the function delete
Please provide type hint for the parameter: node
| self.decrease_key(node, float('-inf')) # Decrease the key to -infinity | ||
| self.extract_min() # Extract the minimum node | ||
|
|
||
| def is_empty(self): |
There was a problem hiding this comment.
Please provide return type hint for the function: is_empty. If the function does not return a value, please provide the type hint as: def function() -> None:
As there is no test file in this pull request nor any test function or class in the file data_structures/heap/fibonacci_heap.py, please provide doctest for the function is_empty
for more information, see https://pre-commit.ci
Here's a structured format for your pull request, incorporating your details along with placeholders for the checklist and description. You can copy and paste this directly into your PR:
Title
Implement Fibonacci Heap with Core Operations
Description
This pull request implements the
FibonacciHeapdata structure in Python, featuring core operations such asinsert,extract_min,decrease_key, anddelete. The implementation includes aNodeclass to represent each heap node and optimizes for amortized time complexity, providing efficient operations crucial for algorithms like Dijkstra's.FibonacciHeapwith core operations:insert,extract_min,decrease_key, anddelete.Nodeclass for heap node structure.Describe your change:
Checklist:
Feel free to check or uncheck items in the checklist according to the current status of your pull request. If you have an issue number, you can also add it to the description section as "Fixes #". Let me know if you need any more adjustments!