weddle's integration rule #11773

Soham-KT · 2024-10-05T13:11:04Z

Describe your change:

Add an algorithm?
Fix a bug or typo in an existing algorithm?
Add or change doctests? -- Note: Please avoid changing both code and tests in a single pull request.
Documentation change?

Checklist:

for more information, see https://pre-commit.ci

algorithms-keeper

Click here to look at the relevant links ⬇️

🔗 Relevant Links

Repository:

Contributing guidelines

Project Euler solution guidelines

Python:

Formatted string literals (f-strings)

Type hints

doctest

unittest

pytest

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.

algorithms-keeper commands and options

algorithms-keeper actions can be triggered by commenting on this PR:

@algorithms-keeper review to trigger the checks for only added pull request files

@algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.

NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.

algorithms-keeper · 2024-10-06T05:06:20Z

maths/weddles_rule.py

+from math import *
+
+
+def get_inputs():


Please provide return type hint for the function: get_inputs. If the function does not return a value, please provide the type hint as: def function() -> None:

algorithms-keeper · 2024-10-06T05:06:20Z

maths/weddles_rule.py

+    return func, a, b
+
+
+def compute_table(func, a, b, acc):


Please provide return type hint for the function: compute_table. If the function does not return a value, please provide the type hint as: def function() -> None:

Please provide type hint for the parameter: func

Please provide type hint for the parameter: a

Please provide descriptive name for the parameter: a

Please provide type hint for the parameter: b

Please provide descriptive name for the parameter: b

Please provide type hint for the parameter: acc

algorithms-keeper · 2024-10-06T05:06:20Z

maths/weddles_rule.py

+    return table, h
+
+
+def apply_weights(table):


Please provide return type hint for the function: apply_weights. If the function does not return a value, please provide the type hint as: def function() -> None:

Please provide type hint for the parameter: table

algorithms-keeper · 2024-10-06T05:06:20Z

maths/weddles_rule.py

+    return add
+
+
+def compute_solution(add, table, h):


Please provide return type hint for the function: compute_solution. If the function does not return a value, please provide the type hint as: def function() -> None:

Please provide type hint for the parameter: add

Please provide type hint for the parameter: table

Please provide type hint for the parameter: h

Please provide descriptive name for the parameter: h

algorithms-keeper

Click here to look at the relevant links ⬇️

🔗 Relevant Links

Repository:

Contributing guidelines

Project Euler solution guidelines

Python:

Formatted string literals (f-strings)

Type hints

doctest

unittest

pytest

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.

algorithms-keeper commands and options

algorithms-keeper actions can be triggered by commenting on this PR:

@algorithms-keeper review to trigger the checks for only added pull request files

@algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.

NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.

algorithms-keeper · 2024-10-06T05:08:02Z

maths/weddles_rule.py

+from sympy import lambdify, symbols, sympify
+
+
+def get_inputs():


Please provide return type hint for the function: get_inputs. If the function does not return a value, please provide the type hint as: def function() -> None:

algorithms-keeper · 2024-10-06T05:08:02Z

maths/weddles_rule.py

+    return func, a, b
+
+
+def safe_function_eval(func_str):


Please provide return type hint for the function: safe_function_eval. If the function does not return a value, please provide the type hint as: def function() -> None:

As there is no test file in this pull request nor any test function or class in the file maths/weddles_rule.py, please provide doctest for the function safe_function_eval

Please provide type hint for the parameter: func_str

algorithms-keeper · 2024-10-06T05:08:03Z

maths/weddles_rule.py

+    return lambda_func
+
+
+def compute_table(func, a, b, acc):


Please provide return type hint for the function: compute_table. If the function does not return a value, please provide the type hint as: def function() -> None:

Please provide type hint for the parameter: func

Please provide type hint for the parameter: a

Please provide descriptive name for the parameter: a

Please provide type hint for the parameter: b

Please provide descriptive name for the parameter: b

Please provide type hint for the parameter: acc

algorithms-keeper · 2024-10-06T05:08:03Z

maths/weddles_rule.py

+    return table, h
+
+
+def apply_weights(table):


Please provide return type hint for the function: apply_weights. If the function does not return a value, please provide the type hint as: def function() -> None:

Please provide type hint for the parameter: table

algorithms-keeper · 2024-10-06T05:08:03Z

maths/weddles_rule.py

+    return add
+
+
+def compute_solution(add, table, h):


Please provide return type hint for the function: compute_solution. If the function does not return a value, please provide the type hint as: def function() -> None:

Please provide type hint for the parameter: add

Please provide type hint for the parameter: table

Please provide type hint for the parameter: h

Please provide descriptive name for the parameter: h

for more information, see https://pre-commit.ci

algorithms-keeper

Click here to look at the relevant links ⬇️

🔗 Relevant Links

Repository:

Contributing guidelines

Project Euler solution guidelines

Python:

Formatted string literals (f-strings)

Type hints

doctest

unittest

pytest

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.

algorithms-keeper commands and options

algorithms-keeper actions can be triggered by commenting on this PR:

@algorithms-keeper review to trigger the checks for only added pull request files

@algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.

NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.

algorithms-keeper · 2024-10-06T06:07:17Z

maths/weddles_rule.py

+    return func, a, b
+
+
+def safe_function_eval(func_str) -> float:


As there is no test file in this pull request nor any test function or class in the file maths/weddles_rule.py, please provide doctest for the function safe_function_eval

Please provide type hint for the parameter: func_str

algorithms-keeper · 2024-10-06T06:07:17Z

maths/weddles_rule.py

+    return lambda_func
+
+
+def compute_table(func, a, b, acc) -> tuple:


Please provide type hint for the parameter: func

Please provide type hint for the parameter: a

Please provide descriptive name for the parameter: a

Please provide type hint for the parameter: b

Please provide descriptive name for the parameter: b

Please provide type hint for the parameter: acc

algorithms-keeper · 2024-10-06T06:07:17Z

maths/weddles_rule.py

+    return table, h
+
+
+def apply_weights(table) -> list:


Please provide type hint for the parameter: table

algorithms-keeper · 2024-10-06T06:07:17Z

maths/weddles_rule.py

+    return add
+
+
+def compute_solution(add, table, h) -> float:


Please provide type hint for the parameter: add

Please provide type hint for the parameter: table

Please provide type hint for the parameter: h

Please provide descriptive name for the parameter: h

for more information, see https://pre-commit.ci

algorithms-keeper

Click here to look at the relevant links ⬇️

🔗 Relevant Links

Repository:

Contributing guidelines

Project Euler solution guidelines

Python:

Formatted string literals (f-strings)

Type hints

doctest

unittest

pytest

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.

algorithms-keeper commands and options

algorithms-keeper actions can be triggered by commenting on this PR:

@algorithms-keeper review to trigger the checks for only added pull request files

@algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.

NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.

algorithms-keeper · 2024-10-06T06:15:07Z

maths/weddles_rule.py

+    return lambda_func
+
+
+def compute_table(func: str, a: float, b: float, acc: int) -> tuple:


Please provide descriptive name for the parameter: a

Please provide descriptive name for the parameter: b

algorithms-keeper · 2024-10-06T06:15:07Z

maths/weddles_rule.py

+    return add
+
+
+def compute_solution(add: list, table: list, h: float) -> float:


Please provide descriptive name for the parameter: h

for more information, see https://pre-commit.ci

…ction implementations and variable names.

for more information, see https://pre-commit.ci

Soham-KT · 2024-10-07T13:46:12Z

please review these changes and submit feedback if any.

Soham-KT and others added 2 commits October 5, 2024 18:38

weddle's integration rule

1ad1ed3

[pre-commit.ci] auto fixes from pre-commit.com hooks

8a4638e

for more information, see https://pre-commit.ci

algorithms-keeper bot added the tests are failing Do not merge until tests pass label Oct 5, 2024

Merge branch 'TheAlgorithms:master' into master

48ca80f

algorithms-keeper bot added require descriptive names This PR needs descriptive function and/or variable names require type hints https://docs.python.org/3/library/typing.html labels Oct 6, 2024

algorithms-keeper bot reviewed Oct 6, 2024

View reviewed changes

algorithms-keeper bot added the awaiting reviews This PR is ready to be reviewed label Oct 6, 2024

checks passed

cc5911a

algorithms-keeper bot added the require tests Tests [doctest/unittest/pytest] are required label Oct 6, 2024

algorithms-keeper bot reviewed Oct 6, 2024

View reviewed changes

[pre-commit.ci] auto fixes from pre-commit.com hooks

162595b

for more information, see https://pre-commit.ci

algorithms-keeper bot removed the tests are failing Do not merge until tests pass label Oct 6, 2024

added return type hint

7ce066c

algorithms-keeper bot reviewed Oct 6, 2024

View reviewed changes

[pre-commit.ci] auto fixes from pre-commit.com hooks

410ab38

for more information, see https://pre-commit.ci

algorithms-keeper bot added tests are failing Do not merge until tests pass and removed tests are failing Do not merge until tests pass labels Oct 6, 2024

Added type hints to function parameters and return types

3df440b

algorithms-keeper bot removed require tests Tests [doctest/unittest/pytest] are required require type hints https://docs.python.org/3/library/typing.html labels Oct 6, 2024

algorithms-keeper bot reviewed Oct 6, 2024

View reviewed changes

[pre-commit.ci] auto fixes from pre-commit.com hooks

56a0526

for more information, see https://pre-commit.ci

algorithms-keeper bot added the tests are failing Do not merge until tests pass label Oct 6, 2024

added descriptive names

aa66c4b

algorithms-keeper bot removed the require descriptive names This PR needs descriptive function and/or variable names label Oct 6, 2024

Soham-KT and others added 4 commits October 6, 2024 13:50

safe eval used

d44d0a8

[pre-commit.ci] auto fixes from pre-commit.com hooks

b13ce58

for more information, see https://pre-commit.ci

changed parameter hint

4e29f54

[pre-commit.ci] auto fixes from pre-commit.com hooks

cb4e8dd

for more information, see https://pre-commit.ci

Soham-KT and others added 3 commits October 6, 2024 14:57

updated function signatures, type hints, and docstrings; modified fun…

2cdd70b

…ction implementations and variable names.

[pre-commit.ci] auto fixes from pre-commit.com hooks

10bdd07

for more information, see https://pre-commit.ci

changes made in doctest

da0a975

algorithms-keeper bot removed the tests are failing Do not merge until tests pass label Oct 6, 2024

		from sympy import lambdify, symbols, sympify


		def get_inputs():

		return lambda_func


		def compute_table(func, a, b, acc) -> tuple:

		return lambda_func


		def compute_table(func: str, a: float, b: float, acc: int) -> tuple:

		return add


		def compute_solution(add: list, table: list, h: float) -> float:

Uh oh!

weddle's integration rule #11773

Are you sure you want to change the base?

weddle's integration rule #11773

Uh oh!

Conversation

Soham-KT commented Oct 5, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Describe your change:

Checklist:

Uh oh!

algorithms-keeper bot left a comment

Choose a reason for hiding this comment

🔗 Relevant Links

Repository:

Python:

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.

algorithms-keeper actions can be triggered by commenting on this PR:

Uh oh!

algorithms-keeper bot Oct 6, 2024

Choose a reason for hiding this comment

Uh oh!

algorithms-keeper bot Oct 6, 2024

Choose a reason for hiding this comment

Uh oh!

algorithms-keeper bot Oct 6, 2024

Choose a reason for hiding this comment

Uh oh!

algorithms-keeper bot Oct 6, 2024

Choose a reason for hiding this comment

Uh oh!

algorithms-keeper bot left a comment

Choose a reason for hiding this comment

🔗 Relevant Links

Repository:

Python:

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.

algorithms-keeper actions can be triggered by commenting on this PR:

Uh oh!

algorithms-keeper bot Oct 6, 2024

Choose a reason for hiding this comment

Uh oh!

algorithms-keeper bot Oct 6, 2024

Choose a reason for hiding this comment

Uh oh!

algorithms-keeper bot Oct 6, 2024

Choose a reason for hiding this comment

Uh oh!

algorithms-keeper bot Oct 6, 2024

Choose a reason for hiding this comment

Uh oh!

algorithms-keeper bot Oct 6, 2024

Choose a reason for hiding this comment

Uh oh!

algorithms-keeper bot left a comment

Choose a reason for hiding this comment

🔗 Relevant Links

Repository:

Python:

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.

algorithms-keeper actions can be triggered by commenting on this PR:

Uh oh!

algorithms-keeper bot Oct 6, 2024

Choose a reason for hiding this comment

Uh oh!

algorithms-keeper bot Oct 6, 2024

Choose a reason for hiding this comment

Uh oh!

algorithms-keeper bot Oct 6, 2024

Choose a reason for hiding this comment

Uh oh!

algorithms-keeper bot Oct 6, 2024

Choose a reason for hiding this comment

Uh oh!

algorithms-keeper bot left a comment

Choose a reason for hiding this comment

🔗 Relevant Links

Repository:

Python:

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.

Soham-KT commented Oct 5, 2024 •

edited

Loading