Skip to content

Add diagonal matrix traversal algorithm #11708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 5 commits into from
Closed

Add diagonal matrix traversal algorithm #11708

wants to merge 5 commits into from

Conversation

anubhav-qt
Copy link

@anubhav-qt anubhav-qt commented Oct 3, 2024 •
edited
Loading

Describe your change:

This PR adds an algorithm that prints the elements of a matrix in diagonal order.

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Add or change doctests? -- Note: Please avoid changing both code and tests in a single pull request.
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

@algorithms-keeper algorithms-keeper bot added the awaiting reviews This PR is ready to be reviewed label Oct 3, 2024
@algorithms-keeper algorithms-keeper bot added the tests are failing Do not merge until tests pass label Oct 3, 2024
@anubhav-qt
Copy link
Author

anubhav-qt commented Oct 3, 2024 •
edited
Loading

Two ruff tests were failing, I fixed one of them but the second one, saying to change else: if: to elif, I believe would degrade the quality of the code so I didn't change that for now. However, I am open to feedback on this decision.

@anubhav-qt
Copy link
Author

I just fixed all the ruff tests, but now during the build/ build (pull_request) test, it says ImportError. Can someone tell me what is the issue and how do I fix it?
I am new and I don't know how to proceed further :(

@cclauss
Copy link
Member

cclauss commented Oct 22, 2024

Closing tests_are_failing PRs to prepare for Hacktoberfest

@cclauss cclauss closed this Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
awaiting reviews This PR is ready to be reviewed tests are failing Do not merge until tests pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anubhav-qt @cclauss