Skip to content

Update simple_moving_average.py #11526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from
Closed

Conversation

incheonQ
Copy link

Add ValueError: Ensure window size is smaller than the total length of the time series

Describe your change:

  • Add an algorithm?
  • [✅] Fix a bug or typo in an existing algorithm?
  • Add or change doctests? -- Note: Please avoid changing both code and tests in a single pull request.
  • Documentation change?

Checklist:

  • [✅] I have read CONTRIBUTING.md.
  • [✅] This pull request is all my own work -- I have not plagiarized.
  • [✅] I know that pull requests will not be merged if they fail the automated tests.
  • [✅] This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • [✅] All new Python files are placed inside an existing directory.
  • [✅] All filenames are in all lowercase characters with no spaces or dashes.
  • [✅] All functions and variable names follow Python naming conventions.
  • [✅] All function parameters and return values are annotated with Python type hints.
  • [✅] All functions have doctests that pass the automated testing.
  • [✅] All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • [✅] If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

incheonQ and others added 2 commits August 25, 2024 14:38
Add ValueError: Ensure window size is smaller than the total length of the time series
@algorithms-keeper algorithms-keeper bot added the tests are failing Do not merge until tests pass label Aug 25, 2024
Changes have been applied.
@algorithms-keeper algorithms-keeper bot added the awaiting reviews This PR is ready to be reviewed label Aug 25, 2024
@incheonQ
Copy link
Author

I don't know what part I missed.
I made very minor changes, and it seems that the errors are still failing in lines I didn't modify.

@tianyizheng02
Copy link
Contributor

Sorry about that, we were having some issues with ruff. Please rebase your branch to update it with the most recent commits to the repo. The ruff errors should resolve themselves once you do.

@incheonQ incheonQ closed this Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting reviews This PR is ready to be reviewed tests are failing Do not merge until tests pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants