Skip to content

Add perfect cube binary search #10477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Oct 23, 2023
Merged

Add perfect cube binary search #10477

merged 7 commits into from
Oct 23, 2023

Conversation

CouldNot
Copy link
Contributor

Describe your change:

This pull request adds a new algorithm within the existing perfect_cube.py file, including a doctest. While similar files such as perfect_square.py have added an improved time complexity binary search algorithm, perfect_cube.py lacks another faster algorithm that can be used as an alternative. This PR aims to bring the set of algorithms up to standard (such as perfect_square.py) with a new binary search implementation.

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

tianyizheng02
tianyizheng02 requested changes Oct 16, 2023
View reviewed changes
Copy link
Contributor

@tianyizheng02 tianyizheng02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you modify your algorithm to support negative numbers? For instance, -27 = (-3)^3

@algorithms-keeper algorithms-keeper bot added the awaiting reviews This PR is ready to be reviewed label Oct 17, 2023
@CouldNot
Copy link
Contributor Author

Hi, thanks for the reply - I've made the changes, let me know if everything's OK now. To add support for negative perfect cubes to the other non binary search algorithm in the same file, I can open another PR.

@algorithms-keeper algorithms-keeper bot added the tests are failing Do not merge until tests pass label Oct 17, 2023
tianyizheng02
tianyizheng02 requested changes Oct 17, 2023
View reviewed changes
maths/perfect_cube.py Outdated
Comment on lines 26 to 29
>>> perfect_cube_binary_search("a")
Traceback (most recent call last):
...
TypeError: '<=' not supported between instances of 'int' and 'str'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add your own TypeError check for invalid inputs like this rather than relying on the built-in error message for <=

@CouldNot
Copy link
Contributor Author

A TypeError check was added, thanks for the reply.

@tianyizheng02
Copy link
Contributor 

=========================== short test summary info ============================
FAILED web_programming/fetch_anime_and_play.py::web_programming.fetch_anime_and_play.search_anime_episode_list
============= 1 failed, 1669 passed, 1 warning in 95.85s (0:01:35) =============

Ugh, not this file again...

@algorithms-keeper algorithms-keeper bot removed the tests are failing Do not merge until tests pass label Oct 23, 2023
@tianyizheng02 tianyizheng02 merged commit a9cee1d into TheAlgorithms:master Oct 23, 2023
@algorithms-keeper algorithms-keeper bot removed the awaiting reviews This PR is ready to be reviewed label Oct 23, 2023
@tianyizheng02
Copy link
Contributor

Thanks for your contribution!

sedatguzelsemme pushed a commit to sedatguzelsemme/Python that referenced this pull request Sep 15, 2024
@CouldNot @pre-commit-ci @sedatguzelsemme
Add perfect cube binary search (TheAlgorithms#10477)
f7c4618 
* Add perfect cube binary search algorithm

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Add support for testing negative perfect cubes

* Add TypeError check for invalid inputs

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
@isidroas isidroas mentioned this pull request Jan 25, 2025
Closed
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tianyizheng02 tianyizheng02 tianyizheng02 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CouldNot @tianyizheng02