Skip to content

[Add] : Minimum coins program by using GREEDY #10360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 6 commits into from
Closed

[Add] : Minimum coins program by using GREEDY #10360

wants to merge 6 commits into from

Conversation

kosuri-indu
Copy link
Contributor

Describe your change:

This PR adds the Minimum coins program under greedy_methods

Indian coins program - Under GREEDY METHODS

Screenshot 2023-08-02 185441

Screenshot 2023-08-02 185443

Screenshot 2023-08-02 185442

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

@algorithms-keeper algorithms-keeper bot added awaiting reviews This PR is ready to be reviewed tests are failing Do not merge until tests pass labels Oct 13, 2023
@algorithms-keeper algorithms-keeper bot removed the tests are failing Do not merge until tests pass label Oct 13, 2023
@kosuri-indu
Copy link
Contributor Author

Hi @cclauss , How are you doing?
Could you review this PR and suggest any changes ?

@tianyizheng02
Copy link
Contributor

Sorry, but we already have an implementation of this greedy algorithm: maths/greedy_coin_change.py

Yes, I'm aware that this is in the maths/ directory and not the greedy_methods/ directory, so I completely understand if you didn't notice this existing implementation. We definitely need to move that file into the correct directory at some point.

@tianyizheng02 tianyizheng02 mentioned this pull request Oct 14, 2023
Merged
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
awaiting reviews This PR is ready to be reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kosuri-indu @tianyizheng02