carmichael_number - add doctests #10038
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…decomposition." This reverts commit ad217c6.
algorithms-keeper
bot
added
enhancement
for more information, see https://pre-commit.ci
I make an empty commit to reset: tests are failing.
for more information, see https://pre-commit.ci
14 tasks
Made changes taking into account the addition: from maths.greatest_common_divisor import greatest_common_divisor. Now instead of gcd it is used: greatest_common_divisor.
algorithms-keeper
bot
added
the
merge conflicts
algorithms-keeper
bot
removed
the
merge conflicts
14 tasks
tianyizheng02
requested changes
Oct 9, 2023
I added a check for 0 and negative numbers in the tests and the code itself. Simplified obtaining the final result.
algorithms-keeper
bot
added
the
merge conflicts
|
@tianyizheng02 again a merge conflict will occur. If you need to re-open a pull request, let me know. |
tianyizheng02
requested changes
Oct 10, 2023
algorithms-keeper
bot
removed
the
merge conflicts
for more information, see https://pre-commit.ci
Co-authored-by: Tianyi Zheng <[email protected]>
algorithms-keeper
bot
removed
the
tests are failing
tianyizheng02
approved these changes
Oct 10, 2023
algorithms-keeper
bot
removed
the
awaiting reviews
sedatguzelsemme
pushed a commit
to sedatguzelsemme/Python
that referenced
this pull request
Sep 15, 2024
* Replacing the generator with numpy vector operations from lu_decomposition. * Revert "Replacing the generator with numpy vector operations from lu_decomposition." This reverts commit ad217c6. * Added doctests * Update carmichael_number.py * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Update carmichael_number.py I make an empty commit to reset: tests are failing. * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Update carmichael_number.py Made changes taking into account the addition: from maths.greatest_common_divisor import greatest_common_divisor. Now instead of gcd it is used: greatest_common_divisor. * Update carmichael_number.py * Update carmichael_number.py * Update carmichael_number.py I added a check for 0 and negative numbers in the tests and the code itself. Simplified obtaining the final result. * Update carmichael_number.py * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Update maths/carmichael_number.py Co-authored-by: Tianyi Zheng <[email protected]> * Update carmichael_number.py * Update carmichael_number.py --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Tianyi Zheng <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your change:
Contributes to #9943
Added doctests.
Checklist: