Skip to content

Suggestion: Why not refactor the source codes using Numpy? #9029

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
CHRIBUR0309 opened this issue Sep 3, 2023 · 6 comments
Closed

Suggestion: Why not refactor the source codes using Numpy? #9029

CHRIBUR0309 opened this issue Sep 3, 2023 · 6 comments
Labels
enhancement This PR modified some existing files

Comments

@CHRIBUR0309
Copy link

Feature description

I saw just several source codes here and I found you can refactor some of them using Numpy. I think you should put the codes of both: pure Python and Numpy-refactored.

@CHRIBUR0309 CHRIBUR0309 added the enhancement This PR modified some existing files label Sep 3, 2023
@rohan472000
Copy link
Contributor

Can you point out exactly which code are you talking about?

@quant12345
Copy link
Contributor

@CHRIBUR0309 @rohan472000

My code does refactor and optimization. And I also think that solutions should be left in pure Python, since Numpy is less visually understandable and perhaps someone will want to apply numba to the code and it will not work with all the functions of Numpy.

Need both options: pure Python (slow) and Numpy (fast).

I basically did this in my pull request. And I can do more. But so far there is no movement on it, so enthusiasm is drying up.

@rohan472000
Copy link
Contributor

@quant12345 give me the PR no. or link of it..

@quant12345
Copy link
Contributor

quant12345 commented Sep 8, 2023

@quant12345 give me the PR no. or link of it..

#8938

more tests on this code here:

#9012

@rohan472000
Copy link
Contributor

Close it as #8938 is merged.

@cclauss
Copy link
Member

cclauss commented Oct 15, 2023

CONTRIBUTING.md says:

Do not create an issue to contribute an algorithm. Please submit a pull request instead.

@cclauss cclauss closed this as completed Oct 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement This PR modified some existing files
Projects
None yet
Development

No branches or pull requests

5 participants
@cclauss @quant12345 @CHRIBUR0309 @rohan472000 and others