-
-
Notifications
You must be signed in to change notification settings - Fork 46.6k
Suggestion: Why not refactor the source codes using Numpy? #9029
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Can you point out exactly which code are you talking about? |
My code does refactor and optimization. And I also think that solutions should be left in pure Python, since Numpy is less visually understandable and perhaps someone will want to apply numba to the code and it will not work with all the functions of Numpy. Need both options: pure Python (slow) and Numpy (fast). I basically did this in my pull request. And I can do more. But so far there is no movement on it, so enthusiasm is drying up. |
@quant12345 give me the PR no. or link of it.. |
more tests on this code here: |
Close it as #8938 is merged. |
|
Feature description
I saw just several source codes here and I found you can refactor some of them using Numpy. I think you should put the codes of both: pure Python and Numpy-refactored.
The text was updated successfully, but these errors were encountered: