Skip to content

Adding MFCC Audio Signal Feature Extraction Algorithm #9026

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
AmirLavasani opened this issue Sep 2, 2023 · 5 comments · Fixed by #9057
Closed

Adding MFCC Audio Signal Feature Extraction Algorithm #9026

AmirLavasani opened this issue Sep 2, 2023 · 5 comments · Fixed by #9057
Labels
enhancement This PR modified some existing files

Comments

@AmirLavasani
Copy link
Contributor

Feature description

Issue Title:
Adding MFCC Audio Signal Feature Extraction Algorithm

Issue Description:
I am planning to contribute to this repository by implementing the MFCC (Mel Frequency Cepstral Coefficients) audio signal feature extraction algorithm. MFCC is widely used in various applications, including speech recognition and audio analysis.

Proposed Location:
I would like to propose adding a new category or subcategory for signal processing or feature extraction. Specifically, I suggest:

  • Creating a "Signal Processing" category if one does not exist, and placing the MFCC algorithm under it.
    OR
  • Creating a "Feature Extraction" subcategory under the "Machine Learning" section and placing MFCC under it.

Contributor Request:
I am opening this issue to let the community know about my intention to work on this algorithm. I also welcome suggestions and feedback from other contributors regarding the best location for this feature extraction algorithm and any considerations related to its implementation.

Looking forward to collaborating with the community to enhance this repository with the addition of the MFCC feature extraction algorithm.

@AmirLavasani AmirLavasani added the enhancement This PR modified some existing files label Sep 2, 2023
@rohan472000
Copy link
Contributor

rohan472000 commented Sep 7, 2023

check audio_filters folder of this repo.

@AmirLavasani
Copy link
Contributor Author

Thanks for your response. @rohan472000

I also checked the audio filter folder, but I didn't find an MFCC implementation there, so I will open a PR to add the MFCC Algorithm. MFCC is commonly categorized as a feature extraction algorithm in machine learning, rather than an audio filter. I'm open to community feedback, and if most agree, I'll add it to the audio filter category.

@rohan472000
Copy link
Contributor

Yep.. it would be better to put this into machine_learning folder.

@AmirLavasani
Copy link
Contributor Author

The automatic build keeps failing for other algorithm tests. Hey Rohan, What do you suggest I do? @rohan472000

Here is the error message:

=========================== short test summary info ============================
FAILED machine_learning/xgboost_regressor.py::machine_learning.xgboost_regressor.main
FAILED machine_learning/xgboost_regressor.py::machine_learning.xgboost_regressor.xgboost
============ 2 failed, 1473 passed, 16 warnings in 66.14s (0:01:06) ============
Error: Process completed with exit code 1.

@rohan472000
Copy link
Contributor

I'm working to fix that issue...will raise PR for it...after getting merged your PR's build will be successful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement This PR modified some existing files
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants