Skip to content

Replace yulewalker in audio_filtes/equal_loudness_filter #7724

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
CaedenPH opened this issue Oct 27, 2022 · 2 comments
Closed

Replace yulewalker in audio_filtes/equal_loudness_filter #7724

CaedenPH opened this issue Oct 27, 2022 · 2 comments
Labels
enhancement This PR modified some existing files

Comments

@CaedenPH
Copy link
Contributor

Feature description

https://pypi.org/project/yulewalker/ is no longer maintained it seems, which is logging a warning in the audio_filters/equal_loudness_filter.py.

Fixes: #7300

@CaedenPH CaedenPH added the enhancement This PR modified some existing files label Oct 27, 2022
@Sahil2315
Copy link

what needs to be done?

@CaedenPH
Copy link
Contributor Author

what needs to be done?

In this file
https://github.com/TheAlgorithms/Python/blob/master/audio_filters/equal_loudness_filter.py#L5
The module yulewalker is used. This module uses np.int which is deprecataed and raises warnings
Ideally, this module would be swithed out with a later, maintained package, or the code would be refactored in order to not use yulewalker

@cclauss cclauss closed this as completed Oct 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement This PR modified some existing files
Projects
None yet
Development

No branches or pull requests

3 participants