Skip to content

Subset generation shouldn't work entirely by printing #7502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tianyizheng02 opened this issue Oct 22, 2022 · 1 comment
Closed

Subset generation shouldn't work entirely by printing #7502

tianyizheng02 opened this issue Oct 22, 2022 · 1 comment
Labels
enhancement This PR modified some existing files

Comments

@tianyizheng02
Copy link
Contributor

Feature description

The subset generation algorithm in dynamic_programming/subset_generation.py works entirely by printing all possible subsets to console, which goes against the current contribution guidelines (see #7337 for more details). Ideally the algorithm should generate some data structure containing all of the subsets instead (list, set, generator, whatever), but that would require reworking parts of the algorithm rather than simply removing the print statements.

@tianyizheng02 tianyizheng02 added the enhancement This PR modified some existing files label Oct 22, 2022
@tianyizheng02 tianyizheng02 changed the title Subset generation algorithm shouldn't work entirely by printing Subset generation shouldn't work entirely by printing Oct 22, 2022
@cclauss
Copy link
Member

cclauss commented Oct 22, 2022

This looks OK to me.

@cclauss cclauss closed this as completed Oct 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement This PR modified some existing files
Projects
None yet
Development

No branches or pull requests

2 participants