Skip to content

Error in Algorithm #3953

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
maldz3 opened this issue Nov 25, 2020 · 5 comments
Closed

Error in Algorithm #3953

maldz3 opened this issue Nov 25, 2020 · 5 comments

Comments

@maldz3
Copy link
Contributor

maldz3 commented Nov 25, 2020

I found an error in one of the algorithms, fixed it, and tried to make a pull request. However I already have a previous pr open so I'm unable to make another one. Should i just wait, or close my earlier one?

Also I noticed your conversation about rejecting prs without doctests which makes sense. In this case, the error I've fixed is in a file that I think needs quite a few more changes, and it doesn't yet have doctests included. However, I wanted my first pr for this file to be just a simple fixing of the error. Adding doctests will unfortunately be a little more complicated since the original code writer added a lot of print statements within the functions.

@amaank404
Copy link
Contributor

Make a branch of your fork, update your new branch from this repo, make changes, create PR from that branch

@maldz3
Copy link
Contributor Author

maldz3 commented Nov 30, 2020

I'm pretty sure that's what I did. I created a separate branch for the second pull request, but it seems that users are only allowed to have one open pull request. This is my open pr:
#3874
This is my second pr that was automatically closed:
#3952

@amaank404
Copy link
Contributor

You can reopen your second PR after your first work is done, please wait until then.

@maldz3
Copy link
Contributor Author

maldz3 commented Dec 1, 2020

Thanks will do!

@cclauss
Copy link
Member

cclauss commented Dec 6, 2020

Closed in #3874

@cclauss cclauss closed this as completed Dec 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants