-
-
Notifications
You must be signed in to change notification settings - Fork 46.6k
Error in Algorithm #3953
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Make a branch of your fork, update your new branch from this repo, make changes, create PR from that branch |
You can reopen your second PR after your first work is done, please wait until then. |
Thanks will do! |
Closed in #3874 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I found an error in one of the algorithms, fixed it, and tried to make a pull request. However I already have a previous pr open so I'm unable to make another one. Should i just wait, or close my earlier one?
Also I noticed your conversation about rejecting prs without doctests which makes sense. In this case, the error I've fixed is in a file that I think needs quite a few more changes, and it doesn't yet have doctests included. However, I wanted my first pr for this file to be just a simple fixing of the error. Adding doctests will unfortunately be a little more complicated since the original code writer added a lot of print statements within the functions.
The text was updated successfully, but these errors were encountered: