Skip to content

PR is not getting merged #10625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ojas-wani opened this issue Oct 16, 2023 · 3 comments
Closed

PR is not getting merged #10625

ojas-wani opened this issue Oct 16, 2023 · 3 comments
Labels
awaiting triage Awaiting triage from a maintainer

Comments

@ojas-wani
Copy link
Contributor

What would you like to share?

I opened a pull request last week. I passed all the tests but still, it is not merged. Can someone please review it and help me to get it merged? Also, If it needs any changes please suggest me.

#10045

Additional information

No response
@ojas-wani ojas-wani added the awaiting triage Awaiting triage from a maintainer label Oct 16, 2023
@PoojanSmart
Copy link
Contributor

Hi @ojas-wani,
I am not a maintainer. But just to point out that your PR is also removing an algorithm file. digital_image_processing/filters/laplacian_filter.py
I am not sure you meant to remove it.
Just letting you know.

@ojas-wani
Copy link
Contributor Author

I am also adding this file into different location.

@AasheeshLikePanner
Copy link
Contributor

Can you close this issue now. You pr got merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
awaiting triage Awaiting triage from a maintainer
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@PoojanSmart @ojas-wani @AasheeshLikePanner