Renamed the variables

Author: Hardvan

Diff for: greedy_methods/fractional_knapsack.py

@@ -9,10 +9,10 @@ def frac_knapsack(values: list[int], weights: list[int], capacity: int, max_item
     This function implements fractional knapsack problem.
 
     Args:
-        vl: List of values of items.
-        wt: List of weights of items.
-        w: Capacity of the knapsack.
-        n: Number of items.
+        values: List of values of items.
+        weights: List of weights of items.
+        capacity: Capacity of the knapsack.
+        max_items: Number of items.
 
     Returns:
         Maximum value of items that can be put into the knapsack.
@@ -46,17 +46,19 @@ def frac_knapsack(values: list[int], weights: list[int], capacity: int, max_item
     """
 
     # sort in descending order of value/weight ratio
-    r = sorted(zip(vl, wt), key=lambda x: x[0] / x[1], reverse=True, strict=True)
+    r = sorted(zip(values, weights),
+               key=lambda x: x[0] / x[1], reverse=True)
 
-    vl, wt = [i[0] for i in r], [i[1] for i in r]  # unzip the list
-    acc = list(accumulate(wt))  # cumulative sum of weights
-    k = bisect(acc, w)  # find the index of the weight just greater than w
+    values, weights = [i[0] for i in r], [i[1] for i in r]  # unzip the list
+    acc = list(accumulate(weights))  # cumulative sum of weights
+    # find the index of the weight just greater than capacity
+    k = bisect(acc, capacity)
 
     if k == 0:  # no item can be put into the knapsack
         return 0
-    elif k != n:  # fractional part of the kth item can be put into the knapsack
-        return sum(vl[:k]) + (w - acc[k - 1]) * (vl[k]) / (wt[k])
-    return sum(vl[:k])  # all items can be put into the knapsack
+    elif k != max_items:  # fractional part of the kth item can be put into the knapsack
+        return sum(values[:k]) + (capacity - acc[k - 1]) * (values[k]) / (weights[k])
+    return sum(values[:k])  # all items can be put into the knapsack
 
 
 if __name__ == "__main__":