Merge branch 'TheAlgorithms:master' into fix-mypy-errs-5

tianyizheng02 · web-flow · commit ce31aa1e6649 · 2023-03-26T11:50:21.000-04:00
diff --git a/.github/stale.yml b/.github/stale.yml
@@ -45,7 +45,7 @@ pulls:
   closeComment: >
     Please reopen this pull request once you commit the changes requested
     or make improvements on the code. If this is not the case and you need
-    some help, feel free to seek help from our [Gitter](https://gitter.im/TheAlgorithms)
+    some help, feel free to seek help from our [Gitter](https://app.gitter.im/#/room/#TheAlgorithms_community:gitter.im)
     or ping one of the reviewers. Thank you for your contributions!
 
 issues:
@@ -59,5 +59,5 @@ issues:
   closeComment: >
     Please reopen this issue once you add more information and updates here.
     If this is not the case and you need some help, feel free to seek help
-    from our [Gitter](https://gitter.im/TheAlgorithms) or ping one of the
+    from our [Gitter](https://app.gitter.im/#/room/#TheAlgorithms_community:gitter.im) or ping one of the
     reviewers. Thank you for your contributions!
diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml
@@ -16,7 +16,7 @@ repos:
     -   id: auto-walrus
 
   - repo: https://github.com/charliermarsh/ruff-pre-commit
-    rev: v0.0.257
+    rev: v0.0.259
     hooks:
       - id: ruff
 
diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
@@ -2,7 +2,7 @@
 
 ## Before contributing
 
-Welcome to [TheAlgorithms/Python](https://github.com/TheAlgorithms/Python)! Before sending your pull requests, make sure that you __read the whole guidelines__. If you have any doubt on the contributing guide, please feel free to [state it clearly in an issue](https://github.com/TheAlgorithms/Python/issues/new) or ask the community in [Gitter](https://gitter.im/TheAlgorithms).
+Welcome to [TheAlgorithms/Python](https://github.com/TheAlgorithms/Python)! Before sending your pull requests, make sure that you __read the whole guidelines__. If you have any doubt on the contributing guide, please feel free to [state it clearly in an issue](https://github.com/TheAlgorithms/Python/issues/new) or ask the community in [Gitter](https://app.gitter.im/#/room/#TheAlgorithms_community:gitter.im).
 
 ## Contributing
 
@@ -176,7 +176,7 @@ We want your work to be readable by others; therefore, we encourage you to note
 
 - Most importantly,
   - __Be consistent in the use of these guidelines when submitting.__
-  - __Join__ us on [Discord](https://discord.com/invite/c7MnfGFGa6) and [Gitter](https://gitter.im/TheAlgorithms) __now!__
+  - __Join__ us on [Discord](https://discord.com/invite/c7MnfGFGa6) and [Gitter](https://app.gitter.im/#/room/#TheAlgorithms_community:gitter.im) __now!__
   - Happy coding!
 
 Writer [@poyea](https://github.com/poyea), Jun 2019.
diff --git a/README.md b/README.md
@@ -16,7 +16,7 @@
   <a href="https://discord.gg/c7MnfGFGa6">
     <img src="https://img.shields.io/discord/808045925556682782.svg?logo=discord&colorB=7289DA&style=flat-square" height="20" alt="Discord chat">
   </a>
-  <a href="https://gitter.im/TheAlgorithms">
+  <a href="https://app.gitter.im/#/room/#TheAlgorithms_community:gitter.im">
     <img src="https://img.shields.io/badge/Chat-Gitter-ff69b4.svg?label=Chat&logo=gitter&style=flat-square" height="20" alt="Gitter chat">
   </a>
   <!-- Second row: -->
@@ -42,7 +42,7 @@ Read through our [Contribution Guidelines](CONTRIBUTING.md) before you contribut
 
 ## Community Channels
 
-We are on [Discord](https://discord.gg/c7MnfGFGa6) and [Gitter](https://gitter.im/TheAlgorithms)! Community channels are a great way for you to ask questions and get help. Please join us!
+We are on [Discord](https://discord.gg/c7MnfGFGa6) and [Gitter](https://app.gitter.im/#/room/#TheAlgorithms_community:gitter.im)! Community channels are a great way for you to ask questions and get help. Please join us!
 
 ## List of Algorithms
 
diff --git a/hashes/sha1.py b/hashes/sha1.py
@@ -124,7 +124,7 @@ def final_hash(self):
                 self.h[3] + d & 0xFFFFFFFF,
                 self.h[4] + e & 0xFFFFFFFF,
             )
-        return "%08x%08x%08x%08x%08x" % tuple(self.h)
+        return ("{:08x}" * 5).format(*self.h)
 
 
 def test_sha1_hash():
diff --git a/machine_learning/sequential_minimum_optimization.py b/machine_learning/sequential_minimum_optimization.py
@@ -458,7 +458,7 @@ def test_cancel_data():
             CANCER_DATASET_URL,
             headers={"User-Agent": "Mozilla/4.0 (compatible; MSIE 5.5; Windows NT)"},
         )
-        response = urllib.request.urlopen(request)
+        response = urllib.request.urlopen(request)  # noqa: S310
         content = response.read().decode("utf-8")
         with open(r"cancel_data.csv", "w") as f:
             f.write(content)
diff --git a/neural_network/convolution_neural_network.py b/neural_network/convolution_neural_network.py
@@ -77,7 +77,7 @@ def save_model(self, save_path):
     def read_model(cls, model_path):
         # read saved model
         with open(model_path, "rb") as f:
-            model_dic = pickle.load(f)
+            model_dic = pickle.load(f)  # noqa: S301
 
         conv_get = model_dic.get("conv1")
         conv_get.append(model_dic.get("step_conv1"))
diff --git a/project_euler/README.md b/project_euler/README.md
@@ -10,7 +10,7 @@ The solutions will be checked by our [automated testing on GitHub Actions](https
 
 ## Solution Guidelines
 
-Welcome to [TheAlgorithms/Python](https://github.com/TheAlgorithms/Python)! Before reading the solution guidelines, make sure you read the whole [Contributing Guidelines](https://github.com/TheAlgorithms/Python/blob/master/CONTRIBUTING.md) as it won't be repeated in here. If you have any doubt on the guidelines, please feel free to [state it clearly in an issue](https://github.com/TheAlgorithms/Python/issues/new) or ask the community in [Gitter](https://gitter.im/TheAlgorithms). You can use the [template](https://github.com/TheAlgorithms/Python/blob/master/project_euler/README.md#solution-template) we have provided below as your starting point but be sure to read the [Coding Style](https://github.com/TheAlgorithms/Python/blob/master/project_euler/README.md#coding-style) part first.
+Welcome to [TheAlgorithms/Python](https://github.com/TheAlgorithms/Python)! Before reading the solution guidelines, make sure you read the whole [Contributing Guidelines](https://github.com/TheAlgorithms/Python/blob/master/CONTRIBUTING.md) as it won't be repeated in here. If you have any doubt on the guidelines, please feel free to [state it clearly in an issue](https://github.com/TheAlgorithms/Python/issues/new) or ask the community in [Gitter](https://app.gitter.im/#/room/#TheAlgorithms_community:gitter.im). You can use the [template](https://github.com/TheAlgorithms/Python/blob/master/project_euler/README.md#solution-template) we have provided below as your starting point but be sure to read the [Coding Style](https://github.com/TheAlgorithms/Python/blob/master/project_euler/README.md#coding-style) part first.
 
 ### Coding Style
 
diff --git a/pyproject.toml b/pyproject.toml
@@ -34,6 +34,7 @@ ignore = [      # `ruff rule S101` for a description of that rule
     "S101",     # S101: Use of `assert` detected -- DO NOT FIX
     "S105",     # S105: Possible hardcoded password: 'password'
     "S113",     # S113: Probable use of requests call without timeout
+    "S311",     # S311: Standard pseudo-random generators are not suitable for cryptographic purposes
     "UP038",    # UP038: Use `X | Y` in `{}` call instead of `(X, Y)` -- DO NOT FIX
 ]
 select = [      # https://beta.ruff.rs/docs/rules
diff --git a/web_programming/download_images_from_google_query.py b/web_programming/download_images_from_google_query.py
@@ -86,7 +86,7 @@ def download_images_from_google_query(query: str = "dhaka", max_images: int = 5)
         path_name = f"query_{query.replace(' ', '_')}"
         if not os.path.exists(path_name):
             os.makedirs(path_name)
-        urllib.request.urlretrieve(
+        urllib.request.urlretrieve(  # noqa: S310
             original_size_img, f"{path_name}/original_size_img_{index}.jpg"
         )
     return index

Original file line number	Diff line number	Diff line change
`@@ -124,7 +124,7 @@ def final_hash(self):`
`124`	`124`	`self.h[3] + d & 0xFFFFFFFF,`
`125`	`125`	`self.h[4] + e & 0xFFFFFFFF,`
`126`	`126`	`)`
`127`		`- return "%08x%08x%08x%08x%08x" % tuple(self.h)`
	`127`	`+ return ("{:08x}" * 5).format(*self.h)`
`128`	`128`
`129`	`129`
`130`	`130`	`def test_sha1_hash():`
Original file line number	Diff line number	Diff line change
`@@ -458,7 +458,7 @@ def test_cancel_data():`
`458`	`458`	`CANCER_DATASET_URL,`
`459`	`459`	`headers={"User-Agent": "Mozilla/4.0 (compatible; MSIE 5.5; Windows NT)"},`
`460`	`460`	`)`
`461`		`- response = urllib.request.urlopen(request)`
	`461`	`+ response = urllib.request.urlopen(request) # noqa: S310`
`462`	`462`	`content = response.read().decode("utf-8")`
`463`	`463`	`with open(r"cancel_data.csv", "w") as f:`
`464`	`464`	`f.write(content)`
Original file line number	Diff line number	Diff line change
@@ -34,6 +34,7 @@ ignore = [ # `ruff rule S101` for a description of that rule
`34`	`34`	"S101", # S101: Use of `assert` detected -- DO NOT FIX
`35`	`35`	`"S105", # S105: Possible hardcoded password: 'password'`
`36`	`36`	`"S113", # S113: Probable use of requests call without timeout`
	`37`	`+ "S311", # S311: Standard pseudo-random generators are not suitable for cryptographic purposes`
`37`	`38`	"UP038", # UP038: Use `X \| Y` in `{}` call instead of `(X, Y)` -- DO NOT FIX
`38`	`39`	`]`
`39`	`40`	`select = [ # https://beta.ruff.rs/docs/rules`
Original file line number	Diff line number	Diff line change
`@@ -86,7 +86,7 @@ def download_images_from_google_query(query: str = "dhaka", max_images: int = 5)`
`86`	`86`	`path_name = f"query_{query.replace(' ', '_')}"`
`87`	`87`	`if not os.path.exists(path_name):`
`88`	`88`	`os.makedirs(path_name)`
`89`		`- urllib.request.urlretrieve(`
	`89`	`+ urllib.request.urlretrieve( # noqa: S310`
`90`	`90`	`original_size_img, f"{path_name}/original_size_img_{index}.jpg"`
`91`	`91`	`)`
`92`	`92`	`return index`