Skip to content

Commit afd4d46

Browse files
authored
changed error details
1 parent d03beff commit afd4d46

File tree

1 file changed

+14
-13
lines changed

1 file changed

+14
-13
lines changed

maths/maclaurin_sin.py

Lines changed: 14 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -23,36 +23,37 @@ def maclaurin_sin(theta: float, accuracy: int = 30) -> float:
2323
>>> maclaurin_sin("10")
2424
Traceback (most recent call last):
2525
...
26-
ValueError: maclaurin_sin() requires int/float for theta and +ive int for accuracy
26+
ValueError: maclaurin_sin() requires a int or float for theta
2727
>>> maclaurin_sin(10, -30)
2828
Traceback (most recent call last):
2929
...
30-
ValueError: maclaurin_sin() requires int/float for theta and +ive int for accuracy
30+
ValueError: maclaurin_sin() requires a positive int for accuracy
3131
>>> maclaurin_sin(10, 30.5)
3232
Traceback (most recent call last):
3333
...
34-
ValueError: maclaurin_sin() requires int/float for theta and +ive int for accuracy
34+
ValueError: maclaurin_sin() requires a positive int for accuracy
3535
>>> maclaurin_sin(10, "30")
3636
Traceback (most recent call last):
3737
...
38-
ValueError: maclaurin_sin() requires int/float for theta and +ive int for accuracy
38+
ValueError: maclaurin_sin() requires a positive int for accuracy
3939
"""
4040

41-
if (
42-
not isinstance(accuracy, int)
43-
or accuracy <= 0
44-
or not isinstance(theta, (int, float))
45-
):
41+
if not isinstance(theta, (int, float)):
4642
raise ValueError(
47-
"maclaurin_sin() requires int/float for theta and +ive int for accuracy"
43+
"maclaurin_sin() requires a int or float for theta"
44+
)
45+
46+
if not isinstance(accuracy, int) or accuracy <= 0:
47+
raise ValueError(
48+
"maclaurin_sin() requires a positive int for accuracy"
4849
)
4950

5051
theta = float(theta)
5152

52-
_total = 0
53+
total = 0
5354
for r in range(accuracy):
54-
_total += ((-1) ** r) * ((theta ** (2 * r + 1)) / (factorial(2 * r + 1)))
55-
return float(_total)
55+
total += ((-1) ** r) * ((theta ** (2 * r + 1)) / (factorial(2 * r + 1)))
56+
return float(total)
5657

5758

5859
if __name__ == "__main__":

0 commit comments

Comments
 (0)