from string import ascii_uppercase

Author: cclauss

ciphers/gronsfeld_cipher.py

@@ -6,6 +6,7 @@
 
 https://www.dcode.fr/gronsfeld-cipher
 """
+from string import ascii_uppercase
 
 
 def gronsfeld(text: str, key: str) -> str:
@@ -17,17 +18,16 @@ def gronsfeld(text: str, key: str) -> str:
     >>> gronsfeld('', '123')
     ''
     """
-    alphabets = "ABCDEFGHIJKLMNOPQRSTUVWXYZ"
-    keys = [int(i) for i in key]
+    ascii_len = len(ascii_uppercase)
+    key_len = len(key)
     encrypted_text = ""
+    keys = [int(char) for char in key]
     upper_case_text = text.upper()
 
     for i, char in enumerate(upper_case_text):
         if char in alphabets:
-            new_position = (alphabets.index(char) + keys[i % len(keys)]) % len(
-                alphabets
-            )
-            shifted_letter = alphabets[new_position]
+            new_position = (ascii_uppercase.index(char) + keys[i % key_len]) % ascii_len
+            shifted_letter = ascii_uppercase[new_position]
             encrypted_text += shifted_letter
         else:
             encrypted_text += char