Skip to content

Commit 8ac86f2

Browse files
cclaussdylanbuchi
andauthored
mypy: Exclude only 20 files that are still failing (#5608)
* DRAFT: Run a mypy reality check Let's see what is required to finish #4052 * mypy --ignore-missing-imports --install-types --non-interactive * Check our progress... * Update build.yml * Update build.yml * Update build.yml * Update build.yml * mypy --exclude 20 files * --exclude with no `=` * Update build.yml * 558 character regex!!! * With quotes * mypy.ini: mega exclude * Update mypy.ini * Update build.yml * Update mypy.ini * Update build.yml * Update mypy.ini * .py --> .p* * Escape the dots!: `.` --> `\.` * Remove the comment * Leading slash * Update mypy.ini Co-authored-by: Dylan Buchi <[email protected]> Co-authored-by: Dylan Buchi <[email protected]>
1 parent e7381b5 commit 8ac86f2

File tree

2 files changed

+4
-3
lines changed

2 files changed

+4
-3
lines changed

Diff for: .github/workflows/build.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ jobs:
2121
run: |
2222
python -m pip install --upgrade pip setuptools six wheel
2323
python -m pip install mypy pytest-cov -r requirements.txt
24-
- run: mypy --install-types --non-interactive .
24+
- run: mypy . # See `mypy.ini` for configuration settings.
2525
- name: Run tests
2626
run: pytest --doctest-modules --ignore=project_euler/ --ignore=scripts/validate_solutions.py --cov-report=term-missing:skip-covered --cov=. .
2727
- if: ${{ success() }}

Diff for: mypy.ini

+3-2
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
[mypy]
22
ignore_missing_imports = True
3+
install_types = True
4+
non_interactive = True
5+
exclude = (data_structures/stacks/next_greater_element.py|graphs/boruvka.py|graphs/breadth_first_search.py|graphs/breadth_first_search_2.py|graphs/check_cycle.py|graphs/finding_bridges.py|graphs/greedy_min_vertex_cover.py|graphs/random_graph_generator.py|maths/average_mode.py|maths/gamma_recursive.py|maths/proth_number.py|maths/series/geometric_series.py|maths/series/p_series.py|matrix_operation.py|other/fischer_yates_shuffle.py|other/least_recently_used.py|other/lfu_cache.py|other/lru_cache.py|searches/simulated_annealing.py|searches/ternary_search.py)
36

4-
; FIXME: #4052 fix mypy errors in the exclude directories and remove them below
5-
exclude = (data_structures|graphs|maths|matrix|other|searches)/$

0 commit comments

Comments
 (0)