better tests

Author: coryallegory

project_euler/problem_89/numeralcleanup_test.txt

@@ -0,0 +1,5 @@
+IIII
+IV
+IIIIIIIIII
+X
+VIIIII

project_euler/problem_89/sol1.py

@@ -40,6 +40,8 @@ def parse_roman_numerals(numerals: str) -> int:
     e.g.
     >>> parse_roman_numerals("LXXXIX")
     89
+    >>> parse_roman_numerals("IIII")
+    4
     """
 
     num = 0
@@ -64,6 +66,8 @@ def generate_roman_numerals(num: int) -> str:
     e.g.
     >>> generate_roman_numerals(89)
     'LXXXIX'
+    >>> generate_roman_numerals(4)
+    'IV'
     """
 
     numerals = ""
@@ -112,18 +116,18 @@ def generate_roman_numerals(num: int) -> str:
     return numerals
 
 
-def solution() -> int:
+def solution(roman_numerals_filename: str = "/p089_roman.txt") -> int:
     """
     Calculates and returns the answer to project euler problem 89.
 
     Answer:
-    >>> solution()
-    743
+    >>> solution("/numeralcleanup_test.txt")
+    16
     """
 
     savings = 0
 
-    file1 = open(os.path.dirname(__file__) + "/p089_roman.txt", "r")
+    file1 = open(os.path.dirname(__file__) + roman_numerals_filename, "r")
     lines = file1.readlines()
     for line in lines:
         original = line.strip()