Skip to content

Commit 6bb292d

Browse files
committed
cleans up items from code review for lfu_cache and lru_cache
1 parent 59f151c commit 6bb292d

File tree

2 files changed

+8
-9
lines changed

2 files changed

+8
-9
lines changed

Diff for: other/lfu_cache.py

+2-3
Original file line numberDiff line numberDiff line change
@@ -263,9 +263,8 @@ def set(self, key: T, value: U) -> None:
263263
# explain to type checker via assertions
264264
assert first_node is not None
265265
assert first_node.key is not None
266-
assert (
267-
self.list.remove(first_node) is not None
268-
) # node guaranteed to be in list assert node.key is not None
266+
assert self.list.remove(first_node) is not None
267+
# first_node guaranteed to be in list
269268

270269
del self.cache[first_node.key]
271270
self.num_keys -= 1

Diff for: other/lru_cache.py

+6-6
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,7 @@ class DoubleLinkedListNode(Generic[T, U]):
1010
"""
1111
Double Linked List Node built specifically for LRU Cache
1212
13-
>>> node = DoubleLinkedListNode(1,1)
14-
>>> node
13+
>>> DoubleLinkedListNode(1,1)
1514
Node: key: 1, val: 1, has next: False, has prev: False
1615
"""
1716

@@ -161,9 +160,9 @@ class LRUCache(Generic[T, U]):
161160
Node: key: 1, val: 1, has next: True, has prev: True,
162161
Node: key: None, val: None, has next: False, has prev: True
163162
164-
>>> cache.cache
163+
>>> cache.cache # doctest: +NORMALIZE_WHITESPACE
165164
{1: Node: key: 1, val: 1, has next: True, has prev: True, \
166-
2: Node: key: 2, val: 2, has next: True, has prev: True}
165+
2: Node: key: 2, val: 2, has next: True, has prev: True}
167166
168167
>>> cache.set(3, 3)
169168
@@ -174,9 +173,9 @@ class LRUCache(Generic[T, U]):
174173
Node: key: 3, val: 3, has next: True, has prev: True,
175174
Node: key: None, val: None, has next: False, has prev: True
176175
177-
>>> cache.cache
176+
>>> cache.cache # doctest: +NORMALIZE_WHITESPACE
178177
{1: Node: key: 1, val: 1, has next: True, has prev: True, \
179-
3: Node: key: 3, val: 3, has next: True, has prev: True}
178+
3: Node: key: 3, val: 3, has next: True, has prev: True}
180179
181180
>>> cache.get(2) is None
182181
True
@@ -250,6 +249,7 @@ def get(self, key: T) -> U | None:
250249
Returns the value for the input key and updates the Double Linked List.
251250
Returns None if key is not present in cache
252251
"""
252+
# Note: pythonic interface would throw KeyError rather than return None
253253

254254
if key in self.cache:
255255
self.hits += 1

0 commit comments

Comments
 (0)