Revert "clean of unnecessary checks, imports, calls (#7993)"

This reverts commit f32d611.

Author: ChrisO345

backtracking/rat_in_maze.py

@@ -88,12 +88,12 @@ def run_maze(maze: list[list[int]], i: int, j: int, solutions: list[list[int]])
         solutions[i][j] = 1
         return True
 
-    lower_flag = (not i < 0) and (not j < 0)  # Check lower bounds
+    lower_flag = (not (i < 0)) and (not (j < 0))  # Check lower bounds
     upper_flag = (i < size) and (j < size)  # Check upper bounds
 
     if lower_flag and upper_flag:
         # check for already visited and block points.
-        block_flag = (not solutions[i][j]) and (not maze[i][j])
+        block_flag = (not (solutions[i][j])) and (not (maze[i][j]))
         if block_flag:
             # check visited
             solutions[i][j] = 1

boolean_algebra/not_gate.py

@@ -34,4 +34,4 @@ def test_not_gate() -> None:
 
 if __name__ == "__main__":
     print(not_gate(0))
-    print(not_gate(1))
+    print(not_gate(1))

cellular_automata/nagel_schrekenberg.py

@@ -45,7 +45,8 @@ def construct_highway(
 
     highway = [[-1] * number_of_cells]  # Create a highway without any car
     i = 0
-    initial_speed = max(initial_speed, 0)
+    if initial_speed < 0:
+        initial_speed = 0
     while i < number_of_cells:
         highway[0][i] = (
             randint(0, max_speed) if random_speed else initial_speed

ciphers/mixed_keyword_cypher.py

@@ -42,7 +42,7 @@ def mixed_keyword(key: str = "college", pt: str = "UNIVERSITY") -> str:
         s = []
         for _ in range(len_temp):
             s.append(temp[k])
-            if k >= 25:
+            if not (k < 25):
                 break
             k += 1
         modalpha.append(s)
@@ -52,7 +52,7 @@ def mixed_keyword(key: str = "college", pt: str = "UNIVERSITY") -> str:
     k = 0
     for j in range(len_temp):
         for m in modalpha:
-            if not len(m) - 1 >= j:
+            if not (len(m) - 1 >= j):
                 break
             d[alpha[k]] = m[j]
             if not k < 25:

compression/huffman.py

@@ -56,7 +56,7 @@ def traverse_tree(root: Letter | TreeNode, bitstring: str) -> list[Letter]:
     Recursively traverse the Huffman Tree to set each
     Letter's bitstring dictionary, and return the list of Letters
     """
-    if isinstance(root, Letter):
+    if type(root) is Letter:
         root.bitstring[root.letter] = bitstring
         return [root]
     treenode: TreeNode = root  # type: ignore

data_structures/heap/min_heap.py

@@ -121,7 +121,7 @@ def insert(self, node):
         self.sift_up(len(self.heap) - 1)
 
     def is_empty(self):
-        return len(self.heap) == 0
+        return True if len(self.heap) == 0 else False
 
     def decrease_key(self, node, new_value):
         assert (

digital_image_processing/test_digital_image_processing.py

@@ -10,7 +10,7 @@
 from digital_image_processing import convert_to_negative as cn
 from digital_image_processing import sepia as sp
 from digital_image_processing.dithering import burkes as bs
-from digital_image_processing.edge_detection import canny
+from digital_image_processing.edge_detection import canny as canny
 from digital_image_processing.filters import convolve as conv
 from digital_image_processing.filters import gaussian_filter as gg
 from digital_image_processing.filters import local_binary_pattern as lbp

dynamic_programming/fizz_buzz.py

@@ -33,9 +33,10 @@ def fizz_buzz(number: int, iterations: int) -> str:
         ...
     ValueError: iterations must be defined as integers
     """
-    if not isinstance(iterations, int):
+
+    if not type(iterations) == int:
         raise ValueError("iterations must be defined as integers")
-    if not isinstance(number, int) or not number >= 1:
+    if not type(number) == int or not number >= 1:
         raise ValueError(
             """starting number must be
                          and integer and be more than 0"""

dynamic_programming/max_sub_array.py

@@ -62,7 +62,8 @@ def max_sub_array(nums: list[int]) -> int:
     current = 0
     for i in nums:
         current += i
-        current = max(current, 0)
+        if current < 0:
+            current = 0
         best = max(best, current)
     return best
 

graphs/directed_and_undirected_(weighted)_graph.py

@@ -167,7 +167,7 @@ def cycle_nodes(self):
                         and not on_the_way_back
                     ):
                         len_stack = len(stack) - 1
-                        while len_stack >= 0:
+                        while True and len_stack >= 0:
                             if stack[len_stack] == node[1]:
                                 anticipating_nodes.add(node[1])
                                 break
@@ -220,7 +220,7 @@ def has_cycle(self):
                         and not on_the_way_back
                     ):
                         len_stack_minus_one = len(stack) - 1
-                        while len_stack_minus_one >= 0:
+                        while True and len_stack_minus_one >= 0:
                             if stack[len_stack_minus_one] == node[1]:
                                 anticipating_nodes.add(node[1])
                                 break
@@ -392,7 +392,7 @@ def cycle_nodes(self):
                         and not on_the_way_back
                     ):
                         len_stack = len(stack) - 1
-                        while len_stack >= 0:
+                        while True and len_stack >= 0:
                             if stack[len_stack] == node[1]:
                                 anticipating_nodes.add(node[1])
                                 break
@@ -445,7 +445,7 @@ def has_cycle(self):
                         and not on_the_way_back
                     ):
                         len_stack_minus_one = len(stack) - 1
-                        while len_stack_minus_one >= 0:
+                        while True and len_stack_minus_one >= 0:
                             if stack[len_stack_minus_one] == node[1]:
                                 anticipating_nodes.add(node[1])
                                 break

graphs/multi_heuristic_astar.py

@@ -1,5 +1,4 @@
 import heapq
-import sys
 
 import numpy as np
 
@@ -117,7 +116,7 @@ def do_something(back_pointer, goal, start):
         print(x, end=" ")
         x = back_pointer[x]
     print(x)
-    sys.exit()
+    quit()
 
 
 def valid(p: TPos):

linear_algebra/src/lib.py

@@ -129,7 +129,7 @@ def component(self, i: int) -> float:
         input: index (0-indexed)
         output: the i-th component of the vector.
         """
-        if isinstance(i, int) and -len(self.__components) <= i < len(self.__components):
+        if type(i) is int and -len(self.__components) <= i < len(self.__components):
             return self.__components[i]
         else:
             raise Exception("index out of range")

machine_learning/sequential_minimum_optimization.py

@@ -388,10 +388,16 @@ def _norm(self, data):
             return (data - self._min) / (self._max - self._min)
 
     def _is_unbound(self, index):
-        return bool(0.0 < self.alphas[index] < self._c)
+        if 0.0 < self.alphas[index] < self._c:
+            return True
+        else:
+            return False
 
     def _is_support(self, index):
-        return bool(self.alphas[index] > 0)
+        if self.alphas[index] > 0:
+            return True
+        else:
+            return False
 
     @property
     def unbound(self):

maths/find_min.py

@@ -24,7 +24,8 @@ def find_min(nums: list[int | float]) -> int | float:
         raise ValueError("find_min() arg is an empty sequence")
     min_num = nums[0]
     for num in nums:
-        min_num = min(min_num, num)
+        if min_num > num:
+            min_num = num
     return min_num
 
 

maths/kadanes.py

@@ -49,8 +49,10 @@ def kadanes(arr: list) -> int:
 
     for i in arr:
         max_till_element += i
-        max_sum = max(max_sum, max_till_element)
-        max_till_element = max(max_till_element, 0)
+        if max_sum <= max_till_element:
+            max_sum = max_till_element
+        if max_till_element < 0:
+            max_till_element = 0
     return max_sum
 
 

maths/largest_subarray_sum.py

@@ -11,8 +11,10 @@ def max_sub_array_sum(a: list, size: int = 0):
     max_ending_here = 0
     for i in range(0, size):
         max_ending_here = max_ending_here + a[i]
-        max_so_far = max(max_so_far, max_ending_here)
-        max_ending_here = max(max_ending_here, 0)
+        if max_so_far < max_ending_here:
+            max_so_far = max_ending_here
+        if max_ending_here < 0:
+            max_ending_here = 0
     return max_so_far
 
 

maths/series/geometric_series.py

@@ -52,7 +52,7 @@ def geometric_series(
     power = 1
     multiple = common_ratio_r
     for _ in range(int(nth_term)):
-        if not series:
+        if series == []:
             series.append(start_term_a)
         else:
             power += 1

networking_flow/ford_fulkerson.py

@@ -21,7 +21,7 @@ def bfs(graph, s, t, parent):
                 visited[ind] = True
                 parent[ind] = u
 
-    return visited[t]
+    return True if visited[t] else False
 
 
 def ford_fulkerson(graph, source, sink):

networking_flow/minimum_cut.py

@@ -24,7 +24,7 @@ def bfs(graph, s, t, parent):
                 visited[ind] = True
                 parent[ind] = u
 
-    return visited[t]
+    return True if visited[t] else False
 
 
 def mincut(graph, source, sink):

other/password.py

@@ -89,9 +89,13 @@ def is_strong_password(password: str, min_length: int = 8) -> bool:
     num = any(char in digits for char in password)
     spec_char = any(char in punctuation for char in password)
 
-    return upper and lower and num and spec_char
-    # Passwords should contain UPPERCASE, lowerase
-    # numbers, and special characters
+    if upper and lower and num and spec_char:
+        return True
+
+    else:
+        # Passwords should contain UPPERCASE, lowerase
+        # numbers, and special characters
+        return False
 
 
 def main():

project_euler/problem_025/sol1.py

@@ -43,7 +43,7 @@ def fibonacci(n: int) -> int:
     144
 
     """
-    if n == 1 or not isinstance(n, int):
+    if n == 1 or type(n) is not int:
         return 0
     elif n == 2:
         return 1

project_euler/problem_036/sol1.py

@@ -32,7 +32,7 @@ def is_palindrome(n: int | str) -> bool:
     False
     """
     n = str(n)
-    return n == n[::-1]
+    return True if n == n[::-1] else False
 
 
 def solution(n: int = 1000000):

quantum/q_fourier_transform.py

@@ -55,9 +55,9 @@ def quantum_fourier_transform(number_of_qubits: int = 3) -> qiskit.result.counts
         ...
     ValueError: number of qubits must be exact integer.
     """
-    if isinstance(number_of_qubits, str):
+    if type(number_of_qubits) == str:
         raise TypeError("number of qubits must be a integer.")
-    if number_of_qubits <= 0:
+    if not number_of_qubits > 0:
         raise ValueError("number of qubits must be > 0.")
     if math.floor(number_of_qubits) != number_of_qubits:
         raise ValueError("number of qubits must be exact integer.")

quantum/q_full_adder.py

@@ -60,11 +60,7 @@ def quantum_full_adder(
         ...
     ValueError: inputs must be less or equal to 2.
     """
-    if (
-        isinstance(input_1, str)
-        or isinstance(input_2, str)
-        or isinstance(carry_in, str)
-    ):
+    if (type(input_1) == str) or (type(input_2) == str) or (type(carry_in) == str):
         raise TypeError("inputs must be integers.")
 
     if (input_1 < 0) or (input_2 < 0) or (carry_in < 0):

quantum/superdense_coding.py

@@ -53,7 +53,7 @@ def superdense_coding(bit_1: int = 1, bit_2: int = 1) -> qiskit.result.counts.Co
         ...
     ValueError: inputs must be less or equal to 1.
     """
-    if isinstance(bit_1, str) or isinstance(bit_2, str):
+    if (type(bit_1) == str) or (type(bit_2) == str):
         raise TypeError("inputs must be integers.")
     if (bit_1 < 0) or (bit_2 < 0):
         raise ValueError("inputs must be positive.")

sorts/msd_radix_sort.py

@@ -133,7 +133,7 @@ def _msd_radix_sort_inplace(
     j = end_index - 1
     while i <= j:
         changed = False
-        if not (list_of_ints[i] >> bit_position) & 1:
+        if not ((list_of_ints[i] >> bit_position) & 1):
             # found zero at the beginning
             i += 1
             changed = True

strings/aho_corasick.py

@@ -84,7 +84,7 @@ def search_in(self, string: str) -> dict[str, list[int]]:
             else:
                 current_state = next_state
                 for key in self.adlist[current_state]["output"]:
-                    if key not in result:
+                    if not (key in result):
                         result[key] = []
                     result[key].append(i - len(key) + 1)
         return result