Hacktoberfest 2020: Add style improvements for Project Euler Problem 03 (#2917)

* Fix typehints in project_euler/problem01

Squashed commit of the following:

commit 6801d07
Author: Archaengel <[email protected]>
Date:   Mon Oct 5 16:40:10 2020 -0700

    Fix typehints in project_euler/problem01

commit 29afc3a
Author: Archaengel <[email protected]>
Date:   Mon Oct 5 15:06:34 2020 -0700

    Add typehints and default argument for project_euler/problem_01

* Add default args, typehints, and expand variable names for PE prob 02

* Add style improvements for first solution of PE Problem 02

* Add default arg and typehints for second solution of PE Problem 02

* Add default arg for third solution of PE Problem 02

* Add style improvements for 1st soln of PE problem 03

* Add default arg and typehints for 2nd soln of PE problem 03

* Add default arg for 3rd soln of PE problem 03

* Remove unnecessary newlines

* Remove unnecessary newlines

* Fix end of file for 2nd soln in PE problem 03

Author: archaengel

Diff for: project_euler/problem_03/sol1.py

@@ -5,24 +5,43 @@
 
 e.g. for 10, largest prime factor = 5. For 17, largest prime factor = 17.
 """
+
 import math
 
 
-def isprime(no):
-    if no == 2:
+def isprime(num: int) -> bool:
+    """Returns boolean representing primality of given number num.
+    >>> isprime(2)
+    True
+    >>> isprime(3)
+    True
+    >>> isprime(27)
+    False
+    >>> isprime(2999)
+    True
+    >>> isprime(0)
+    Traceback (most recent call last):
+        ...
+    ValueError: Parameter num must be greater or equal to two.
+    >>> isprime(1)
+    Traceback (most recent call last):
+        ...
+    ValueError: Parameter num must be greater or equal to two.
+    """
+    if num <= 1:
+        raise ValueError("Parameter num must be greater or equal to two.")
+    if num == 2:
         return True
-    elif no % 2 == 0:
+    elif num % 2 == 0:
         return False
-    sq = int(math.sqrt(no)) + 1
-    for i in range(3, sq, 2):
-        if no % i == 0:
+    for i in range(3, int(math.sqrt(num)) + 1, 2):
+        if num % i == 0:
             return False
     return True
 
 
-def solution(n):
+def solution(n: int = 600851475143) -> int:
     """Returns the largest prime factor of a given number n.
-
     >>> solution(13195)
     29
     >>> solution(10)
@@ -54,24 +73,21 @@ def solution(n):
         raise TypeError("Parameter n must be int or passive of cast to int.")
     if n <= 0:
         raise ValueError("Parameter n must be greater or equal to one.")
-    maxNumber = 0
+    max_number = 0
+    if isprime(n):
+        return n
+    while n % 2 == 0:
+        n //= 2
     if isprime(n):
         return n
-    else:
-        while n % 2 == 0:
-            n = n / 2
-        if isprime(n):
-            return int(n)
-        else:
-            n1 = int(math.sqrt(n)) + 1
-            for i in range(3, n1, 2):
-                if n % i == 0:
-                    if isprime(n / i):
-                        maxNumber = n / i
-                        break
-                    elif isprime(i):
-                        maxNumber = i
-            return maxNumber
+    for i in range(3, int(math.sqrt(n)) + 1, 2):
+        if n % i == 0:
+            if isprime(n / i):
+                max_number = n / i
+                break
+            elif isprime(i):
+                max_number = i
+    return max_number
 
 
 if __name__ == "__main__":

Diff for: project_euler/problem_03/sol2.py

@@ -7,9 +7,8 @@
 """
 
 
-def solution(n):
+def solution(n: int = 600851475143) -> int:
     """Returns the largest prime factor of a given number n.
-
     >>> solution(13195)
     29
     >>> solution(10)

Diff for: project_euler/problem_03/sol3.py

@@ -7,9 +7,8 @@
 """
 
 
-def solution(n: int) -> int:
+def solution(n: int = 600851475143) -> int:
     """Returns the largest prime factor of a given number n.
-
     >>> solution(13195)
     29
     >>> solution(10)
@@ -52,12 +51,8 @@ def solution(n: int) -> int:
         while n % i == 0:
             n = n / i
         i += 1
-
     return int(ans)
 
 
 if __name__ == "__main__":
-    # print(solution(int(input().strip())))
-    import doctest
-
-    doctest.testmod()
+    print(solution(int(input().strip())))