Deduplicate euclidean length method for Vector

Author: tianyizheng02

linear_algebra/src/lib.py

@@ -159,18 +159,18 @@ def change_component(self, pos: int, value: float) -> None:
     def euclidean_length(self) -> float:
         """
         returns the euclidean length of the vector
-        """
-        squares = [c ** 2 for c in self.__components]
-        return math.sqrt(sum(squares))
-
-    def magnitude(self) -> float:
-        """
-        Magnitude of a Vector
 
-        >>> Vector([2, 3, 4]).magnitude()
+        >>> Vector([2, 3, 4]).euclidean_length()
         5.385164807134504
-
+        >>> Vector([1]).euclidean_length()
+        1
+        >>> Vector([]).euclidean_length()
+        Traceback (most recent call last):
+        ...
+        Exception: Vector is empty
         """
+        if len(self.__components) == 0:
+            raise Exception("Vector is empty")
         squares = [c ** 2 for c in self.__components]
         return math.sqrt(sum(squares))
 
@@ -188,7 +188,7 @@ def angle(self, other: Vector, deg: bool = False) -> float:
         Exception: invalid operand!
         """
         num = self * other
-        den = self.magnitude() * other.magnitude()
+        den = self.euclidean_length() * other.euclidean_length()
         if deg:
             return math.degrees(math.acos(num / den))
         else:
@@ -267,17 +267,15 @@ class Matrix:
 
     def __init__(self, matrix: list[list[float]], w: int, h: int) -> None:
         """
-        simple constructor for initializing
-        the matrix with components.
+        simple constructor for initializing the matrix with components.
         """
         self.__matrix = matrix
         self.__width = w
         self.__height = h
 
     def __str__(self) -> str:
         """
-        returns a string representation of this
-        matrix.
+        returns a string representation of this matrix.
         """
         ans = ""
         for i in range(self.__height):
@@ -291,7 +289,7 @@ def __str__(self) -> str:
 
     def __add__(self, other: Matrix) -> Matrix:
         """
-        implements the matrix-addition.
+        implements matrix addition.
         """
         if self.__width == other.width() and self.__height == other.height():
             matrix = []
@@ -307,7 +305,7 @@ def __add__(self, other: Matrix) -> Matrix:
 
     def __sub__(self, other: Matrix) -> Matrix:
         """
-        implements the matrix-subtraction.
+        implements matrix subtraction.
         """
         if self.__width == other.width() and self.__height == other.height():
             matrix = []

linear_algebra/src/test_linear_algebra.py

@@ -42,12 +42,14 @@ def test_size(self) -> None:
         x = Vector([1, 2, 3, 4])
         self.assertEqual(len(x), 4)
 
-    def test_euclidLength(self) -> None:
+    def test_euclidean_length(self) -> None:
         """
         test for method euclidean_length()
         """
         x = Vector([1, 2])
+        y = Vector([1, 2, 3, 4, 5])
         self.assertAlmostEqual(x.euclidean_length(), 2.236, 3)
+        self.assertAlmostEqual(y.euclidean_length(), 7.416, 3)
 
     def test_add(self) -> None:
         """