Skip to content

Add tests for Project euler problem 14 solution #1713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 19 commits into from
Nov 16, 2024

Conversation

pomkarnath98
Copy link
Member

@pomkarnath98 pomkarnath98 commented Oct 5, 2024

Open in Gitpod know more

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new JavaScript files are placed inside an existing directory.
  • All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • All new algorithms have a URL in their comments that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@codecov-commenter
Copy link

codecov-commenter commented Oct 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.88%. Comparing base (5b17ea1) to head (12c1d41).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1713      +/-   ##
==========================================
+ Coverage   84.65%   84.88%   +0.22%     
==========================================
  Files         378      378              
  Lines       19744    19744              
  Branches     2952     2959       +7     
==========================================
+ Hits        16715    16760      +45     
+ Misses       3029     2984      -45     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@appgurueu appgurueu changed the title Project euler 14 Add tests for Project euler problem 14 solution Oct 7, 2024
@pomkarnath98 pomkarnath98 requested a review from appgurueu October 8, 2024 13:07
@pomkarnath98
Copy link
Member Author

@raklaptudirm @appgurueu please review and merge

@pomkarnath98 pomkarnath98 added the hacktoberfest-accepted Accepted to be counted towards Hacktoberfest label Oct 16, 2024
@raklaptudirm raklaptudirm merged commit d8588f9 into TheAlgorithms:master Nov 16, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted Accepted to be counted towards Hacktoberfest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants