Skip to content

style: remove listIn and listOut #1669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 11, 2024
Merged

style: remove listIn and listOut #1669

merged 1 commit into from
Jun 11, 2024

Conversation

vil02
Copy link
Member

@vil02 vil02 commented Jun 9, 2024

Open in Gitpod know more

Describe your change:

This PR fixes the failing CI. I decided to remove these functions because of:

JavaScript/CONTRIBUTING.md

Line 162 in 1554ba5

- Please refrain from using `console.log` or any other console methods.

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new JavaScript files are placed inside an existing directory.
  • All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • All new algorithms have a URL in their comments that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@vil02 vil02 marked this pull request as ready for review June 9, 2024 19:21
@raklaptudirm raklaptudirm merged commit 0182bca into TheAlgorithms:master Jun 11, 2024
2 of 3 checks passed
@vil02 vil02 deleted the fix_codespell_failure branch June 11, 2024 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@appgurueu appgurueu appgurueu approved these changes

@raklaptudirm raklaptudirm Awaiting requested review from raklaptudirm raklaptudirm is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vil02 @appgurueu @raklaptudirm