Skip to content

Update CircularQueue.js for zero-length case #1655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 3, 2024
Merged

Update CircularQueue.js for zero-length case #1655

merged 3 commits into from
Apr 3, 2024

Conversation

MartinLBeacham
Copy link
Contributor

Open in Gitpod know more

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new JavaScript files are placed inside an existing directory.
  • All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • All new algorithms have a URL in their comments that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@codecov-commenter
Copy link

codecov-commenter commented Mar 30, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 84.07%. Comparing base (702840b) to head (d8323c8).

Files Patch % Lines
Data-Structures/Queue/CircularQueue.js 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #1655   +/-   ##
=======================================
  Coverage   84.07%   84.07%           
=======================================
  Files         375      375           
  Lines       19688    19688           
  Branches     2914     2914           
=======================================
  Hits        16552    16552           
  Misses       3136     3136

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MartinLBeacham
Update CircularQueue.js
7adf170 
Taking comments into account for refactoring my change.
appgurueu
appgurueu previously approved these changes Mar 30, 2024
View reviewed changes
@MartinLBeacham
Update CircularQueue.js
d8323c8 
Adding "this" to checkEmpty()
appgurueu
appgurueu approved these changes Mar 30, 2024
View reviewed changes
Copy link
Collaborator

@appgurueu appgurueu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be good to add a test for this.

@raklaptudirm raklaptudirm merged commit 314144f into TheAlgorithms:master Apr 3, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@appgurueu appgurueu appgurueu approved these changes

@raklaptudirm raklaptudirm raklaptudirm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MartinLBeacham @codecov-commenter @appgurueu @raklaptudirm