refactor: use isLeapYear
#1638
Merged
refactor: use isLeapYear
#1638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1638 +/- ##
=======================================
Coverage 83.93% 83.94%
=======================================
Files 377 377
Lines 19733 19727 -6
Branches 2921 2918 -3
=======================================
- Hits 16563 16559 -4
+ Misses 3170 3168 -2 ☔ View full report in Codecov by Sentry. |
vil02
force-pushed
the
use_isLeapYear
branch
2 times, most recently
from
c523049 to
5faf0a5
Compare
appgurueu
approved these changes
Mar 5, 2024
|
@appgurueu or @raklaptudirm could you please re-run the |
appgurueu
force-pushed
the
use_isLeapYear
branch
from
5faf0a5 to
00aca32
Compare
|
(Just amended your last commit and force pushed to trigger a rerun of CI) |
I could do the same, but I did not want to lose your approval. Thanks! |
Heh, right. Sometimes our strict repo config frustrates me a bit. |
raklaptudirm
approved these changes
Mar 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your change:
This PR:
isLeapYear,GetMonthDays- note the change of the year in one of the test cases (I do not want to create an illusion that this function should be uses for years before 1582).Checklist:
This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.Example:
UserProfile.jsis allowed butuserprofile.js,Userprofile.js,user-Profile.js,userProfile.jsare notFixes: #{$ISSUE_NO}.