From 219d861190dc7f2ab03a652dda0d237bb4a8ef48 Mon Sep 17 00:00:00 2001 From: lcvieira2001 Date: Sun, 30 Oct 2022 12:16:12 -0300 Subject: [PATCH 1/3] Added liters to imperial gallons conversion --- Conversions/LitersToImperialGallons.js | 11 +++++++++++ Conversions/test/LitersToImperialGallons.test.js | 5 +++++ 2 files changed, 16 insertions(+) create mode 100644 Conversions/LitersToImperialGallons.js create mode 100644 Conversions/test/LitersToImperialGallons.test.js diff --git a/Conversions/LitersToImperialGallons.js b/Conversions/LitersToImperialGallons.js new file mode 100644 index 0000000000..6a4e4e32e4 --- /dev/null +++ b/Conversions/LitersToImperialGallons.js @@ -0,0 +1,11 @@ +/** + * This function converts liters to US gallons + * https://en.wikipedia.org/wiki/Gallon + * @constructor + * @param {number} liters - Amount of liters to convert to gallons + */ +const litersToImperialGallons = (liters) => { + return liters / 4.54609 +} + +export default litersToImperialGallons diff --git a/Conversions/test/LitersToImperialGallons.test.js b/Conversions/test/LitersToImperialGallons.test.js new file mode 100644 index 0000000000..3a019887d8 --- /dev/null +++ b/Conversions/test/LitersToImperialGallons.test.js @@ -0,0 +1,5 @@ +import litersToImperialGallons from '../LitersToImperialGallons' + +test('Convert 25 liters to imperial gallons', () => { + expect(parseFloat(litersToImperialGallons(25).toFixed(2))).toBe(5.5) +}) From c8c19faf03cb4ad782756dd5a5ccd2714a7b28ee Mon Sep 17 00:00:00 2001 From: lcvieira2001 Date: Sun, 30 Oct 2022 12:18:30 -0300 Subject: [PATCH 2/3] Fixed documentation @see --- Conversions/LitersToImperialGallons.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Conversions/LitersToImperialGallons.js b/Conversions/LitersToImperialGallons.js index 6a4e4e32e4..8022282e4c 100644 --- a/Conversions/LitersToImperialGallons.js +++ b/Conversions/LitersToImperialGallons.js @@ -1,8 +1,8 @@ /** * This function converts liters to US gallons - * https://en.wikipedia.org/wiki/Gallon * @constructor * @param {number} liters - Amount of liters to convert to gallons + * @see https://en.wikipedia.org/wiki/Gallon */ const litersToImperialGallons = (liters) => { return liters / 4.54609 From befa3b3612e637fbe8546acc3743b5e85f305e7e Mon Sep 17 00:00:00 2001 From: Lcvieira2001 <114815013+Lcvieira2001@users.noreply.github.com> Date: Sun, 30 Oct 2022 12:33:25 -0300 Subject: [PATCH 3/3] Pr suggestion --- Conversions/LitersToImperialGallons.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Conversions/LitersToImperialGallons.js b/Conversions/LitersToImperialGallons.js index 8022282e4c..5e8008ecbf 100644 --- a/Conversions/LitersToImperialGallons.js +++ b/Conversions/LitersToImperialGallons.js @@ -1,5 +1,5 @@ /** - * This function converts liters to US gallons + * This function converts liters to imperial gallons * @constructor * @param {number} liters - Amount of liters to convert to gallons * @see https://en.wikipedia.org/wiki/Gallon