From fd72d04d433304440c2dfc07fee2ad122d8fecd5 Mon Sep 17 00:00:00 2001 From: lcvieira2001 Date: Sun, 30 Oct 2022 02:30:30 -0300 Subject: [PATCH 1/3] Added ounces to kilograms convertion --- Conversions/OuncesToKilograms.js | 8 ++++++++ Conversions/test/OuncesToKilogram.test.js | 7 +++++++ 2 files changed, 15 insertions(+) create mode 100644 Conversions/OuncesToKilograms.js create mode 100644 Conversions/test/OuncesToKilogram.test.js diff --git a/Conversions/OuncesToKilograms.js b/Conversions/OuncesToKilograms.js new file mode 100644 index 0000000000..a04cbe29b1 --- /dev/null +++ b/Conversions/OuncesToKilograms.js @@ -0,0 +1,8 @@ +/* https://en.wikipedia.org/wiki/Ounce returns it up to 3 decimal places */ +const ouncesToKilograms = (oz) => { + let res = oz * 28.3498 / 1000 + res = res.toFixed(3) + return parseFloat(res) +} + +export { ouncesToKilograms } diff --git a/Conversions/test/OuncesToKilogram.test.js b/Conversions/test/OuncesToKilogram.test.js new file mode 100644 index 0000000000..3c756243b5 --- /dev/null +++ b/Conversions/test/OuncesToKilogram.test.js @@ -0,0 +1,7 @@ +import { ouncesToKilograms } from '../OuncesToKilograms' + +describe('Testing OuncesToKilogram', () => { + it('should return ', () => { + expect(ouncesToKilograms(60)).toBe(1.701) + }) +}) From 49a4ea74ccef0d1bb73ff5c93fff5e7ac060b08c Mon Sep 17 00:00:00 2001 From: lcvieira2001 Date: Sun, 30 Oct 2022 11:54:14 -0300 Subject: [PATCH 2/3] Added PR suggestions --- Conversions/OuncesToKilograms.js | 11 +++++++---- Conversions/test/OuncesToKilogram.test.js | 6 ++---- 2 files changed, 9 insertions(+), 8 deletions(-) diff --git a/Conversions/OuncesToKilograms.js b/Conversions/OuncesToKilograms.js index a04cbe29b1..545b769871 100644 --- a/Conversions/OuncesToKilograms.js +++ b/Conversions/OuncesToKilograms.js @@ -1,8 +1,11 @@ -/* https://en.wikipedia.org/wiki/Ounce returns it up to 3 decimal places */ +/** + * This function converts ounces to kilograms + * https://en.wikipedia.org/wiki/Ounce + * @constructor + * @param {number} oz - Amount of ounces to convert to kilograms + */ const ouncesToKilograms = (oz) => { - let res = oz * 28.3498 / 1000 - res = res.toFixed(3) - return parseFloat(res) + return oz * 28.3498 / 1000 } export { ouncesToKilograms } diff --git a/Conversions/test/OuncesToKilogram.test.js b/Conversions/test/OuncesToKilogram.test.js index 3c756243b5..d24cfdf785 100644 --- a/Conversions/test/OuncesToKilogram.test.js +++ b/Conversions/test/OuncesToKilogram.test.js @@ -1,7 +1,5 @@ import { ouncesToKilograms } from '../OuncesToKilograms' -describe('Testing OuncesToKilogram', () => { - it('should return ', () => { - expect(ouncesToKilograms(60)).toBe(1.701) - }) +test('Convert 60 ounces to kilograms', () => { + expect(parseFloat(ouncesToKilograms(60).toFixed(3))).toBe(1.701) }) From b0e3c16d81d895506e95ec343e5feca5a9a9f38a Mon Sep 17 00:00:00 2001 From: lcvieira2001 Date: Sun, 30 Oct 2022 12:09:29 -0300 Subject: [PATCH 3/3] changed to export default --- Conversions/OuncesToKilograms.js | 2 +- Conversions/test/OuncesToKilogram.test.js | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/Conversions/OuncesToKilograms.js b/Conversions/OuncesToKilograms.js index 545b769871..d39de85642 100644 --- a/Conversions/OuncesToKilograms.js +++ b/Conversions/OuncesToKilograms.js @@ -8,4 +8,4 @@ const ouncesToKilograms = (oz) => { return oz * 28.3498 / 1000 } -export { ouncesToKilograms } +export default ouncesToKilograms diff --git a/Conversions/test/OuncesToKilogram.test.js b/Conversions/test/OuncesToKilogram.test.js index d24cfdf785..e72e06958a 100644 --- a/Conversions/test/OuncesToKilogram.test.js +++ b/Conversions/test/OuncesToKilogram.test.js @@ -1,4 +1,4 @@ -import { ouncesToKilograms } from '../OuncesToKilograms' +import ouncesToKilograms from '../OuncesToKilograms' test('Convert 60 ounces to kilograms', () => { expect(parseFloat(ouncesToKilograms(60).toFixed(3))).toBe(1.701)