Skip to content

Improper and incomplete implementation of CycleDetection.js #1097

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
10kartik opened this issue Sep 13, 2022 · 1 comment · Fixed by #1099
Closed

Improper and incomplete implementation of CycleDetection.js #1097

10kartik opened this issue Sep 13, 2022 · 1 comment · Fixed by #1099
Assignees
@10kartik
Labels
code quality Code quality improvement

Comments

@10kartik
Copy link
Contributor

Implementation of CycleDetection.js seems inappropriate.

  • Weird function name main() and its invocation can cause the program to crash.
  • Tests are missing.
  • Not exported, Hence not resuable.
  • Can be optimized further (Optional)
@appgurueu appgurueu added the code quality Code quality improvement label Sep 13, 2022
@appgurueu
Copy link
Collaborator

The algorithm is complete. It has poor code quality though, as you have pointed out. Feel free to fix it.

@10kartik 10kartik mentioned this issue Sep 13, 2022
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@10kartik 10kartik

Labels
code quality Code quality improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: Cycledetection.js and added tests 10kartik/JavaScript
2 participants
@appgurueu @10kartik