Migrate doctest for ReverseString.js

(also remove inline test driver code)

Author: defaude

String/ReverseString.js

@@ -1,26 +1,5 @@
 /**
- * A short example showing how to reverse a string
- * @flow
- */
-
-/**
- * Create a new string and append
- * @complexity O(n)
- *
- *  Doctests
- *
- * > ReverseStringIterative('some')
- *  'emos'
- * > ReverseStringIterative('string')
- *  'gnirts'
- * > ReverseStringIterative('The Algorithms Javascript')
- *  'tpircsavaJ smhtiroglA ehT'
- * > ReverseStringIterative([])
- *  ! TypeError
- * > ReverseStringIterative({})
- *  ! TypeError
- * > ReverseStringIterative(null)
- *  ! TypeError
+ * A short example showing how to reverse a string.
  */
 function ReverseStringIterative (string) {
   if (typeof string !== 'string') {
@@ -40,34 +19,17 @@ function ReverseStringIterative (string) {
  * JS disallows string mutation so we're actually a bit slower.
  *
  * @complexity O(n)
- *
- * 'some' -> 'eoms' -> 'emos'
- *
- *  Doctests
- *
- * > ReverseStringIterativeInplace('some')
- *  'emos'
- * > ReverseStringIterativeInplace('string')
- *  'gnirts'
- * > ReverseStringIterativeInplace('The Algorithms Javascript')
- *  'tpircsavaJ smhtiroglA ehT'
- * > ReverseStringIterativeInplace([])
- *  ! TypeError
- * > ReverseStringIterativeInplace({})
- *  ! TypeError
- * > ReverseStringIterativeInplace(null)
- *  ! TypeError
  */
 function ReverseStringIterativeInplace (string) {
   if (typeof string !== 'string') {
     throw new TypeError('The given value is not a string')
   }
+
   const _string = string.split('')
 
   for (let i = 0; i < Math.floor(_string.length / 2); i++) {
     const first = _string[i]
-    const second = _string[_string.length - 1 - i]
-    _string[i] = second
+    _string[i] = _string[_string.length - 1 - i]
     _string[_string.length - 1 - i] = first
   }
 

String/test/ReverseString.test.js

@@ -1,63 +1,65 @@
-import {
-  ReverseStringIterative,
-  ReverseStringIterativeInplace
-} from '../ReverseString'
+import { ReverseStringIterative, ReverseStringIterativeInplace } from '../ReverseString'
 
 describe('ReverseStringIterative', () => {
   it('expects to reverse a simple string', () => {
-    const SUT = ReverseStringIterative('reverse')
-    expect(SUT).toEqual('esrever')
+    expect(ReverseStringIterative('reverse')).toEqual('esrever')
+    expect(ReverseStringIterative('some')).toEqual('emos')
+    expect(ReverseStringIterative('string')).toEqual('gnirts')
+    expect(ReverseStringIterative('The Algorithms Javascript')).toEqual('tpircsavaJ smhtiroglA ehT')
   })
+
   it('expects to reverse a string with spaces in between', () => {
-    const SUT = ReverseStringIterative('reverse me')
-    expect(SUT).toEqual('em esrever')
+    expect(ReverseStringIterative('reverse me')).toEqual('em esrever')
   })
+
   it('expects to reverse a simple string without capitalizing the first letter', () => {
-    const SUT = ReverseStringIterative('Javascript')
-    expect(SUT).toEqual('tpircsavaJ')
+    expect(ReverseStringIterative('Javascript')).toEqual('tpircsavaJ')
   })
+
   it.each`
     input
     ${123456}
     ${[1, 2, 3, 4, 5, 6]}
     ${{ test: 'test' }}
+    ${null}
   `(
     'expects to throw a type error given a value that is $input',
     ({ input }) => {
-      expect(() => {
-        ReverseStringIterative(input)
-      }).toThrow('The given value is not a string')
+      expect(() => ReverseStringIterative(input)).toThrow('The given value is not a string')
     }
   )
+
   it('expects to return a empty string with an empty string is given', () => {
-    const SUT = ReverseStringIterative('')
-    expect(SUT).toEqual('')
+    expect(ReverseStringIterative('')).toEqual('')
   })
 })
+
 describe('ReverseStringIterativeInplace', () => {
   it('expects to reverse a simple string', () => {
-    const SUT = ReverseStringIterativeInplace('reverse')
-    expect(SUT).toEqual('esrever')
+    expect(ReverseStringIterativeInplace('reverse')).toEqual('esrever')
+    expect(ReverseStringIterativeInplace('some')).toEqual('emos')
+    expect(ReverseStringIterativeInplace('string')).toEqual('gnirts')
+    expect(ReverseStringIterativeInplace('The Algorithms Javascript')).toEqual('tpircsavaJ smhtiroglA ehT')
   })
+
   it('expects to reverse a simple string without capitalizing the first letter', () => {
-    const SUT = ReverseStringIterativeInplace('Javascript')
-    expect(SUT).toEqual('tpircsavaJ')
+    expect(ReverseStringIterativeInplace('Javascript')).toEqual('tpircsavaJ')
   })
+
   it('expects to return an empty string given an empty string', () => {
-    const SUT = ReverseStringIterativeInplace('Javascript')
-    expect(SUT).toEqual('tpircsavaJ')
+    expect(ReverseStringIterativeInplace('Javascript')).toEqual('tpircsavaJ')
   })
+
   it.each`
     input
     ${123456}
     ${[1, 2, 3, 4, 5, 6]}
     ${{ test: 'test' }}
+    ${null}
   `(
     'expects to throw a type error given a value that is $input',
     ({ input }) => {
-      expect(() => {
-        ReverseStringIterativeInplace(input)
-      }).toThrow('The given value is not a string')
+      expect(() => ReverseStringIterativeInplace(input)).toThrow('The given value is not a string')
     }
   )
 })