From b6772c5fb14ae98f8955b60cc6c20314ceafbe35 Mon Sep 17 00:00:00 2001 From: Abhijay Kumar Date: Wed, 22 May 2019 12:49:33 +0530 Subject: [PATCH 1/4] Cast the second operand of Math.pow to double --- src/main/java/com/generation/SimplexNoise.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/main/java/com/generation/SimplexNoise.java b/src/main/java/com/generation/SimplexNoise.java index a4fcb3f17a78..485a55b2b413 100644 --- a/src/main/java/com/generation/SimplexNoise.java +++ b/src/main/java/com/generation/SimplexNoise.java @@ -36,7 +36,7 @@ public SimplexNoise(int largestFeature, double persistence, long seed) { this.octaves[index] = new SimplexNoiseOctave(random.nextInt()); this.frequencys[index] = Math.pow(2, index); - this.amplitudes[index] = Math.pow(persistence, octaveCount - index); + this.amplitudes[index] = Math.pow(persistence, (double)octaveCount - index); } } @@ -103,7 +103,7 @@ public double getNoise(int x, int y, int z) { for (int index = 0; index < this.octaves.length; index++) { double frequency = Math.pow(2, index); - double amplitude = Math.pow(this.persistance, this.octaves.length - index); + double amplitude = Math.pow(this.persistance, (double)this.octaves.length - index); result += this.octaves[index].noise(x / frequency, y / frequency, z / frequency) * amplitude; } From 5358f8ddc998b59c95a400e9a6011b900a1f0c7f Mon Sep 17 00:00:00 2001 From: Abhijay Kumar Date: Thu, 23 May 2019 00:21:14 +0530 Subject: [PATCH 2/4] Added space after typecast expression Co-Authored-By: Libin Yang --- src/main/java/com/generation/SimplexNoise.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/main/java/com/generation/SimplexNoise.java b/src/main/java/com/generation/SimplexNoise.java index 485a55b2b413..50abd399d439 100644 --- a/src/main/java/com/generation/SimplexNoise.java +++ b/src/main/java/com/generation/SimplexNoise.java @@ -36,7 +36,7 @@ public SimplexNoise(int largestFeature, double persistence, long seed) { this.octaves[index] = new SimplexNoiseOctave(random.nextInt()); this.frequencys[index] = Math.pow(2, index); - this.amplitudes[index] = Math.pow(persistence, (double)octaveCount - index); + this.amplitudes[index] = Math.pow(persistence, (double) octaveCount - index); } } From c25da3ce974d6120574b83664733044e46741eba Mon Sep 17 00:00:00 2001 From: Abhijay Kumar Date: Thu, 23 May 2019 09:40:46 +0530 Subject: [PATCH 3/4] Update src/main/java/com/generation/SimplexNoise.java Co-Authored-By: Libin Yang --- src/main/java/com/generation/SimplexNoise.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/main/java/com/generation/SimplexNoise.java b/src/main/java/com/generation/SimplexNoise.java index 50abd399d439..fb4473dcf293 100644 --- a/src/main/java/com/generation/SimplexNoise.java +++ b/src/main/java/com/generation/SimplexNoise.java @@ -103,7 +103,7 @@ public double getNoise(int x, int y, int z) { for (int index = 0; index < this.octaves.length; index++) { double frequency = Math.pow(2, index); - double amplitude = Math.pow(this.persistance, (double)this.octaves.length - index); + double amplitude = Math.pow(this.persistance, (double) this.octaves.length - index); result += this.octaves[index].noise(x / frequency, y / frequency, z / frequency) * amplitude; } From 3f9ff6e3b54104d0d5e598f893a8cb8589450e3d Mon Sep 17 00:00:00 2001 From: Abhijay Kumar Date: Thu, 23 May 2019 12:07:30 +0530 Subject: [PATCH 4/4] Prevent the byte from getting automatically promoted --- src/main/java/com/crypto/codec/Base64.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/main/java/com/crypto/codec/Base64.java b/src/main/java/com/crypto/codec/Base64.java index 9d1ff91c2491..f65faf963bcb 100644 --- a/src/main/java/com/crypto/codec/Base64.java +++ b/src/main/java/com/crypto/codec/Base64.java @@ -184,7 +184,7 @@ private static byte[] decodeBlock(byte[] block) { decodedBlock[0] = (byte) (decodeAlphabet[block[0]] << 2 | decodeAlphabet[block[1]] >>> 4); decodedBlock[1] = (byte) (decodeAlphabet[block[1]] << 4 | decodeAlphabet[block[2]] >>> 2); - decodedBlock[2] = (byte) (decodeAlphabet[block[2]] << 6 | decodeAlphabet[block[3]]); + decodedBlock[2] = (byte) (decodeAlphabet[block[2]] << 6 | decodeAlphabet[block[3]] & 0xff); return decodedBlock; }