Skip to content

Add LongestIncreasingSubsequenceNLogN class and corresponding test class #6221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Apr 15, 2025
Merged

Add LongestIncreasingSubsequenceNLogN class and corresponding test class #6221

merged 11 commits into from
Apr 15, 2025
+97 −0

Conversation

huseynovvusal
Copy link
Contributor

Hello, everyone! I added O(nlogn) solution of Longest Increasing Subsequence problem with simple and easy-to-follow explanations.

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized it.
  • All filenames are in PascalCase.
  • All functions and variable names follow Java naming conventions.
  • All new algorithms have a URL in their comments that points to Wikipedia or other similar explanations.
  • All new code is formatted with clang-format -i --style=file path/to/your/file.java

@huseynovvusal huseynovvusal marked this pull request as ready for review April 14, 2025 16:56
@codecov-commenter
Copy link

codecov-commenter commented Apr 14, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 94.73684% with 1 line in your changes missing coverage. Please review.

Project coverage is 73.80%. Comparing base (c8177e3) to head (6b7b6fe).

Files with missing lines Patch % Lines
...programming/LongestIncreasingSubsequenceNLogN.java 94.73% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##             master    #6221      +/-   ##
============================================
+ Coverage     73.78%   73.80%   +0.01%     
- Complexity     5304     5310       +6     
============================================
  Files           672      673       +1     
  Lines         18357    18376      +19     
  Branches       3549     3553       +4     
============================================
+ Hits          13545    13562      +17     
  Misses         4265     4265              
- Partials        547      549       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@DenizAltunkapan
Copy link
Collaborator

LGM, but i think the actions will fail because there is no private constructor

siriak
siriak approved these changes Apr 15, 2025
View reviewed changes
Copy link
Member

@siriak siriak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@siriak siriak enabled auto-merge (squash) April 15, 2025 13:05
@huseynovvusal
Copy link
Contributor Author

Looks good, thanks!

Glad to hear! 🎉

@siriak siriak merged commit ad5e496 into TheAlgorithms:master Apr 15, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siriak siriak siriak approved these changes

@yanglbme yanglbme Awaiting requested review from yanglbme yanglbme is a code owner

@vil02 vil02 Awaiting requested review from vil02 vil02 is a code owner

@BamaCharanChhandogi BamaCharanChhandogi Awaiting requested review from BamaCharanChhandogi BamaCharanChhandogi is a code owner

@alxkm alxkm Awaiting requested review from alxkm alxkm is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@huseynovvusal @codecov-commenter @DenizAltunkapan @siriak