From 9b41bf207f5d20e74c5fce4359772f65c38eda42 Mon Sep 17 00:00:00 2001 From: Hardik Pawar Date: Sun, 20 Oct 2024 19:48:46 +0530 Subject: [PATCH 1/6] refactor: Enhance docs, remove `main`, add tests in `AnytoAny` --- .../thealgorithms/conversions/AnytoAny.java | 83 +++++++++++++------ .../conversions/AnytoAnyTest.java | 52 ++++++++++++ 2 files changed, 110 insertions(+), 25 deletions(-) create mode 100644 src/test/java/com/thealgorithms/conversions/AnytoAnyTest.java diff --git a/src/main/java/com/thealgorithms/conversions/AnytoAny.java b/src/main/java/com/thealgorithms/conversions/AnytoAny.java index 801e493032e0..e7bdbc2b79c4 100644 --- a/src/main/java/com/thealgorithms/conversions/AnytoAny.java +++ b/src/main/java/com/thealgorithms/conversions/AnytoAny.java @@ -1,35 +1,68 @@ package com.thealgorithms.conversions; -import java.util.Scanner; - -// given a source number , source base, destination base, this code can give you the destination -// number. -// sn ,sb,db ---> ()dn . this is what we have to do . - +/** + * A utility class for converting numbers from any base to any other base. + * + * This class provides a method to convert a source number from a given base + * to a destination number in another base. Valid bases range from 2 to 10. + */ public final class AnytoAny { private AnytoAny() { } - public static void main(String[] args) { - Scanner scn = new Scanner(System.in); - int sn = scn.nextInt(); - int sb = scn.nextInt(); - int db = scn.nextInt(); - int m = 1; - int dec = 0; - int dn = 0; - while (sn != 0) { - dec = dec + (sn % 10) * m; - m *= sb; - sn /= 10; + /** + * Converts a number from a source base to a destination base. + * + * @param sourceNumber The number in the source base (as an integer). + * @param sourceBase The base of the source number (between 2 and 10). + * @param destBase The base to which the number should be converted (between 2 and 10). + * @throws IllegalArgumentException if the bases are not between 2 and 10. + * @return The converted number in the destination base (as an integer). + */ + public static int convertBase(int sourceNumber, int sourceBase, int destBase) { + if (sourceBase < 2 || sourceBase > 10 || destBase < 2 || destBase > 10) { + throw new IllegalArgumentException("Bases must be between 2 and 10."); + } + + int decimalValue = toDecimal(sourceNumber, sourceBase); + return fromDecimal(decimalValue, destBase); + } + + /** + * Converts a number from a given base to its decimal representation (base 10). + * + * @param number The number in the original base. + * @param base The base of the given number. + * @return The decimal representation of the number. + */ + private static int toDecimal(int number, int base) { + int decimalValue = 0; + int multiplier = 1; + + while (number != 0) { + decimalValue += (number % 10) * multiplier; + multiplier *= base; + number /= 10; } - m = 1; - while (dec != 0) { - dn = dn + (dec % db) * m; - m *= 10; - dec /= db; + return decimalValue; + } + + /** + * Converts a decimal (base 10) number to a specified base. + * + * @param decimal The decimal number to convert. + * @param base The destination base for conversion. + * @return The number in the specified base. + */ + private static int fromDecimal(int decimal, int base) { + int result = 0; + int multiplier = 1; + + while (decimal != 0) { + result += (decimal % base) * multiplier; + multiplier *= 10; + decimal /= base; } - System.out.println(dn); - scn.close(); + return result; } } diff --git a/src/test/java/com/thealgorithms/conversions/AnytoAnyTest.java b/src/test/java/com/thealgorithms/conversions/AnytoAnyTest.java new file mode 100644 index 000000000000..39ebf9269086 --- /dev/null +++ b/src/test/java/com/thealgorithms/conversions/AnytoAnyTest.java @@ -0,0 +1,52 @@ +package com.thealgorithms.conversions; + +import static org.junit.jupiter.api.Assertions.assertEquals; +import static org.junit.jupiter.api.Assertions.assertThrows; + +import org.junit.jupiter.api.Test; + +public class AnytoAnyTest { + + @Test + void testValidConversions() { + assertEquals(101, AnytoAny.convertBase(5, 10, 2), "Decimal 5 should convert to binary 101"); + assertEquals(2, AnytoAny.convertBase(2, 2, 10), "Binary 10 should convert to decimal 2"); + assertEquals(6, AnytoAny.convertBase(110, 2, 8), "Binary 110 should convert to octal 6"); + assertEquals(111, AnytoAny.convertBase(7, 10, 2), "Decimal 7 should convert to binary 111"); + } + + @Test + void testDecimalToBinary() { + assertEquals(1101, AnytoAny.convertBase(13, 10, 2), "Decimal 13 should convert to binary 1101"); + assertEquals(0, AnytoAny.convertBase(0, 10, 2), "Decimal 0 should convert to binary 0"); + } + + @Test + void testBinaryToDecimal() { + assertEquals(13, AnytoAny.convertBase(1101, 2, 10), "Binary 1101 should convert to decimal 13"); + assertEquals(0, AnytoAny.convertBase(0, 2, 10), "Binary 0 should convert to decimal 0"); + } + + @Test + void testOctalToDecimal() { + assertEquals(8, AnytoAny.convertBase(10, 8, 10), "Octal 10 should convert to decimal 8"); + assertEquals(65, AnytoAny.convertBase(101, 8, 10), "Octal 101 should convert to decimal 65"); + } + + @Test + void testInvalidBases() { + assertThrows(IllegalArgumentException.class, + () -> AnytoAny.convertBase(5, 1, 10), + "Source base less than 2 should throw IllegalArgumentException"); + + assertThrows(IllegalArgumentException.class, + () -> AnytoAny.convertBase(5, 10, 11), + "Destination base greater than 10 should throw IllegalArgumentException"); + } + + @Test + void testLargeNumberConversion() { + assertEquals(1111101000, AnytoAny.convertBase(1000, 10, 2), "Decimal 1000 should convert to binary 1111101000"); + assertEquals(1750, AnytoAny.convertBase(1000, 10, 8), "Decimal 1000 should convert to octal 1750"); + } +} From 5db45e91698adae482eb7cd313515b1af3a5ca5e Mon Sep 17 00:00:00 2001 From: Hardvan Date: Sun, 20 Oct 2024 14:19:05 +0000 Subject: [PATCH 2/6] Update directory --- DIRECTORY.md | 1 + 1 file changed, 1 insertion(+) diff --git a/DIRECTORY.md b/DIRECTORY.md index e511ab40b329..2646e854610c 100644 --- a/DIRECTORY.md +++ b/DIRECTORY.md @@ -742,6 +742,7 @@ * conversions * [AffineConverterTest](https://github.com/TheAlgorithms/Java/blob/master/src/test/java/com/thealgorithms/conversions/AffineConverterTest.java) * [AnyBaseToDecimalTest](https://github.com/TheAlgorithms/Java/blob/master/src/test/java/com/thealgorithms/conversions/AnyBaseToDecimalTest.java) + * [AnytoAnyTest](https://github.com/TheAlgorithms/Java/blob/master/src/test/java/com/thealgorithms/conversions/AnytoAnyTest.java) * [BinaryToDecimalTest](https://github.com/TheAlgorithms/Java/blob/master/src/test/java/com/thealgorithms/conversions/BinaryToDecimalTest.java) * [BinaryToHexadecimalTest](https://github.com/TheAlgorithms/Java/blob/master/src/test/java/com/thealgorithms/conversions/BinaryToHexadecimalTest.java) * [BinaryToOctalTest](https://github.com/TheAlgorithms/Java/blob/master/src/test/java/com/thealgorithms/conversions/BinaryToOctalTest.java) From 698112cbff2923d0f5fd6ef595ef7ba237b0c226 Mon Sep 17 00:00:00 2001 From: Hardik Pawar Date: Sun, 20 Oct 2024 19:49:12 +0530 Subject: [PATCH 3/6] Fix --- .../java/com/thealgorithms/conversions/AnytoAnyTest.java | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/src/test/java/com/thealgorithms/conversions/AnytoAnyTest.java b/src/test/java/com/thealgorithms/conversions/AnytoAnyTest.java index 39ebf9269086..cdc012180bf9 100644 --- a/src/test/java/com/thealgorithms/conversions/AnytoAnyTest.java +++ b/src/test/java/com/thealgorithms/conversions/AnytoAnyTest.java @@ -35,13 +35,9 @@ void testOctalToDecimal() { @Test void testInvalidBases() { - assertThrows(IllegalArgumentException.class, - () -> AnytoAny.convertBase(5, 1, 10), - "Source base less than 2 should throw IllegalArgumentException"); + assertThrows(IllegalArgumentException.class, () -> AnytoAny.convertBase(5, 1, 10), "Source base less than 2 should throw IllegalArgumentException"); - assertThrows(IllegalArgumentException.class, - () -> AnytoAny.convertBase(5, 10, 11), - "Destination base greater than 10 should throw IllegalArgumentException"); + assertThrows(IllegalArgumentException.class, () -> AnytoAny.convertBase(5, 10, 11), "Destination base greater than 10 should throw IllegalArgumentException"); } @Test From 0d5ff61ead8ea9c578d3368ff8c1afba28c8b0be Mon Sep 17 00:00:00 2001 From: Hardvan Date: Sat, 26 Oct 2024 10:02:35 +0000 Subject: [PATCH 4/6] Update directory --- DIRECTORY.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/DIRECTORY.md b/DIRECTORY.md index 5a33f95c9f1c..bd045c8c3a35 100644 --- a/DIRECTORY.md +++ b/DIRECTORY.md @@ -320,6 +320,7 @@ * [BresenhamLine](https://github.com/TheAlgorithms/Java/blob/master/src/main/java/com/thealgorithms/geometry/BresenhamLine.java) * [ConvexHull](https://github.com/TheAlgorithms/Java/blob/master/src/main/java/com/thealgorithms/geometry/ConvexHull.java) * [GrahamScan](https://github.com/TheAlgorithms/Java/blob/master/src/main/java/com/thealgorithms/geometry/GrahamScan.java) + * [MidpointEllipse](https://github.com/TheAlgorithms/Java/blob/master/src/main/java/com/thealgorithms/geometry/MidpointEllipse.java) * [Point](https://github.com/TheAlgorithms/Java/blob/master/src/main/java/com/thealgorithms/geometry/Point.java) * graph * [StronglyConnectedComponentOptimized](https://github.com/TheAlgorithms/Java/blob/master/src/main/java/com/thealgorithms/graph/StronglyConnectedComponentOptimized.java) @@ -968,6 +969,7 @@ * [BresenhamLineTest](https://github.com/TheAlgorithms/Java/blob/master/src/test/java/com/thealgorithms/geometry/BresenhamLineTest.java) * [ConvexHullTest](https://github.com/TheAlgorithms/Java/blob/master/src/test/java/com/thealgorithms/geometry/ConvexHullTest.java) * [GrahamScanTest](https://github.com/TheAlgorithms/Java/blob/master/src/test/java/com/thealgorithms/geometry/GrahamScanTest.java) + * [MidpointEllipseTest](https://github.com/TheAlgorithms/Java/blob/master/src/test/java/com/thealgorithms/geometry/MidpointEllipseTest.java) * graph * [StronglyConnectedComponentOptimizedTest](https://github.com/TheAlgorithms/Java/blob/master/src/test/java/com/thealgorithms/graph/StronglyConnectedComponentOptimizedTest.java) * greedyalgorithms From fedaa9a04f9e369d5ba09052d4c9fb631163c57d Mon Sep 17 00:00:00 2001 From: siriak Date: Sat, 26 Oct 2024 11:55:18 +0000 Subject: [PATCH 5/6] Update directory --- DIRECTORY.md | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/DIRECTORY.md b/DIRECTORY.md index bd045c8c3a35..5cae420b23ac 100644 --- a/DIRECTORY.md +++ b/DIRECTORY.md @@ -320,6 +320,7 @@ * [BresenhamLine](https://github.com/TheAlgorithms/Java/blob/master/src/main/java/com/thealgorithms/geometry/BresenhamLine.java) * [ConvexHull](https://github.com/TheAlgorithms/Java/blob/master/src/main/java/com/thealgorithms/geometry/ConvexHull.java) * [GrahamScan](https://github.com/TheAlgorithms/Java/blob/master/src/main/java/com/thealgorithms/geometry/GrahamScan.java) + * [MidpointCircle](https://github.com/TheAlgorithms/Java/blob/master/src/main/java/com/thealgorithms/geometry/MidpointCircle.java) * [MidpointEllipse](https://github.com/TheAlgorithms/Java/blob/master/src/main/java/com/thealgorithms/geometry/MidpointEllipse.java) * [Point](https://github.com/TheAlgorithms/Java/blob/master/src/main/java/com/thealgorithms/geometry/Point.java) * graph @@ -361,6 +362,7 @@ * [Average](https://github.com/TheAlgorithms/Java/blob/master/src/main/java/com/thealgorithms/maths/Average.java) * [BinaryPow](https://github.com/TheAlgorithms/Java/blob/master/src/main/java/com/thealgorithms/maths/BinaryPow.java) * [BinomialCoefficient](https://github.com/TheAlgorithms/Java/blob/master/src/main/java/com/thealgorithms/maths/BinomialCoefficient.java) + * [CatalanNumbers](https://github.com/TheAlgorithms/Java/blob/master/src/main/java/com/thealgorithms/maths/CatalanNumbers.java) * [Ceil](https://github.com/TheAlgorithms/Java/blob/master/src/main/java/com/thealgorithms/maths/Ceil.java) * [ChineseRemainderTheorem](https://github.com/TheAlgorithms/Java/blob/master/src/main/java/com/thealgorithms/maths/ChineseRemainderTheorem.java) * [CircularConvolutionFFT](https://github.com/TheAlgorithms/Java/blob/master/src/main/java/com/thealgorithms/maths/CircularConvolutionFFT.java) @@ -969,6 +971,7 @@ * [BresenhamLineTest](https://github.com/TheAlgorithms/Java/blob/master/src/test/java/com/thealgorithms/geometry/BresenhamLineTest.java) * [ConvexHullTest](https://github.com/TheAlgorithms/Java/blob/master/src/test/java/com/thealgorithms/geometry/ConvexHullTest.java) * [GrahamScanTest](https://github.com/TheAlgorithms/Java/blob/master/src/test/java/com/thealgorithms/geometry/GrahamScanTest.java) + * [MidpointCircleTest](https://github.com/TheAlgorithms/Java/blob/master/src/test/java/com/thealgorithms/geometry/MidpointCircleTest.java) * [MidpointEllipseTest](https://github.com/TheAlgorithms/Java/blob/master/src/test/java/com/thealgorithms/geometry/MidpointEllipseTest.java) * graph * [StronglyConnectedComponentOptimizedTest](https://github.com/TheAlgorithms/Java/blob/master/src/test/java/com/thealgorithms/graph/StronglyConnectedComponentOptimizedTest.java) @@ -1006,6 +1009,7 @@ * [AverageTest](https://github.com/TheAlgorithms/Java/blob/master/src/test/java/com/thealgorithms/maths/AverageTest.java) * [BinaryPowTest](https://github.com/TheAlgorithms/Java/blob/master/src/test/java/com/thealgorithms/maths/BinaryPowTest.java) * [BinomialCoefficientTest](https://github.com/TheAlgorithms/Java/blob/master/src/test/java/com/thealgorithms/maths/BinomialCoefficientTest.java) + * [CatalanNumbersTest](https://github.com/TheAlgorithms/Java/blob/master/src/test/java/com/thealgorithms/maths/CatalanNumbersTest.java) * [CeilTest](https://github.com/TheAlgorithms/Java/blob/master/src/test/java/com/thealgorithms/maths/CeilTest.java) * [ChineseRemainderTheoremTest](https://github.com/TheAlgorithms/Java/blob/master/src/test/java/com/thealgorithms/maths/ChineseRemainderTheoremTest.java) * [CollatzConjectureTest](https://github.com/TheAlgorithms/Java/blob/master/src/test/java/com/thealgorithms/maths/CollatzConjectureTest.java) From 653630dc46127215450337d703593d6c2c895c32 Mon Sep 17 00:00:00 2001 From: Hardvan Date: Sat, 26 Oct 2024 15:02:37 +0000 Subject: [PATCH 6/6] Update directory --- DIRECTORY.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/DIRECTORY.md b/DIRECTORY.md index 6ec552dd438b..bb952a26c6e9 100644 --- a/DIRECTORY.md +++ b/DIRECTORY.md @@ -597,6 +597,7 @@ * slidingwindow * [LongestSubstringWithoutRepeatingCharacters](https://github.com/TheAlgorithms/Java/blob/master/src/main/java/com/thealgorithms/slidingwindow/LongestSubstringWithoutRepeatingCharacters.java) * [MaxSumKSizeSubarray](https://github.com/TheAlgorithms/Java/blob/master/src/main/java/com/thealgorithms/slidingwindow/MaxSumKSizeSubarray.java) + * [MinSumKSizeSubarray](https://github.com/TheAlgorithms/Java/blob/master/src/main/java/com/thealgorithms/slidingwindow/MinSumKSizeSubarray.java) * sorts * [AdaptiveMergeSort](https://github.com/TheAlgorithms/Java/blob/master/src/main/java/com/thealgorithms/sorts/AdaptiveMergeSort.java) * [BeadSort](https://github.com/TheAlgorithms/Java/blob/master/src/main/java/com/thealgorithms/sorts/BeadSort.java) @@ -1218,6 +1219,7 @@ * slidingwindow * [LongestSubstringWithoutRepeatingCharactersTest](https://github.com/TheAlgorithms/Java/blob/master/src/test/java/com/thealgorithms/slidingwindow/LongestSubstringWithoutRepeatingCharactersTest.java) * [MaxSumKSizeSubarrayTest](https://github.com/TheAlgorithms/Java/blob/master/src/test/java/com/thealgorithms/slidingwindow/MaxSumKSizeSubarrayTest.java) + * [MinSumKSizeSubarrayTest](https://github.com/TheAlgorithms/Java/blob/master/src/test/java/com/thealgorithms/slidingwindow/MinSumKSizeSubarrayTest.java) * sorts * [AdaptiveMergeSortTest](https://github.com/TheAlgorithms/Java/blob/master/src/test/java/com/thealgorithms/sorts/AdaptiveMergeSortTest.java) * [BeadSortTest](https://github.com/TheAlgorithms/Java/blob/master/src/test/java/com/thealgorithms/sorts/BeadSortTest.java)