diff --git a/src/main/java/com/thealgorithms/datastructures/graphs/Cycles.java b/src/main/java/com/thealgorithms/datastructures/graphs/Cycles.java index b67c5512e622..aea2b74bd13b 100644 --- a/src/main/java/com/thealgorithms/datastructures/graphs/Cycles.java +++ b/src/main/java/com/thealgorithms/datastructures/graphs/Cycles.java @@ -6,7 +6,6 @@ class Cycle { private final int nodes; - private final int edges; private int[][] adjacencyMatrix; private boolean[] visited; ArrayList> cycles = new ArrayList>(); @@ -16,7 +15,7 @@ class Cycle { System.out.print("Enter the no. of nodes: "); nodes = in.nextInt(); System.out.print("Enter the no. of Edges: "); - edges = in.nextInt(); + final int edges = in.nextInt(); adjacencyMatrix = new int[nodes][nodes]; visited = new boolean[nodes]; diff --git a/src/main/java/com/thealgorithms/others/CRCAlgorithm.java b/src/main/java/com/thealgorithms/others/CRCAlgorithm.java index bfa8828e250b..284a290a5af8 100644 --- a/src/main/java/com/thealgorithms/others/CRCAlgorithm.java +++ b/src/main/java/com/thealgorithms/others/CRCAlgorithm.java @@ -25,8 +25,6 @@ public class CRCAlgorithm { private ArrayList message; - private ArrayList dividedMessage; - private ArrayList p; private Random randomGenerator; @@ -44,7 +42,6 @@ public CRCAlgorithm(String str, int size, double ber) { messageChanged = false; message = new ArrayList<>(); messSize = size; - dividedMessage = new ArrayList<>(); p = new ArrayList<>(); for (int i = 0; i < str.length(); i++) { p.add(Character.getNumericValue(str.charAt(i))); @@ -103,7 +100,6 @@ public int getCorrectMess() { public void refactor() { messageChanged = false; message = new ArrayList<>(); - dividedMessage = new ArrayList<>(); } /** @@ -156,7 +152,7 @@ public void divideMessageWithP(boolean check) { } } } - dividedMessage = (ArrayList) x.clone(); + ArrayList dividedMessage = (ArrayList) x.clone(); if (!check) { message.addAll(dividedMessage); } else { diff --git a/src/main/java/com/thealgorithms/sorts/LinkListSort.java b/src/main/java/com/thealgorithms/sorts/LinkListSort.java index bf8910d94eae..800d78f36549 100644 --- a/src/main/java/com/thealgorithms/sorts/LinkListSort.java +++ b/src/main/java/com/thealgorithms/sorts/LinkListSort.java @@ -259,14 +259,12 @@ static int count(Node head) { class Task2 { - private int[] a; - public Node sortByHeapSort(Node head) { if (head == null || head.next == null) { return head; } int c = count(head); - a = new int[c]; + int[] a = new int[c]; // Array of size c is created int i = 0; for (Node ptr = head; ptr != null; ptr = ptr.next) { diff --git a/src/test/java/com/thealgorithms/ciphers/a5/A5CipherTest.java b/src/test/java/com/thealgorithms/ciphers/a5/A5CipherTest.java index aa725b644a86..011a1b521e31 100644 --- a/src/test/java/com/thealgorithms/ciphers/a5/A5CipherTest.java +++ b/src/test/java/com/thealgorithms/ciphers/a5/A5CipherTest.java @@ -9,14 +9,12 @@ public class A5CipherTest { private A5Cipher a5Cipher; - private BitSet sessionKey; - private BitSet frameCounter; @BeforeEach void setUp() { // Initialize the session key and frame counter - sessionKey = BitSet.valueOf(new long[] {0b1010101010101010L}); - frameCounter = BitSet.valueOf(new long[] {0b0000000000000001L}); + final var sessionKey = BitSet.valueOf(new long[] {0b1010101010101010L}); + final var frameCounter = BitSet.valueOf(new long[] {0b0000000000000001L}); a5Cipher = new A5Cipher(sessionKey, frameCounter); } diff --git a/src/test/java/com/thealgorithms/ciphers/a5/A5KeyStreamGeneratorTest.java b/src/test/java/com/thealgorithms/ciphers/a5/A5KeyStreamGeneratorTest.java index bb18d4500fc0..c9b721f90b2d 100644 --- a/src/test/java/com/thealgorithms/ciphers/a5/A5KeyStreamGeneratorTest.java +++ b/src/test/java/com/thealgorithms/ciphers/a5/A5KeyStreamGeneratorTest.java @@ -12,7 +12,6 @@ public class A5KeyStreamGeneratorTest { private A5KeyStreamGenerator keyStreamGenerator; - private BitSet sessionKey; private BitSet frameCounter; @BeforeEach @@ -20,7 +19,7 @@ void setUp() { keyStreamGenerator = new A5KeyStreamGenerator(); // Initialize session key and frame counter for testing - sessionKey = BitSet.valueOf(new long[] {0b1010101010101010L}); // Example 16-bit key + final var sessionKey = BitSet.valueOf(new long[] {0b1010101010101010L}); // Example 16-bit key frameCounter = BitSet.valueOf(new long[] {0b0000000000000001L}); // Example 16-bit frame counter keyStreamGenerator.initialize(sessionKey, frameCounter); }