From f80b6db4974c00d47c5218bebb66e3032cc1cbd9 Mon Sep 17 00:00:00 2001 From: Maria Paszkiewicz SCC Date: Wed, 1 May 2024 12:52:38 +0200 Subject: [PATCH 1/2] style: enable `ModifierOrder` in checkstyle --- checkstyle.xml | 2 +- .../java/com/thealgorithms/bitmanipulation/HighestSetBit.java | 2 +- src/main/java/com/thealgorithms/others/CountWords.java | 2 +- src/main/java/com/thealgorithms/others/EulersFunction.java | 2 +- .../java/com/thealgorithms/others/LowestBasePalindrome.java | 2 +- src/main/java/com/thealgorithms/others/SieveOfEratosthenes.java | 2 +- src/main/java/com/thealgorithms/others/cn/HammingDistance.java | 2 +- 7 files changed, 7 insertions(+), 7 deletions(-) diff --git a/checkstyle.xml b/checkstyle.xml index e4764fb1cc8a..d16549b6494b 100644 --- a/checkstyle.xml +++ b/checkstyle.xml @@ -147,7 +147,7 @@ - + diff --git a/src/main/java/com/thealgorithms/bitmanipulation/HighestSetBit.java b/src/main/java/com/thealgorithms/bitmanipulation/HighestSetBit.java index 398b6bbb67bb..a6a6f4915805 100644 --- a/src/main/java/com/thealgorithms/bitmanipulation/HighestSetBit.java +++ b/src/main/java/com/thealgorithms/bitmanipulation/HighestSetBit.java @@ -12,7 +12,7 @@ public final class HighestSetBit { private HighestSetBit() { } - public final static Optional findHighestSetBit(int num) { + public static final Optional findHighestSetBit(int num) { if (num < 0) { throw new IllegalArgumentException("Input cannot be negative"); } diff --git a/src/main/java/com/thealgorithms/others/CountWords.java b/src/main/java/com/thealgorithms/others/CountWords.java index 1defde2cdd8b..26b9c50d928c 100644 --- a/src/main/java/com/thealgorithms/others/CountWords.java +++ b/src/main/java/com/thealgorithms/others/CountWords.java @@ -3,7 +3,7 @@ /** * @author Marcus */ -final public class CountWords { +public final class CountWords { private CountWords() { } diff --git a/src/main/java/com/thealgorithms/others/EulersFunction.java b/src/main/java/com/thealgorithms/others/EulersFunction.java index 27c9aed8b620..f08e5e4fa395 100644 --- a/src/main/java/com/thealgorithms/others/EulersFunction.java +++ b/src/main/java/com/thealgorithms/others/EulersFunction.java @@ -3,7 +3,7 @@ /** * @brief utility class for Euler's totient function */ -final public class EulersFunction { +public final class EulersFunction { private EulersFunction() { } diff --git a/src/main/java/com/thealgorithms/others/LowestBasePalindrome.java b/src/main/java/com/thealgorithms/others/LowestBasePalindrome.java index 9bc02535a306..c8328a4ee552 100644 --- a/src/main/java/com/thealgorithms/others/LowestBasePalindrome.java +++ b/src/main/java/com/thealgorithms/others/LowestBasePalindrome.java @@ -6,7 +6,7 @@ * @brief Class for finding the lowest base in which a given integer is a palindrome. cf. https://oeis.org/A016026 */ -final public class LowestBasePalindrome { +public final class LowestBasePalindrome { private LowestBasePalindrome() { } diff --git a/src/main/java/com/thealgorithms/others/SieveOfEratosthenes.java b/src/main/java/com/thealgorithms/others/SieveOfEratosthenes.java index d7dcdbd11493..1fd9ae288920 100644 --- a/src/main/java/com/thealgorithms/others/SieveOfEratosthenes.java +++ b/src/main/java/com/thealgorithms/others/SieveOfEratosthenes.java @@ -5,7 +5,7 @@ /** * @brief utility class implementing Sieve of Eratosthenes */ -final public class SieveOfEratosthenes { +public final class SieveOfEratosthenes { private SieveOfEratosthenes() { } diff --git a/src/main/java/com/thealgorithms/others/cn/HammingDistance.java b/src/main/java/com/thealgorithms/others/cn/HammingDistance.java index 820917a17229..c8239d53d606 100644 --- a/src/main/java/com/thealgorithms/others/cn/HammingDistance.java +++ b/src/main/java/com/thealgorithms/others/cn/HammingDistance.java @@ -1,6 +1,6 @@ package com.thealgorithms.others.cn; -final public class HammingDistance { +public final class HammingDistance { private HammingDistance() { } From 5a5171a0737bae4ac8218a4121fd697eaec1f39a Mon Sep 17 00:00:00 2001 From: marysiuniq <67139391+marysiuniq@users.noreply.github.com> Date: Wed, 1 May 2024 13:01:33 +0200 Subject: [PATCH 2/2] style: remove redundant `final` Co-authored-by: Piotr Idzik <65706193+vil02@users.noreply.github.com> --- .../java/com/thealgorithms/bitmanipulation/HighestSetBit.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/main/java/com/thealgorithms/bitmanipulation/HighestSetBit.java b/src/main/java/com/thealgorithms/bitmanipulation/HighestSetBit.java index a6a6f4915805..6b53b1aa182b 100644 --- a/src/main/java/com/thealgorithms/bitmanipulation/HighestSetBit.java +++ b/src/main/java/com/thealgorithms/bitmanipulation/HighestSetBit.java @@ -12,7 +12,7 @@ public final class HighestSetBit { private HighestSetBit() { } - public static final Optional findHighestSetBit(int num) { + public static Optional findHighestSetBit(int num) { if (num < 0) { throw new IllegalArgumentException("Input cannot be negative"); }