Skip to content

Commit be2c2e7

Browse files
committed
Fix
1 parent c23b19e commit be2c2e7

File tree

2 files changed

+11
-8
lines changed

2 files changed

+11
-8
lines changed

src/main/java/com/thealgorithms/conversions/IPv6Converter.java

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
package com.thealgorithms.conversions;
22

3-
import java.net.Inet6Address;
43
import java.net.InetAddress;
54
import java.net.UnknownHostException;
65
import java.util.Arrays;
@@ -84,10 +83,14 @@ public static String ipv6ToIpv4(String ipv6Address) throws UnknownHostException
8483
private static boolean isValidIpv6MappedIpv4(byte[] ipv6Bytes) {
8584
// IPv6-mapped IPv4 addresses are 16 bytes long, with the first 10 bytes set to 0,
8685
// followed by 0xff, 0xff, and the last 4 bytes representing the IPv4 address.
87-
if (ipv6Bytes.length != 16) return false;
86+
if (ipv6Bytes.length != 16) {
87+
return false;
88+
}
8889

8990
for (int i = 0; i < 10; i++) {
90-
if (ipv6Bytes[i] != 0) return false;
91+
if (ipv6Bytes[i] != 0) {
92+
return false;
93+
}
9194
}
9295

9396
return ipv6Bytes[10] == (byte) 0xff && ipv6Bytes[11] == (byte) 0xff;

src/test/java/com/thealgorithms/conversions/IPv6ConverterTest.java

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -9,27 +9,27 @@
99
public class IPv6ConverterTest {
1010

1111
@Test
12-
public void testIpv4ToIpv6_ValidInput() throws UnknownHostException {
12+
public void testIpv4ToIpv6ValidInput() throws UnknownHostException {
1313
String ipv4 = getValidIpv4Address();
1414
String expectedIpv6 = getExpectedIpv6MappedAddress();
1515
String actualIpv6 = IPv6Converter.ipv4ToIpv6(ipv4);
1616
assertEquals(expectedIpv6, actualIpv6);
1717
}
1818

1919
@Test
20-
public void testIpv6ToIpv4_InvalidIPv6MappedAddress() {
20+
public void testIpv6ToIpv4InvalidIPv6MappedAddress() {
2121
String invalidIpv6 = getInvalidIpv6MappedAddress();
2222
assertThrows(IllegalArgumentException.class, () -> { IPv6Converter.ipv6ToIpv4(invalidIpv6); });
2323
}
2424

2525
@Test
26-
public void testIpv4ToIpv6_InvalidIPv4Address() {
26+
public void testIpv4ToIpv6InvalidIPv4Address() {
2727
String invalidIpv4 = getInvalidIpv4Address();
2828
assertThrows(UnknownHostException.class, () -> { IPv6Converter.ipv4ToIpv6(invalidIpv4); });
2929
}
3030

3131
@Test
32-
public void testIpv6ToIpv4_InvalidFormat() {
32+
public void testIpv6ToIpv4InvalidFormat() {
3333
String invalidIpv6 = getInvalidIpv6Format();
3434
assertThrows(UnknownHostException.class, () -> { IPv6Converter.ipv6ToIpv4(invalidIpv6); });
3535
}
@@ -41,7 +41,7 @@ public void testIpv4ToIpv6_EmptyString() {
4141
}
4242

4343
@Test
44-
public void testIpv6ToIpv4_EmptyString() {
44+
public void testIpv6ToIpv4EmptyString() {
4545
String emptyIpv6 = getEmptyString();
4646
assertThrows(IllegalArgumentException.class, () -> { IPv6Converter.ipv6ToIpv4(emptyIpv6); });
4747
}

0 commit comments

Comments
 (0)