Merge branch 'feature/improve_code_look' of https://github.com/rozi26/java_algo_fork1

rozi26 · rozi26 · commit b813d2d25be4 · 2024-05-02T15:53:25.000+03:00
diff --git a/.github/dependabot.yml b/.github/dependabot.yml
@@ -10,4 +10,9 @@ updates:
     directory: "/.github/workflows/"
     schedule:
       interval: "daily"
+
+  - package-ecosystem: "maven"
+    directory: "/"
+    schedule:
+      interval: "daily"
 ...
diff --git a/.gitpod.dockerfile b/.gitpod.dockerfile
@@ -1,4 +1,4 @@
-FROM gitpod/workspace-java-17:2024-04-16-12-16-24
+FROM gitpod/workspace-java-17:2024-04-29-23-03-42
 
 ENV LLVM_SCRIPT="tmp_llvm.sh"
 
diff --git a/checkstyle.xml b/checkstyle.xml
@@ -147,7 +147,7 @@
 
     <!-- Modifier Checks                                    -->
     <!-- See https://checkstyle.org/checks/modifier/index.html -->
-    <!-- TODO <module name="ModifierOrder"/> -->
+    <module name="ModifierOrder"/>
     <!-- TODO <module name="RedundantModifier"/> -->
 
     <!-- Checks for blocks. You know, those {}'s         -->
diff --git a/pom.xml b/pom.xml
@@ -71,7 +71,7 @@
             <plugin>
                 <groupId>org.apache.maven.plugins</groupId>
                 <artifactId>maven-compiler-plugin</artifactId>
-                <version>3.10.1</version>
+                <version>3.13.0</version>
                 <configuration>
                     <source>17</source>
                     <target>17</target>
@@ -110,7 +110,7 @@
                     <dependency>
                     <groupId>com.puppycrawl.tools</groupId>
                     <artifactId>checkstyle</artifactId>
-                    <version>9.3</version>
+                    <version>10.16.0</version>
                     </dependency>
                 </dependencies>
             </plugin>
diff --git a/spotbugs-exclude.xml b/spotbugs-exclude.xml
@@ -8,9 +8,6 @@
     <Match>
         <Bug pattern="ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD" />
     </Match>
-    <Match>
-        <Bug pattern="IM_AVERAGE_COMPUTATION_COULD_OVERFLOW" />
-    </Match>
     <Match>
         <Bug pattern="DMI_RANDOM_USED_ONLY_ONCE" />
     </Match>
@@ -20,9 +17,6 @@
     <Match>
         <Bug pattern="SF_SWITCH_NO_DEFAULT" />
     </Match>
-    <Match>
-        <Bug pattern="UC_USELESS_OBJECT" />
-    </Match>
     <Match>
         <Bug pattern="RV_RETURN_VALUE_IGNORED_NO_SIDE_EFFECT" />
     </Match>
diff --git a/src/main/java/com/thealgorithms/bitmanipulation/HighestSetBit.java b/src/main/java/com/thealgorithms/bitmanipulation/HighestSetBit.java
@@ -12,7 +12,7 @@ public final class HighestSetBit {
     private HighestSetBit() {
     }
 
-    public final static Optional<Integer> findHighestSetBit(int num) {
+    public static Optional<Integer> findHighestSetBit(int num) {
         if (num < 0) {
             throw new IllegalArgumentException("Input cannot be negative");
         }
diff --git a/src/main/java/com/thealgorithms/dynamicprogramming/LongestIncreasingSubsequence.java b/src/main/java/com/thealgorithms/dynamicprogramming/LongestIncreasingSubsequence.java
@@ -97,7 +97,7 @@ private static int binarySearchBetween(int[] t, int end, int key) {
             return end + 1;
         }
         while (left < right - 1) {
-            int middle = (left + right) / 2;
+            final int middle = (left + right) >>> 1;
             if (t[middle] < key) {
                 left = middle;
             } else {
diff --git a/src/main/java/com/thealgorithms/misc/RangeInSortedArray.java b/src/main/java/com/thealgorithms/misc/RangeInSortedArray.java
@@ -26,7 +26,7 @@ public static void alteredBinSearch(int[] nums, int key, int left, int right, in
         if (left > right) {
             return;
         }
-        int mid = (left + right) / 2;
+        int mid = (left + right) >>> 1;
         if (nums[mid] > key) {
             alteredBinSearch(nums, key, left, mid - 1, range, goLeft);
         } else if (nums[mid] < key) {
@@ -52,7 +52,7 @@ public static void alteredBinSearch(int[] nums, int key, int left, int right, in
     // of 'key'
     public static void alteredBinSearchIter(int[] nums, int key, int left, int right, int[] range, boolean goLeft) {
         while (left <= right) {
-            int mid = (left + right) / 2;
+            final int mid = (left + right) >>> 1;
             if (nums[mid] > key) {
                 right = mid - 1;
             } else if (nums[mid] < key) {
@@ -84,7 +84,7 @@ public static int getCountLessThan(int[] nums, int key) {
     public static int getLessThan(int[] nums, int key, int left, int right) {
         int count = 0;
         while (left <= right) {
-            int mid = (left + right) / 2;
+            final int mid = (left + right) >>> 1;
             if (nums[mid] > key) {
                 right = mid - 1;
             } else if (nums[mid] <= key) {
diff --git a/src/main/java/com/thealgorithms/others/CountWords.java b/src/main/java/com/thealgorithms/others/CountWords.java
@@ -3,7 +3,7 @@
 /**
  * @author Marcus
  */
-final public class CountWords {
+public final class CountWords {
     private CountWords() {
     }
 
diff --git a/src/main/java/com/thealgorithms/others/EulersFunction.java b/src/main/java/com/thealgorithms/others/EulersFunction.java
@@ -3,7 +3,7 @@
 /**
  * @brief utility class for <a href="https://en.wikipedia.org/wiki/Euler%27s_totient_function">Euler's totient function</a>
  */
-final public class EulersFunction {
+public final class EulersFunction {
     private EulersFunction() {
     }
 
diff --git a/src/main/java/com/thealgorithms/others/LowestBasePalindrome.java b/src/main/java/com/thealgorithms/others/LowestBasePalindrome.java
@@ -6,7 +6,7 @@
  * @brief Class for finding the lowest base in which a given integer is a palindrome.
      cf. https://oeis.org/A016026
  */
-final public class LowestBasePalindrome {
+public final class LowestBasePalindrome {
     private LowestBasePalindrome() {
     }
 
diff --git a/src/main/java/com/thealgorithms/others/SieveOfEratosthenes.java b/src/main/java/com/thealgorithms/others/SieveOfEratosthenes.java
@@ -5,7 +5,7 @@
 /**
  * @brief utility class implementing <a href="https://en.wikipedia.org/wiki/Sieve_of_Eratosthenes">Sieve of Eratosthenes</a>
  */
-final public class SieveOfEratosthenes {
+public final class SieveOfEratosthenes {
     private SieveOfEratosthenes() {
     }
 
diff --git a/src/main/java/com/thealgorithms/others/cn/HammingDistance.java b/src/main/java/com/thealgorithms/others/cn/HammingDistance.java
@@ -1,6 +1,6 @@
 package com.thealgorithms.others.cn;
 
-final public class HammingDistance {
+public final class HammingDistance {
     private HammingDistance() {
     }
 
diff --git a/src/main/java/com/thealgorithms/sorts/BinaryInsertionSort.java b/src/main/java/com/thealgorithms/sorts/BinaryInsertionSort.java
@@ -10,7 +10,7 @@ public int[] binaryInsertSort(int[] array) {
             int high = i - 1;
 
             while (low <= high) {
-                int mid = (low + high) / 2;
+                final int mid = (low + high) >>> 1;
                 if (temp < array[mid]) {
                     high = mid - 1;
                 } else {
diff --git a/src/main/java/com/thealgorithms/sorts/MergeSortRecursive.java b/src/main/java/com/thealgorithms/sorts/MergeSortRecursive.java
@@ -1,7 +1,6 @@
 package com.thealgorithms.sorts;
 
 import java.util.ArrayList;
-import java.util.Arrays;
 import java.util.List;
 
 public class MergeSortRecursive {
@@ -59,11 +58,3 @@ private static List<Integer> sort(List<Integer> unsortedA, List<Integer> unsorte
         }
     }
 }
-
-class App {
-
-    public static void main(String[] args) {
-        MergeSortRecursive sort = new MergeSortRecursive(new ArrayList<>(Arrays.asList(4, 3, 1, 8, 5, 10, 0, 1, 4, 11, 8, 9)));
-        sort.mergeSort();
-    }
-}
diff --git a/src/main/java/com/thealgorithms/sorts/SlowSort.java b/src/main/java/com/thealgorithms/sorts/SlowSort.java
@@ -16,7 +16,7 @@ private <T extends Comparable<T>> void sort(T[] array, int i, int j) {
         if (SortUtils.greaterOrEqual(i, j)) {
             return;
         }
-        int m = (i + j) / 2;
+        final int m = (i + j) >>> 1;
         sort(array, i, m);
         sort(array, m + 1, j);
         if (SortUtils.less(array[j], array[m])) {

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-FROM gitpod/workspace-java-17:2024-04-16-12-16-24`
	`1`	`+FROM gitpod/workspace-java-17:2024-04-29-23-03-42`
`2`	`2`
`3`	`3`	`ENV LLVM_SCRIPT="tmp_llvm.sh"`
`4`	`4`
Original file line number	Diff line number	Diff line change
`@@ -12,7 +12,7 @@ public final class HighestSetBit {`
`12`	`12`	`private HighestSetBit() {`
`13`	`13`	`}`
`14`	`14`
`15`		`- public final static Optional<Integer> findHighestSetBit(int num) {`
	`15`	`+ public static Optional<Integer> findHighestSetBit(int num) {`
`16`	`16`	`if (num < 0) {`
`17`	`17`	`throw new IllegalArgumentException("Input cannot be negative");`
`18`	`18`	`}`
Original file line number	Diff line number	Diff line change
`@@ -97,7 +97,7 @@ private static int binarySearchBetween(int[] t, int end, int key) {`
`97`	`97`	`return end + 1;`
`98`	`98`	`}`
`99`	`99`	`while (left < right - 1) {`
`100`		`- int middle = (left + right) / 2;`
	`100`	`+ final int middle = (left + right) >>> 1;`
`101`	`101`	`if (t[middle] < key) {`
`102`	`102`	`left = middle;`
`103`	`103`	`} else {`
Original file line number	Diff line number	Diff line change
`@@ -3,7 +3,7 @@`
`3`	`3`	`/**`
`4`	`4`	`* @author Marcus`
`5`	`5`	`*/`
`6`		`-final public class CountWords {`
	`6`	`+public final class CountWords {`
`7`	`7`	`private CountWords() {`
`8`	`8`	`}`
`9`	`9`
Original file line number	Diff line number	Diff line change
`@@ -3,7 +3,7 @@`
`3`	`3`	`/**`
`4`	`4`	`* @brief utility class for <a href="https://en.wikipedia.org/wiki/Euler%27s_totient_function">Euler's totient function</a>`
`5`	`5`	`*/`
`6`		`-final public class EulersFunction {`
	`6`	`+public final class EulersFunction {`
`7`	`7`	`private EulersFunction() {`
`8`	`8`	`}`
`9`	`9`
Original file line number	Diff line number	Diff line change
`@@ -6,7 +6,7 @@`
`6`	`6`	`* @brief Class for finding the lowest base in which a given integer is a palindrome.`
`7`	`7`	`cf. https://oeis.org/A016026`
`8`	`8`	`*/`
`9`		`-final public class LowestBasePalindrome {`
	`9`	`+public final class LowestBasePalindrome {`
`10`	`10`	`private LowestBasePalindrome() {`
`11`	`11`	`}`
`12`	`12`
Original file line number	Diff line number	Diff line change
`@@ -5,7 +5,7 @@`
`5`	`5`	`/**`
`6`	`6`	`* @brief utility class implementing <a href="https://en.wikipedia.org/wiki/Sieve_of_Eratosthenes">Sieve of Eratosthenes</a>`
`7`	`7`	`*/`
`8`		`-final public class SieveOfEratosthenes {`
	`8`	`+public final class SieveOfEratosthenes {`
`9`	`9`	`private SieveOfEratosthenes() {`
`10`	`10`	`}`
`11`	`11`
Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,6 @@`
`1`	`1`	`package com.thealgorithms.others.cn;`
`2`	`2`
`3`		`-final public class HammingDistance {`
	`3`	`+public final class HammingDistance {`
`4`	`4`	`private HammingDistance() {`
`5`	`5`	`}`
`6`	`6`
Original file line number	Diff line number	Diff line change
`@@ -1,7 +1,6 @@`
`1`	`1`	`package com.thealgorithms.sorts;`
`2`	`2`
`3`	`3`	`import java.util.ArrayList;`
`4`		`-import java.util.Arrays;`
`5`	`4`	`import java.util.List;`
`6`	`5`
`7`	`6`	`public class MergeSortRecursive {`
`@@ -59,11 +58,3 @@ private static List<Integer> sort(List<Integer> unsortedA, List<Integer> unsorte`
`59`	`58`	`}`
`60`	`59`	`}`
`61`	`60`	`}`
`62`		`-`
`63`		`-class App {`
`64`		`-`
`65`		`- public static void main(String[] args) {`
`66`		`- MergeSortRecursive sort = new MergeSortRecursive(new ArrayList<>(Arrays.asList(4, 3, 1, 8, 5, 10, 0, 1, 4, 11, 8, 9)));`
`67`		`- sort.mergeSort();`
`68`		`- }`
`69`		`-}`
Original file line number	Diff line number	Diff line change
`@@ -16,7 +16,7 @@ private <T extends Comparable<T>> void sort(T[] array, int i, int j) {`
`16`	`16`	`if (SortUtils.greaterOrEqual(i, j)) {`
`17`	`17`	`return;`
`18`	`18`	`}`
`19`		`- int m = (i + j) / 2;`
	`19`	`+ final int m = (i + j) >>> 1;`
`20`	`20`	`sort(array, i, m);`
`21`	`21`	`sort(array, m + 1, j);`
`22`	`22`	`if (SortUtils.less(array[j], array[m])) {`