Skip to content

Commit 9eff71b

Browse files
authored
Add tests for ConvolutionFFT (#5767)
1 parent f1aceea commit 9eff71b

File tree

3 files changed

+64
-0
lines changed

3 files changed

+64
-0
lines changed

DIRECTORY.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -938,6 +938,7 @@
938938
* [CeilTest](https://github.com/TheAlgorithms/Java/blob/master/src/test/java/com/thealgorithms/maths/CeilTest.java)
939939
* [CollatzConjectureTest](https://github.com/TheAlgorithms/Java/blob/master/src/test/java/com/thealgorithms/maths/CollatzConjectureTest.java)
940940
* [CombinationsTest](https://github.com/TheAlgorithms/Java/blob/master/src/test/java/com/thealgorithms/maths/CombinationsTest.java)
941+
* [ConvolutionFFTTest](https://github.com/TheAlgorithms/Java/blob/master/src/test/java/com/thealgorithms/maths/ConvolutionFFTTest.java)
941942
* [ConvolutionTest](https://github.com/TheAlgorithms/Java/blob/master/src/test/java/com/thealgorithms/maths/ConvolutionTest.java)
942943
* [CrossCorrelationTest](https://github.com/TheAlgorithms/Java/blob/master/src/test/java/com/thealgorithms/maths/CrossCorrelationTest.java)
943944
* [DeterminantOfMatrixTest](https://github.com/TheAlgorithms/Java/blob/master/src/test/java/com/thealgorithms/maths/DeterminantOfMatrixTest.java)

src/main/java/com/thealgorithms/maths/FFT.java

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -165,6 +165,14 @@ public Complex divide(double n) {
165165
temp.img = this.img / n;
166166
return temp;
167167
}
168+
169+
public double real() {
170+
return real;
171+
}
172+
173+
public double imaginary() {
174+
return img;
175+
}
168176
}
169177

170178
/**
Lines changed: 55 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,55 @@
1+
package com.thealgorithms.maths;
2+
3+
import static org.junit.jupiter.api.Assertions.assertEquals;
4+
5+
import java.util.ArrayList;
6+
import java.util.List;
7+
import java.util.stream.Stream;
8+
import org.junit.jupiter.params.ParameterizedTest;
9+
import org.junit.jupiter.params.provider.Arguments;
10+
import org.junit.jupiter.params.provider.MethodSource;
11+
12+
public class ConvolutionFFTTest {
13+
14+
/**
15+
* Helper method to create a complex signal from an array of doubles.
16+
*/
17+
private ArrayList<FFT.Complex> createComplexSignal(double[] values) {
18+
ArrayList<FFT.Complex> signal = new ArrayList<>();
19+
for (double value : values) {
20+
signal.add(new FFT.Complex(value, 0));
21+
}
22+
return signal;
23+
}
24+
25+
/**
26+
* Helper method to compare two complex signals for equality within a small margin of error.
27+
*/
28+
private void assertComplexArrayEquals(List<FFT.Complex> expected, List<FFT.Complex> result, double delta) {
29+
assertEquals(expected.size(), result.size(), "Signal lengths are not equal.");
30+
for (int i = 0; i < expected.size(); i++) {
31+
FFT.Complex expectedValue = expected.get(i);
32+
FFT.Complex resultValue = result.get(i);
33+
assertEquals(expectedValue.real(), resultValue.real(), delta, "Real part mismatch at index " + i);
34+
assertEquals(expectedValue.imaginary(), resultValue.imaginary(), delta, "Imaginary part mismatch at index " + i);
35+
}
36+
}
37+
38+
@ParameterizedTest(name = "Test case {index}: {3}")
39+
@MethodSource("provideTestCases")
40+
public void testConvolutionFFT(double[] a, double[] b, double[] expectedOutput, String testDescription) {
41+
ArrayList<FFT.Complex> signalA = createComplexSignal(a);
42+
ArrayList<FFT.Complex> signalB = createComplexSignal(b);
43+
44+
ArrayList<FFT.Complex> expected = createComplexSignal(expectedOutput);
45+
ArrayList<FFT.Complex> result = ConvolutionFFT.convolutionFFT(signalA, signalB);
46+
47+
assertComplexArrayEquals(expected, result, 1e-9); // Allow small margin of error
48+
}
49+
50+
private static Stream<Arguments> provideTestCases() {
51+
return Stream.of(Arguments.of(new double[] {1, 2, 3}, new double[] {4, 5, 6}, new double[] {4, 13, 28, 27, 18}, "Basic test"), Arguments.of(new double[] {0, 0, 0}, new double[] {1, 2, 3}, new double[] {0, 0, 0, 0, 0}, "Test with zero elements"),
52+
Arguments.of(new double[] {1, 2}, new double[] {3, 4, 5}, new double[] {3, 10, 13, 10}, "Test with different sizes"), Arguments.of(new double[] {5}, new double[] {2}, new double[] {10}, "Test with single element"),
53+
Arguments.of(new double[] {1, -2, 3}, new double[] {-1, 2, -3}, new double[] {-1, 4, -10, 12, -9}, "Test with negative values"));
54+
}
55+
}

0 commit comments

Comments
 (0)