adds new test for testing encoding and compressing email.

Author: ali4j

src/main/java/com/designpatterns/structural/decorator/CompressingDecorator.java

@@ -16,22 +16,20 @@ public CompressingDecorator(Sender sender) {
 
     @Override
     public String send(String content) {
-        String compressedContent = new String(compressContent(content));
+        byte[] compressedBytes = compressContent(content);
+        String compressedContent = new String(compressedBytes);
         super.send(compressedContent);
         return compressedContent;
     }
 
     private byte[] compressContent(String content) {
-        try{
-            ByteArrayOutputStream baostream = new ByteArrayOutputStream();
-            OutputStream outStream = new GZIPOutputStream(baostream);
-            outStream.write(content.getBytes("UTF-8"));
+        try (ByteArrayOutputStream baostream = new ByteArrayOutputStream();
+             OutputStream outStream = new GZIPOutputStream(baostream)){
+            outStream.write(content.getBytes());
             outStream.close();
-            byte[] compressedBytes = baostream.toByteArray(); // toString not always possible
-            return compressedBytes;
+            return baostream.toByteArray();
         } catch (IOException e) {
             throw new RuntimeException("exception happened while compressing email content");
-
         }
     }
 

src/test/java/com/designpatterns/decorator/DecoratorDemo.java

@@ -1,9 +1,6 @@
 package com.designpatterns.decorator;
 
-import com.designpatterns.structural.decorator.EmailSender;
-import com.designpatterns.structural.decorator.EncodingDecorator;
-import com.designpatterns.structural.decorator.Sender;
-import com.designpatterns.structural.decorator.SenderDecorator;
+import com.designpatterns.structural.decorator.*;
 import org.junit.jupiter.api.Assertions;
 import org.junit.jupiter.api.Test;
 
@@ -16,28 +13,50 @@ public void testDecorator_sendEmailAsPlainText() {
         String message = "test message";
         EmailSender sender = new EmailSender();
         String content = sender.send(message);
-
         Assertions.assertEquals(content, message);
-
     }
 
     @Test
-    public void testDecorator_sendEmailAsEncodedTest() {
+    public void testDecorator_sendEmailAsEncodedText() {
         String message = "test message";
         Sender sender = new SenderDecorator(
                 new EncodingDecorator(
                         new EmailSender()
                 )
         );
-
         String encodedContent = sender.send(message);
-
         Assertions.assertEquals(
                 new String(Base64.getDecoder().decode (encodedContent)),
                 message
         );
+    }
 
+    @Test
+    public void testDecorator_sendEmailAsCompressedText()  {
+        String message = "Java is a general-purpose programming language that is class-based, object-oriented, and designed to have as few implementation dependencies as possible. It is intended to let application developers write once, run anywhere (WORA),[15] meaning that compiled Java code can run on all platforms that support Java without the need for recompilation.[16] Java applications are typically compiled to bytecode that can run on any Java virtual machine (JVM) regardless of the underlying computer architecture. The syntax of Java is similar to C and C++, but it has fewer low-level facilities than either of them. As of 2019, Java was one of the most popular programming languages in use according to GitHub,[17][18] particularly for client-server web applications, with a reported 9 million developers.";
+        Sender sender = new SenderDecorator(
+                new CompressingDecorator(
+                        new EmailSender()
+                )
+        );
+        String compressedContent = sender.send(message);
+        Assertions.assertTrue(message.length()>= compressedContent.length());
+    }
+
+    @Test
+    public void testDecorator_sendEmailAsEncodedCompressedText()  {
+        String message = "Java is a general-purpose programming language that is class-based, object-oriented, and designed to have as few implementation dependencies as possible. It is intended to let application developers write once, run anywhere (WORA),[15] meaning that compiled Java code can run on all platforms that support Java without the need for recompilation.[16] Java applications are typically compiled to bytecode that can run on any Java virtual machine (JVM) regardless of the underlying computer architecture. The syntax of Java is similar to C and C++, but it has fewer low-level facilities than either of them. As of 2019, Java was one of the most popular programming languages in use according to GitHub,[17][18] particularly for client-server web applications, with a reported 9 million developers.";
+        Sender sender = new SenderDecorator(
+                new EncodingDecorator(
+                        new CompressingDecorator(
+                                new EmailSender()
+                        )
+                )
 
+        );
+        String encodedCompressedContent = sender.send(message);
 
+        String decodedCompressed = new String( Base64.getDecoder().decode (encodedCompressedContent));
+        Assertions.assertTrue(message.length()>= decodedCompressed.length());
     }
 }