Skip to content

Commit 73df2f8

Browse files
committed
Fix
1 parent 5a878b4 commit 73df2f8

File tree

1 file changed

+13
-6
lines changed

1 file changed

+13
-6
lines changed

src/test/java/com/thealgorithms/conversions/IPConverterTest.java

Lines changed: 13 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -6,17 +6,24 @@
66

77
public class IPConverterTest {
88

9+
private static final String IP_1 = "192.168.1.1";
10+
private static final String IP_1_BINARY = "11000000.10101000.00000001.00000001";
11+
private static final String IP_2 = "127.3.4.5";
12+
private static final String IP_2_BINARY = "01111111.00000011.00000100.00000101";
13+
private static final String IP_3 = "0.0.0.0";
14+
private static final String IP_3_BINARY = "00000000.00000000.00000000.00000000";
15+
916
@Test
1017
public void testIpToBinary() {
11-
assertEquals("11000000.10101000.00000001.00000001", IPConverter.ipToBinary("192.168.1.1"));
12-
assertEquals("01111111.00000011.00000100.00000101", IPConverter.ipToBinary("127.3.4.5"));
13-
assertEquals("00000000.00000000.00000000.00000000", IPConverter.ipToBinary("0.0.0.0"));
18+
assertEquals(IP_1_BINARY, IPConverter.ipToBinary(IP_1));
19+
assertEquals(IP_2_BINARY, IPConverter.ipToBinary(IP_2));
20+
assertEquals(IP_3_BINARY, IPConverter.ipToBinary(IP_3));
1421
}
1522

1623
@Test
1724
public void testBinaryToIP() {
18-
assertEquals("192.168.1.1", IPConverter.binaryToIP("11000000.10101000.00000001.00000001"));
19-
assertEquals("127.3.4.5", IPConverter.binaryToIP("01111111.00000011.00000100.00000101"));
20-
assertEquals("0.0.0.0", IPConverter.binaryToIP("00000000.00000000.00000000.00000000"));
25+
assertEquals(IP_1, IPConverter.binaryToIP(IP_1_BINARY));
26+
assertEquals(IP_2, IPConverter.binaryToIP(IP_2_BINARY));
27+
assertEquals(IP_3, IPConverter.binaryToIP(IP_3_BINARY));
2128
}
2229
}

0 commit comments

Comments
 (0)