Merge branch 'master' into baconian-cipher

Author: siriak

.github/workflows/build.yml

@@ -10,7 +10,7 @@ jobs:
         uses: actions/setup-java@v4
         with:
           java-version: 21
-          distribution: 'adopt'
+          distribution: 'temurin'
       - name: Build with Maven
         run: mvn --batch-mode --update-snapshots verify
       - name: Upload coverage to codecov (tokenless)

.github/workflows/codeql.yml

@@ -30,7 +30,7 @@ jobs:
         uses: actions/setup-java@v4
         with:
           java-version: 21
-          distribution: 'adopt'
+          distribution: 'temurin'
 
       - name: Initialize CodeQL
         uses: github/codeql-action/init@v3

.github/workflows/infer.yml

@@ -18,7 +18,7 @@ jobs:
         uses: actions/setup-java@v4
         with:
           java-version: 21
-          distribution: 'adopt'
+          distribution: 'temurin'
 
       - name: Set up OCaml
         uses: ocaml/setup-ocaml@v3

DIRECTORY.md

@@ -183,7 +183,7 @@
     <!-- See https://checkstyle.org/checks/misc/index.html -->
     <module name="ArrayTypeStyle"/>
     <!-- TODO <module name="FinalParameters"/> -->
-    <!-- TODO <module name="TodoComment"/> -->
+    <module name="TodoComment"/>
     <module name="UpperEll"/>
 
     <!-- https://checkstyle.org/filters/suppressionxpathfilter.html -->

checkstyle.xml

@@ -20,7 +20,7 @@
             <dependency>
                 <groupId>org.junit</groupId>
                 <artifactId>junit-bom</artifactId>
-                <version>5.11.2</version>
+                <version>5.11.3</version>
                 <type>pom</type>
                 <scope>import</scope>
             </dependency>
@@ -31,7 +31,7 @@
         <dependency>
             <groupId>org.junit.jupiter</groupId>
             <artifactId>junit-jupiter</artifactId>
-            <version>5.11.2</version>
+            <version>5.11.3</version>
             <scope>test</scope>
         </dependency>
         <dependency>
@@ -40,11 +40,18 @@
             <version>${assertj.version}</version>
             <scope>test</scope>
         </dependency>
+        <dependency>
+            <groupId>org.mockito</groupId>
+            <artifactId>mockito-core</artifactId>
+            <version>5.14.2</version>
+            <scope>test</scope>
+        </dependency>
+
 
         <dependency>
             <groupId>org.junit.jupiter</groupId>
             <artifactId>junit-jupiter-api</artifactId>
-            <version>5.11.2</version>
+            <version>5.11.3</version>
             <scope>test</scope>
         </dependency>
         <dependency>
@@ -63,7 +70,7 @@
         <plugins>
             <plugin>
                 <artifactId>maven-surefire-plugin</artifactId>
-                <version>3.5.0</version>
+                <version>3.5.1</version>
                 <configuration>
                     <forkNode implementation="org.apache.maven.plugin.surefire.extensions.SurefireForkNodeFactory"/>
                 </configuration>
@@ -125,7 +132,7 @@
             <plugin>
                 <groupId>com.github.spotbugs</groupId>
                 <artifactId>spotbugs-maven-plugin</artifactId>
-                <version>4.8.6.4</version>
+                <version>4.8.6.5</version>
                 <configuration>
                     <excludeFilterFile>spotbugs-exclude.xml</excludeFilterFile>
                     <includeTests>true</includeTests>

pom.xml

@@ -87,9 +87,6 @@
         <Bug pattern="RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE" />
     </Match>
     <!-- fb-contrib -->
-    <Match>
-        <Bug pattern="OCP_OVERLY_CONCRETE_PARAMETER" />
-    </Match>
     <Match>
         <Bug pattern="LSC_LITERAL_STRING_COMPARISON" />
     </Match>

spotbugs-exclude.xml

@@ -4,32 +4,44 @@
 import java.util.List;
 
 /**
- * Finds all combinations of 0...n-1 of length k
+ * This class provides methods to find all combinations of integers from 0 to n-1
+ * of a specified length k using backtracking.
  */
 public final class ArrayCombination {
     private ArrayCombination() {
     }
 
     /**
-     * Finds all combinations of length k of 0..n-1 using backtracking.
+     * Generates all possible combinations of length k from the integers 0 to n-1.
      *
-     * @param n Number of the elements.
-     * @param k Length of the combination.
-     * @return A list of all combinations of length k.
+     * @param n The total number of elements (0 to n-1).
+     * @param k The desired length of each combination.
+     * @return A list containing all combinations of length k.
+     * @throws IllegalArgumentException if n or k are negative, or if k is greater than n.
      */
     public static List<List<Integer>> combination(int n, int k) {
         if (n < 0 || k < 0 || k > n) {
-            throw new IllegalArgumentException("Wrong input.");
+            throw new IllegalArgumentException("Invalid input: n must be non-negative, k must be non-negative and less than or equal to n.");
         }
 
         List<List<Integer>> combinations = new ArrayList<>();
         combine(combinations, new ArrayList<>(), 0, n, k);
         return combinations;
     }
 
+    /**
+     * A helper method that uses backtracking to find combinations.
+     *
+     * @param combinations The list to store all valid combinations found.
+     * @param current The current combination being built.
+     * @param start The starting index for the current recursion.
+     * @param n The total number of elements (0 to n-1).
+     * @param k The desired length of each combination.
+     */
     private static void combine(List<List<Integer>> combinations, List<Integer> current, int start, int n, int k) {
-        if (current.size() == k) { // Base case: combination found
-            combinations.add(new ArrayList<>(current)); // Copy to avoid modification
+        // Base case: combination found
+        if (current.size() == k) {
+            combinations.add(new ArrayList<>(current));
             return;
         }
 

src/main/java/com/thealgorithms/backtracking/ArrayCombination.java

@@ -0,0 +1,125 @@
+package com.thealgorithms.backtracking;
+
+import java.util.ArrayList;
+import java.util.Collection;
+import java.util.List;
+
+/**
+ * A class to solve a crossword puzzle using backtracking.
+ * Example:
+ * Input:
+ *  puzzle = {
+ *      {' ', ' ', ' '},
+ *      {' ', ' ', ' '},
+ *      {' ', ' ', ' '}
+ *  }
+ *  words = List.of("cat", "dog")
+ *
+ * Output:
+ *  {
+ *      {'c', 'a', 't'},
+ *      {' ', ' ', ' '},
+ *      {'d', 'o', 'g'}
+ *  }
+ */
+public final class CrosswordSolver {
+    private CrosswordSolver() {
+    }
+
+    /**
+     * Checks if a word can be placed at the specified position in the crossword.
+     *
+     * @param puzzle   The crossword puzzle represented as a 2D char array.
+     * @param word     The word to be placed.
+     * @param row      The row index where the word might be placed.
+     * @param col      The column index where the word might be placed.
+     * @param vertical If true, the word is placed vertically; otherwise, horizontally.
+     * @return true if the word can be placed, false otherwise.
+     */
+    public static boolean isValid(char[][] puzzle, String word, int row, int col, boolean vertical) {
+        for (int i = 0; i < word.length(); i++) {
+            if (vertical) {
+                if (row + i >= puzzle.length || puzzle[row + i][col] != ' ') {
+                    return false;
+                }
+            } else {
+                if (col + i >= puzzle[0].length || puzzle[row][col + i] != ' ') {
+                    return false;
+                }
+            }
+        }
+        return true;
+    }
+
+    /**
+     * Places a word at the specified position in the crossword.
+     *
+     * @param puzzle   The crossword puzzle represented as a 2D char array.
+     * @param word     The word to be placed.
+     * @param row      The row index where the word will be placed.
+     * @param col      The column index where the word will be placed.
+     * @param vertical If true, the word is placed vertically; otherwise, horizontally.
+     */
+    public static void placeWord(char[][] puzzle, String word, int row, int col, boolean vertical) {
+        for (int i = 0; i < word.length(); i++) {
+            if (vertical) {
+                puzzle[row + i][col] = word.charAt(i);
+            } else {
+                puzzle[row][col + i] = word.charAt(i);
+            }
+        }
+    }
+
+    /**
+     * Removes a word from the specified position in the crossword.
+     *
+     * @param puzzle   The crossword puzzle represented as a 2D char array.
+     * @param word     The word to be removed.
+     * @param row      The row index where the word is placed.
+     * @param col      The column index where the word is placed.
+     * @param vertical If true, the word was placed vertically; otherwise, horizontally.
+     */
+    public static void removeWord(char[][] puzzle, String word, int row, int col, boolean vertical) {
+        for (int i = 0; i < word.length(); i++) {
+            if (vertical) {
+                puzzle[row + i][col] = ' ';
+            } else {
+                puzzle[row][col + i] = ' ';
+            }
+        }
+    }
+
+    /**
+     * Solves the crossword puzzle using backtracking.
+     *
+     * @param puzzle The crossword puzzle represented as a 2D char array.
+     * @param words  The list of words to be placed.
+     * @return true if the crossword is solved, false otherwise.
+     */
+    public static boolean solveCrossword(char[][] puzzle, Collection<String> words) {
+        // Create a mutable copy of the words list
+        List<String> remainingWords = new ArrayList<>(words);
+
+        for (int row = 0; row < puzzle.length; row++) {
+            for (int col = 0; col < puzzle[0].length; col++) {
+                if (puzzle[row][col] == ' ') {
+                    for (String word : new ArrayList<>(remainingWords)) {
+                        for (boolean vertical : new boolean[] {true, false}) {
+                            if (isValid(puzzle, word, row, col, vertical)) {
+                                placeWord(puzzle, word, row, col, vertical);
+                                remainingWords.remove(word);
+                                if (solveCrossword(puzzle, remainingWords)) {
+                                    return true;
+                                }
+                                remainingWords.add(word);
+                                removeWord(puzzle, word, row, col, vertical);
+                            }
+                        }
+                    }
+                    return false;
+                }
+            }
+        }
+        return true;
+    }
+}

src/main/java/com/thealgorithms/backtracking/CrosswordSolver.java

@@ -1,45 +1,51 @@
 package com.thealgorithms.backtracking;
 
-/*
- * Problem Statement :
- * Find the number of ways that a given integer, N , can be expressed as the sum of the Xth powers
- * of unique, natural numbers. For example, if N=100 and X=3, we have to find all combinations of
- * unique cubes adding up to 100. The only solution is 1^3+2^3+3^3+4^3. Therefore output will be 1.
+/**
+ * Problem Statement:
+ * Find the number of ways that a given integer, N, can be expressed as the sum of the Xth powers
+ * of unique, natural numbers.
+ * For example, if N=100 and X=3, we have to find all combinations of unique cubes adding up to 100.
+ * The only solution is 1^3 + 2^3 + 3^3 + 4^3. Therefore, the output will be 1.
+ *
+ * N is represented by the parameter 'targetSum' in the code.
+ * X is represented by the parameter 'power' in the code.
  */
 public class PowerSum {
 
-    private int count = 0;
-    private int sum = 0;
-
-    public int powSum(int n, int x) {
-        sum(n, x, 1);
-        return count;
+    /**
+     * Calculates the number of ways to express the target sum as a sum of Xth powers of unique natural numbers.
+     *
+     * @param targetSum The target sum to achieve (N in the problem statement)
+     * @param power The power to raise natural numbers to (X in the problem statement)
+     * @return The number of ways to express the target sum
+     */
+    public int powSum(int targetSum, int power) {
+        // Special case: when both targetSum and power are zero
+        if (targetSum == 0 && power == 0) {
+            return 1; // by convention, one way to sum to zero: use nothing
+        }
+        return sumRecursive(targetSum, power, 1, 0);
     }
 
-    // here i is the natural number which will be raised by X and added in sum.
-    public void sum(int n, int x, int i) {
-        // if sum is equal to N that is one of our answer and count is increased.
-        if (sum == n) {
-            count++;
-            return;
-        } // we will be adding next natural number raised to X only if on adding it in sum the
-          // result is less than N.
-        else if (sum + power(i, x) <= n) {
-            sum += power(i, x);
-            sum(n, x, i + 1);
-            // backtracking and removing the number added last since no possible combination is
-            // there with it.
-            sum -= power(i, x);
+    /**
+     * Recursively calculates the number of ways to express the remaining sum as a sum of Xth powers.
+     *
+     * @param remainingSum The remaining sum to achieve
+     * @param power The power to raise natural numbers to (X in the problem statement)
+     * @param currentNumber The current natural number being considered
+     * @param currentSum The current sum of powered numbers
+     * @return The number of valid combinations
+     */
+    private int sumRecursive(int remainingSum, int power, int currentNumber, int currentSum) {
+        int newSum = currentSum + (int) Math.pow(currentNumber, power);
+
+        if (newSum == remainingSum) {
+            return 1;
         }
-        if (power(i, x) < n) {
-            // calling the sum function with next natural number after backtracking if when it is
-            // raised to X is still less than X.
-            sum(n, x, i + 1);
+        if (newSum > remainingSum) {
+            return 0;
         }
-    }
 
-    // creating a separate power function so that it can be used again and again when required.
-    private int power(int a, int b) {
-        return (int) Math.pow(a, b);
+        return sumRecursive(remainingSum, power, currentNumber + 1, newSum) + sumRecursive(remainingSum, power, currentNumber + 1, currentSum);
     }
 }