Skip to content

Commit 49d1c84

Browse files
alxkmalxkm
and
alxkm
authored
refactor: ReverseString, test improvements (#5406)
* refactor: ReverseString * refactor: refactor testing into two methods * checkstyle: fix formatting * checkstyle: fix formatting --------- Co-authored-by: alxkm <[email protected]>
1 parent e3ad376 commit 49d1c84

File tree

2 files changed

+17
-25
lines changed

2 files changed

+17
-25
lines changed

src/main/java/com/thealgorithms/strings/ReverseString.java

-5
Original file line numberDiff line numberDiff line change
@@ -7,11 +7,6 @@ public final class ReverseString {
77
private ReverseString() {
88
}
99

10-
public static void main(String[] args) {
11-
assert reverse("abc123").equals("321cba");
12-
assert reverse2("abc123").equals("321cba");
13-
}
14-
1510
/**
1611
* easiest way to reverses the string str and returns it
1712
*

src/test/java/com/thealgorithms/strings/ReverseStringTest.java

+17-20
Original file line numberDiff line numberDiff line change
@@ -2,30 +2,27 @@
22

33
import static org.junit.jupiter.api.Assertions.assertEquals;
44

5-
import org.junit.jupiter.api.Test;
5+
import java.util.stream.Stream;
6+
import org.junit.jupiter.params.ParameterizedTest;
7+
import org.junit.jupiter.params.provider.Arguments;
8+
import org.junit.jupiter.params.provider.MethodSource;
69

710
public class ReverseStringTest {
811

9-
@Test
10-
public void testReverseString() {
11-
String input1 = "Hello World";
12-
String input2 = "helloworld";
13-
String input3 = "123456789";
14-
String input4 = "";
15-
16-
String expectedOutput1 = "dlroW olleH";
17-
String expectedOutput2 = "dlrowolleh";
18-
String expectedOutput3 = "987654321";
19-
String expectedOutput4 = "";
12+
private static Stream<Arguments> testCases() {
13+
return Stream.of(Arguments.of("Hello World", "dlroW olleH"), Arguments.of("helloworld", "dlrowolleh"), Arguments.of("123456789", "987654321"), Arguments.of("", ""), Arguments.of("A", "A"), Arguments.of("ab", "ba"),
14+
Arguments.of(" leading and trailing spaces ", " secaps gniliart dna gnidael "), Arguments.of("!@#$%^&*()", ")(*&^%$#@!"), Arguments.of("MixOf123AndText!", "!txeTdnA321fOxiM"));
15+
}
2016

21-
assertEquals(ReverseString.reverse(input1), expectedOutput1);
22-
assertEquals(ReverseString.reverse(input2), expectedOutput2);
23-
assertEquals(ReverseString.reverse(input3), expectedOutput3);
24-
assertEquals(ReverseString.reverse(input4), expectedOutput4);
17+
@ParameterizedTest
18+
@MethodSource("testCases")
19+
public void testReverseString(String input, String expectedOutput) {
20+
assertEquals(expectedOutput, ReverseString.reverse(input));
21+
}
2522

26-
assertEquals(ReverseString.reverse2(input1), expectedOutput1);
27-
assertEquals(ReverseString.reverse2(input2), expectedOutput2);
28-
assertEquals(ReverseString.reverse2(input3), expectedOutput3);
29-
assertEquals(ReverseString.reverse2(input4), expectedOutput4);
23+
@ParameterizedTest
24+
@MethodSource("testCases")
25+
public void testReverseString2(String input, String expectedOutput) {
26+
assertEquals(expectedOutput, ReverseString.reverse2(input));
3027
}
3128
}

0 commit comments

Comments
 (0)