Skip to content

Commit 3935b05

Browse files
committed
ref: refactor implementation
- Make TreeTraversal interface implementations final - Update tests
1 parent a0b9fd3 commit 3935b05

File tree

2 files changed

+6
-14
lines changed

2 files changed

+6
-14
lines changed

src/main/java/com/thealgorithms/datastructures/trees/SplayTree.java

Lines changed: 3 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -290,15 +290,7 @@ public void traverse(Node root, List<Integer> result) {
290290
}
291291
}
292292

293-
public static TreeTraversal getInOrderTraversal() {
294-
return new InOrderTraversal();
295-
}
296-
297-
public static TreeTraversal getPreOrderTraversal() {
298-
return new PreOrderTraversal();
299-
}
300-
301-
public static TreeTraversal getPostOrderTraversal() {
302-
return new PostOrderTraversal();
303-
}
293+
public static final TreeTraversal PRE_ORDER = new PreOrderTraversal();
294+
public static final TreeTraversal IN_ORDER = new InOrderTraversal();
295+
public static final TreeTraversal POST_ORDER = new PostOrderTraversal();
304296
}

src/test/java/com/thealgorithms/datastructures/trees/SplayTreeTest.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -74,12 +74,12 @@ public void testSearchInEmptyTree(int value) {
7474
}
7575

7676
private static Stream<Object[]> traversalStrategies() {
77-
return Stream.of(new Object[] {SplayTree.getInOrderTraversal(), Arrays.asList(1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 15, 16, 17, 18)}, new Object[] {SplayTree.getPreOrderTraversal(), Arrays.asList(18, 17, 16, 15, 13, 11, 9, 8, 7, 3, 2, 1, 5, 4, 6, 10, 12)},
78-
new Object[] {SplayTree.getPostOrderTraversal(), Arrays.asList(1, 2, 4, 6, 5, 3, 7, 8, 10, 9, 12, 11, 13, 15, 16, 17, 18)});
77+
return Stream.of(new Object[] {SplayTree.IN_ORDER, Arrays.asList(1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 15, 16, 17, 18)}, new Object[] {SplayTree.PRE_ORDER, Arrays.asList(18, 17, 16, 15, 13, 11, 9, 8, 7, 3, 2, 1, 5, 4, 6, 10, 12)},
78+
new Object[] {SplayTree.POST_ORDER, Arrays.asList(1, 2, 4, 6, 5, 3, 7, 8, 10, 9, 12, 11, 13, 15, 16, 17, 18)});
7979
}
8080

8181
private static Stream<Integer> valuesToTest() {
82-
return Stream.of(1, 5, 10, 17, 8, 13, 6);
82+
return Stream.of(1, 5, 10, 17, 8, 13, 6, 17, 4, 11, 9, 2, 18, 3, 16, 7, 12);
8383
}
8484

8585
private static Stream<Integer> nonExistentValues() {

0 commit comments

Comments
 (0)