Fix

Author: Hardvan

src/test/java/com/thealgorithms/misc/ThreeSumProblemTest.java

@@ -5,8 +5,11 @@
 import java.util.ArrayList;
 import java.util.Arrays;
 import java.util.List;
+import java.util.stream.Stream;
 import org.junit.jupiter.api.BeforeEach;
-import org.junit.jupiter.api.Test;
+import org.junit.jupiter.params.ParameterizedTest;
+import org.junit.jupiter.params.provider.Arguments;
+import org.junit.jupiter.params.provider.MethodSource;
 
 public class ThreeSumProblemTest {
 
@@ -17,60 +20,33 @@ public void setup() {
         tsp = new ThreeSumProblem(); // Initialize the class before each test
     }
 
-    @Test
-    public void testBruteForceValidTriplets() {
-        int[] nums = {1, 2, -3, 4, -2, -1};
-        int target = 0;
-        List<List<Integer>> expected = Arrays.asList(Arrays.asList(-3, 1, 2), Arrays.asList(-3, -1, 4));
+    @ParameterizedTest
+    @MethodSource("bruteForceTestProvider")
+    public void testBruteForce(int[] nums, int target, List<List<Integer>> expected) {
         assertEquals(expected, tsp.bruteForce(nums, target));
     }
 
-    @Test
-    public void testBruteForceNoTripletFound() {
-        int[] nums = {1, 2, 3, 4, 5};
-        int target = 50; // No valid triplet exists
-        List<List<Integer>> expected = new ArrayList<>(); // Expecting an empty list
-        assertEquals(expected, tsp.bruteForce(nums, target));
-    }
-
-    @Test
-    public void testTwoPointerValidTriplets() {
-        int[] nums = {0, -1, 2, -3, 1};
-        int target = 0;
-        List<List<Integer>> expected = Arrays.asList(Arrays.asList(-3, 1, 2), Arrays.asList(-1, 0, 1));
+    @ParameterizedTest
+    @MethodSource("twoPointerTestProvider")
+    public void testTwoPointer(int[] nums, int target, List<List<Integer>> expected) {
         assertEquals(expected, tsp.twoPointer(nums, target));
     }
 
-    @Test
-    public void testTwoPointerNegativeNumbers() {
-        int[] nums = {-5, -4, -3, -2, -1};
-        int target = -10;
-        List<List<Integer>> expected = Arrays.asList(Arrays.asList(-5, -4, -1), Arrays.asList(-5, -3, -2));
-        assertEquals(expected, tsp.twoPointer(nums, target));
+    @ParameterizedTest
+    @MethodSource("hashMapTestProvider")
+    public void testHashMap(int[] nums, int target, List<List<Integer>> expected) {
+        assertEquals(expected, tsp.hashMap(nums, target));
     }
 
-    @Test
-    public void testHashMapValidTriplets() {
-        int[] nums = {1, 2, -1, -4, 3, 0};
-        int target = 2;
-        List<List<Integer>> expected = Arrays.asList(Arrays.asList(-1, 0, 3), Arrays.asList(-1, 1, 2) // Check for distinct triplets
-        );
-        assertEquals(expected, tsp.hashMap(nums, target));
+    private static Stream<Arguments> bruteForceTestProvider() {
+        return Stream.of(Arguments.of(new int[] {1, 2, -3, 4, -2, -1}, 0, Arrays.asList(Arrays.asList(-3, 1, 2), Arrays.asList(-3, -1, 4))), Arguments.of(new int[] {1, 2, 3, 4, 5}, 50, new ArrayList<>()));
     }
 
-    @Test
-    public void testHashMapNoTripletFound() {
-        int[] nums = {5, 7, 9, 11};
-        int target = 10;
-        List<List<Integer>> expected = new ArrayList<>();
-        assertEquals(expected, tsp.hashMap(nums, target));
+    private static Stream<Arguments> twoPointerTestProvider() {
+        return Stream.of(Arguments.of(new int[] {0, -1, 2, -3, 1}, 0, Arrays.asList(Arrays.asList(-3, 1, 2), Arrays.asList(-1, 0, 1))), Arguments.of(new int[] {-5, -4, -3, -2, -1}, -10, Arrays.asList(Arrays.asList(-5, -4, -1), Arrays.asList(-5, -3, -2))));
     }
 
-    @Test
-    public void testHashMapEmptyArray() {
-        int[] nums = {};
-        int target = 0;
-        List<List<Integer>> expected = new ArrayList<>();
-        assertEquals(expected, tsp.hashMap(nums, target));
+    private static Stream<Arguments> hashMapTestProvider() {
+        return Stream.of(Arguments.of(new int[] {1, 2, -1, -4, 3, 0}, 2, Arrays.asList(Arrays.asList(-1, 0, 3), Arrays.asList(-1, 1, 2))), Arguments.of(new int[] {5, 7, 9, 11}, 10, new ArrayList<>()), Arguments.of(new int[] {}, 0, new ArrayList<>()));
     }
 }