Skip to content

Commit 2fe1a2a

Browse files
committed
Update code
1 parent 067af56 commit 2fe1a2a

File tree

6 files changed

+7
-21
lines changed

6 files changed

+7
-21
lines changed

src/main/java/com/thealgorithms/scheduling/diskscheduling/CircularLookScheduling.java

Lines changed: 6 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -48,27 +48,18 @@ public List<Integer> execute(List<Integer> requests) {
4848

4949
if (movingUp) {
5050
// Process all requests in the upward direction
51-
for (int request : upRequests) {
52-
result.add(request);
53-
}
51+
result.addAll(upRequests);
5452

5553
// Jump to the lowest request and process all requests in the downward direction
56-
if (!downRequests.isEmpty()) {
57-
result.addAll(downRequests);
58-
}
54+
result.addAll(downRequests);
5955
} else {
6056
// Process all requests in the downward direction (in reverse order)
61-
for (int i = downRequests.size() - 1; i >= 0; i--) {
62-
result.add(downRequests.get(i));
63-
}
57+
Collections.reverse(downRequests);
58+
result.addAll(downRequests);
6459

6560
// Jump to the highest request and process all requests in the upward direction (in reverse order)
66-
if (!upRequests.isEmpty()) {
67-
for (int i = upRequests.size() - 1; i >= 0; i--) {
68-
result.add(upRequests.get(i));
69-
}
70-
}
71-
61+
Collections.reverse(upRequests);
62+
result.addAll(upRequests);
7263
}
7364

7465
// Update current position to the last processed request

src/test/java/com/thealgorithms/scheduling/diskscheduling/CircularLookSchedulingTest.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@
44

55
import java.util.Arrays;
66
import java.util.List;
7-
87
import org.junit.jupiter.api.Test;
98

109
public class CircularLookSchedulingTest {

src/test/java/com/thealgorithms/scheduling/diskscheduling/CircularScanSchedulingTest.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@
44

55
import java.util.Arrays;
66
import java.util.List;
7-
87
import org.junit.jupiter.api.Test;
98

109
public class CircularScanSchedulingTest {

src/test/java/com/thealgorithms/scheduling/diskscheduling/LookSchedulingTest.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@
44

55
import java.util.Arrays;
66
import java.util.List;
7-
87
import org.junit.jupiter.api.Test;
98

109
public class LookSchedulingTest {

src/test/java/com/thealgorithms/scheduling/diskscheduling/SSFSchedulingTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@
55

66
import java.util.ArrayList;
77
import java.util.List;
8-
98
import org.junit.jupiter.api.BeforeEach;
109
import org.junit.jupiter.api.Test;
1110

@@ -53,4 +52,5 @@ public void testGetCurrentPositionAfterExecution() {
5352
int currentPosition = scheduler.getCurrentPosition();
5453
assertEquals(10, currentPosition, "Current position should be the last request after execution.");
5554
}
55+
5656
}

src/test/java/com/thealgorithms/scheduling/diskscheduling/ScanSchedulingTest.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@
44

55
import java.util.Arrays;
66
import java.util.List;
7-
87
import org.junit.jupiter.api.Test;
98

109
public class ScanSchedulingTest {
@@ -53,4 +52,3 @@ public void testScanScheduling() {
5352
System.out.println("Request Order: " + result);
5453
}
5554
}
56-

0 commit comments

Comments
 (0)